[python] Change the sudo_if function to avoid issues with Bash - #694
Merged
Samruddhi Khandale (samruddhikhandale) merged 10 commits intoSep 27, 2023
Conversation
- Remove double quotes to avoid issues with string tokenization
Alexander Smolyakov (alexander-smolyakov)
requested a review
from a team
as a code owner
September 20, 2023 09:11
This reverts commit 9e62a37.
Alexander Smolyakov (alexander-smolyakov)
requested a review
from Samruddhi Khandale (samruddhikhandale)
September 25, 2023 13:15
Samruddhi Khandale (samruddhikhandale)
approved these changes
Sep 26, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Left some minor comments, besides that LGTM
Samruddhi Khandale (samruddhikhandale)
previously approved these changes
Sep 26, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Left some minor comments, besides that LGTM
Alexander Smolyakov (alexander-smolyakov)
requested a review
from Samruddhi Khandale (samruddhikhandale)
September 27, 2023 09:05
Samruddhi Khandale (samruddhikhandale)
approved these changes
Sep 27, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thank you! 🚢
Alexander Smolyakov (alexander-smolyakov)
deleted the
python_fix-wrapper-function
branch
September 28, 2023 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR aims to resolve the
No such file or directoryerror when commands are executed via thesudo_iffunction.Changelog:
jupyterlabpackage under root user;jupyterlabtests;Attached related issue:
Checklist: