[common-utils] fix bug when user home is custom by base docker - #703
Merged
Samruddhi Khandale (samruddhikhandale) merged 3 commits intoSep 27, 2023
Merged
Conversation
Pablo Ulloa (prulloac)
force-pushed
the
common-utils-home
branch
from
September 26, 2023 02:07
a9fb986 to
ed0060e
Compare
Pablo Ulloa (prulloac)
marked this pull request as ready for review
September 26, 2023 02:07
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Thanks for contributing, we appreciate it ✨
Left some minor comments, besides that looks good to me.
Pablo Ulloa (prulloac)
requested a review
from Samruddhi Khandale (samruddhikhandale)
September 27, 2023 02:03
Samruddhi Khandale (samruddhikhandale)
approved these changes
Sep 27, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks great, thank you! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #639
main.sh first checks if user has home directory already set and different than /home/${USERNAME}. if it does, then uses the custom home directory, otherwise behaves as usual