[terraform] Update retry logic to handle DNS-related errors more gracefully - #713
Merged
Samruddhi Khandale (samruddhikhandale) merged 3 commits intoOct 4, 2023
Conversation
- Add `dnsutils` package to dependencies - Update retry logic to handle DNS-related errors more gracefully
Alexander Smolyakov (alexander-smolyakov)
requested a review
from a team
as a code owner
October 4, 2023 11:09
Samruddhi Khandale (samruddhikhandale)
approved these changes
Oct 4, 2023
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks good, thank you! 🎉
Alexander Smolyakov (alexander-smolyakov)
deleted the
terraform-update_retry_logic
branch
October 5, 2023 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR aims to update the retry logic to handle the
gpg: keyserver receive failed: Server indicated a failureerror more gracefully.The
gpgreturns thekeyserver receive failed: Server indicated a failureerror if something goes wrong with DNS-related stuff. It looks likegpgcould use several libraries for working with DNS servers based on macros values. Related code:This means that
gpgcould work with DNS servers differently than other tools.The fix is to try to get the IP address of the GPG keyserver and explicitly pass it to the gpg tool to avoid DNS-related issues.
Changelog:
dnsutilspackage added to dependencies;Attached related issue:
Checklist: