[Docker-in-docker] Updates docker-init scripts - #715
Merged
Samruddhi Khandale (samruddhikhandale) merged 2 commits intoOct 5, 2023
Conversation
Samruddhi Khandale (samruddhikhandale)
requested a review
from a team
as a code owner
October 5, 2023 18:13
joshspicer
approved these changes
Oct 5, 2023
Samruddhi Khandale (samruddhikhandale)
deleted the
samruddhikhandale/dnd-updates
branch
October 5, 2023 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkillon a process which is already terminated, then it returns exit code 1. This could result failing of the docker-init script. Hence, wrap it withinset