[Docker-outside-of-docker] Increase backlog depth for socat proxy (#789) - #790
Merged
Eljo George (eljog) merged 3 commits intoJan 19, 2024
Conversation
Member
|
Thank you for the contribution. Also, please consider adding more context and details to the PR description |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Eljo George (@eljog) Thanks for looking at this. I've added some details to the description, but refer to #789 for context. I hope that's alright. |
Member
|
I have approved to run the workflow checks |
Eljo George (eljog)
approved these changes
Jan 19, 2024
Kai Groner (groner)
deleted the
docker-outside-of-docker-socat-proxy-backlog-bump
branch
January 19, 2024 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying problem described in #789 is that the main
accept(2)loop insocatis single threaded and is easily overwhelmed by docker compose, which can create connection attempts in multiple cores.Fortunately the listening socket already has a backlog which we can increase from socat's default of 5.
In this PR I have chosen a depth of 128 as probably high enough for most devcontainer needs. If it isn't high enough this could be made tunable, but reevaluating the proxy implementation might be in order also.