sync install.sh to devcontainer-feature.json default values - #867
Merged
Samruddhi Khandale (samruddhikhandale) merged 3 commits intoFeb 23, 2024
Merged
Conversation
Lucas Fernando Cardoso Nunes (lucasfcnunes)
requested a review
from a team
as a code owner
February 16, 2024 16:34
Lucas Fernando Cardoso Nunes (lucasfcnunes)
force-pushed
the
main
branch
from
February 16, 2024 16:41
bb20451 to
e0399dd
Compare
Contributor
Author
|
@microsoft-github-policy-service agree |
Samruddhi Khandale (samruddhikhandale)
requested changes
Feb 22, 2024
Samruddhi Khandale (samruddhikhandale)
requested changes
Feb 22, 2024
Lucas Fernando Cardoso Nunes (lucasfcnunes)
changed the title
install.sh to devcontainer-feature.json default values
Signed-off-by: Lucas Fernando Cardoso Nunes <lucasfc.nunes@gmail.com>
Signed-off-by: Lucas Fernando Cardoso Nunes <lucasfc.nunes@gmail.com>
find `^[A-Z0-9_]+="\$\{[^:]+?\}`
on `install.sh` files
Signed-off-by: Lucas Fernando Cardoso Nunes <lucasfc.nunes@gmail.com>
Lucas Fernando Cardoso Nunes (lucasfcnunes)
force-pushed
the
main
branch
from
February 23, 2024 01:46
55f0718 to
8829f3f
Compare
Samruddhi Khandale (samruddhikhandale)
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
install.shenv vars to their respectivedevcontainer-feature.jsondefault valuesMOBYBUILDXVERSIONenv var.Execution
^[A-Z0-9_]+="\$\{[^:]+?\}oninstall.shfilesdevcontainer-feature.jsonfilesRelated