[kubectl-helm-minikube]: Handle failing build with fallback to prev. version for helm - #875
Merged
Samruddhi Khandale (samruddhikhandale) merged 10 commits intoFeb 28, 2024
Conversation
Samruddhi Khandale (samruddhikhandale)
requested changes
Feb 23, 2024
Gaurav Saini (gauravsaini04)
marked this pull request as draft
February 23, 2024 20:38
Gaurav Saini (gauravsaini04)
marked this pull request as ready for review
February 23, 2024 22:28
Samruddhi Khandale (samruddhikhandale)
requested changes
Feb 23, 2024
Gaurav Saini (gauravsaini04)
changed the title
Samruddhi Khandale (samruddhikhandale)
requested changes
Feb 27, 2024
Samruddhi Khandale (samruddhikhandale)
approved these changes
Feb 28, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks!
Gaurav Saini (gauravsaini04)
deleted the
kubectl-helm-minikube_fallback
branch
February 29, 2024 01:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #334
Feature Name:
Description:
This PR adds the following functionality:
helmis not able to download (i.e. it is not found) then download the previous version to the latestChangelog:
src/kubectl-helm-minikube/install.shsrc/kubectl-helm-minikube/devcontainer-feature.jsonChecklist: