Skip to content

[docker-outside-of-docker] compose-switch can fallback to previous version - #901

Merged
Samruddhi Khandale (samruddhikhandale) merged 2 commits into
devcontainers:mainfrom
gauravsaini04:docker-outside-of-docker_fallback_switch
Mar 11, 2024
Merged

[docker-outside-of-docker] compose-switch can fallback to previous version#901
Samruddhi Khandale (samruddhikhandale) merged 2 commits into
devcontainers:mainfrom
gauravsaini04:docker-outside-of-docker_fallback_switch

Conversation

@gauravsaini04

Copy link
Copy Markdown
Contributor

Feature name:

  • Docker-outside-of-Docker

Description:

This PR adds the following functionality:

  • Fallback mechanism for docker-compose-switch

Changelog:

  • Updated install.sh for docker-outside-of-docker feature.
  • Updated test file docker_build_compose_fallback.sh to verify that fallback mechanism works as expected through an added scenario in scenarios.json.

Checklist:

  • Checked that applied changes work as expected

Comment thread src/docker-outside-of-docker/install.sh Outdated
Comment thread src/docker-outside-of-docker/install.sh
Comment thread test/docker-outside-of-docker/docker_build_compose_fallback.sh Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! ⚡

@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit 8af4ce3 into devcontainers:main Mar 11, 2024
@gauravsaini04
Gaurav Saini (gauravsaini04) deleted the docker-outside-of-docker_fallback_switch branch March 11, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants