Skip to content

Reverting get_previous_version logic to get the first tag_name's value from json #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Samruddhi Khandale (samruddhikhandale) merged 5 commits into from
Mar 15, 2024
Merged

Reverting get_previous_version logic to get the first tag_name's value from json #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
503b889
changes as requested
gauravsaini04 Mar 10, 2024
71b2c91
Merge branch 'devcontainers:main' into changes_requested
gauravsaini04 Mar 11, 2024
b5ab4ad
changes acc. to comments
gauravsaini04 Mar 11, 2024
0e8adf4
Merge branch 'devcontainers:main' into changes_requested
gauravsaini04 Mar 13, 2024
fbdf1d9
Merge branch 'devcontainers:main' into changes_requested
gauravsaini04 Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/kubectl-helm-minikube/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "kubectl-helm-minikube",
"version": "1.1.7",
"version": "1.1.8",
"name": "Kubectl, Helm, and Minikube",
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/kubectl-helm-minikube",
"description": "Installs latest version of kubectl, Helm, and optionally minikube. Auto-detects latest versions and installs needed dependencies.",
Expand Down
4 changes: 2 additions & 2 deletions src/kubectl-helm-minikube/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ fi
# Function to fetch the version released prior to the latest version
get_previous_version() {
repo_url=$1
# this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name'
# this would del the assets key and then get the first encountered tag_name's value from the filtered array of objects
curl -s "$repo_url" | jq -r 'del(.[].assets) | .[0].tag_name'
Comment thread
gauravsaini04 marked this conversation as resolved.
}

get_helm() {
Expand Down
3 changes: 2 additions & 1 deletion test/docker-in-docker/docker_build_fallback_buildx.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ get_latest_version() {

# Function to fetch the previous version of the plugin
get_previous_version() {
curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name' # this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
# this would del the assets key and then get the first encountered tag_name's value from the filtered array of objects
curl -s "$repo_url" | jq -r 'del(.[].assets) | .[0].tag_name'
}

# Function to change the patch number in a semver version
Expand Down
2 changes: 1 addition & 1 deletion test/kubectl-helm-minikube/install_only_helm_fallback.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ change_patch_number() {
# Function to fetch the previous version of the plugin
get_previous_version() {
# this would del the assets key and then get the second encountered tag_name's value from the filtered array of objects
curl -s "$repo_url" | jq -r 'del(.[].assets) | .[1].tag_name'
curl -s "$repo_url" | jq -r 'del(.[].assets) | .[0].tag_name'
}

get_helm() {
Expand Down