Skip to content

[Powershell] - Fallback to prev. version - fix - #906

Merged
Samruddhi Khandale (samruddhikhandale) merged 2 commits into
devcontainers:mainfrom
gauravsaini04:powershell_fallback_fix
Mar 12, 2024
Merged

[Powershell] - Fallback to prev. version - fix#906
Samruddhi Khandale (samruddhikhandale) merged 2 commits into
devcontainers:mainfrom
gauravsaini04:powershell_fallback_fix

Conversation

@gauravsaini04

@gauravsaini04 Gaurav Saini (gauravsaini04) commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

Feature name:

  • Powershell

Description:

This PR introduces the following functionality:

  • When the latest tag for powershell doesn't have a source binary released yet, then it will continue installing the previous working version for which a source binary will be available

Changelog:

  • Updated install.sh
  • Updated tests to validate that when a fake powershell version is tried to be downloaded with curl command thus representing trying to access a source binary which is not deployed yet, then will pick up the binary for the tag which will eventually work successfully.
  • Updated devcontainer-feature.json to update the patch version for this feature.

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04
Gaurav Saini (gauravsaini04) requested a review from a team as a code owner March 12, 2024 13:55

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@samruddhikhandale
Samruddhi Khandale (samruddhikhandale) merged commit a674273 into devcontainers:main Mar 12, 2024
@gauravsaini04
Gaurav Saini (gauravsaini04) deleted the powershell_fallback_fix branch March 12, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants