[Terraform] feature fallback fix - #912
Merged
Samruddhi Khandale (samruddhikhandale) merged 26 commits intoMar 28, 2024
Merged
Conversation
Samruddhi Khandale (samruddhikhandale)
requested changes
Mar 15, 2024
Gaurav Saini (gauravsaini04)
marked this pull request as ready for review
March 17, 2024 14:30
Samruddhi Khandale (samruddhikhandale)
requested changes
Mar 18, 2024
Gaurav Saini (gauravsaini04)
marked this pull request as draft
March 27, 2024 04:33
Gaurav Saini (gauravsaini04)
marked this pull request as ready for review
March 27, 2024 16:20
Samruddhi Khandale (samruddhikhandale)
requested changes
Mar 27, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Overall it looks great, left some comments
Samruddhi Khandale (samruddhikhandale)
approved these changes
Mar 28, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks great, thank you! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR introduces the following functionality:
terraformfeature does not have a source binary released yet, then it will continue installing the previous working version for which a source binary will be availableterraformfeature -cosign, terraform, tflint, terragrunt, tfsec, terraform_docsChangelog:
install.shsuch that the fallback mechanism is properly configured for all these above listed tools/ packagescurlcommand thus representing a scenario when trying to access a source binary which is not deployed yet, then it will pick up the binary for the latest released tag which will eventually work successfully, and ifgithub apilimits are reached then will try to find a prev. version fromfind_prev_version_from_git_tags()function and get the binary for that instead.Checklist: