impl(pm-stack): contract test suite for publisher -> collector -> aggregator schemas (the #1110 failure class)

Finding

Evidence (live review 2026-10-26 ~22:40 CDT, laptop loopback + gh, cross-checked): Tonight's #1110 (orchestration section rejected over provenance object-vs-string) is the third shape-drift incident on this contract (run 1 of #899 had shape defects caught by a hand audit; the /today crash of Oct 26 was a publisher shape change). Each side tests against its own fixtures, so drift ships silently and surfaces as missing data on pages.

Proposal

A shared contract corpus: real published sections (orchestration, quota, dns, registry, projects) captured as golden fixtures in the repo, validated by (a) aggregator tests running isFleetFeed/isOrchestrationSection/etc. over the corpus, (b) collector tests asserting its output passes the same checks, (c) the orchestrator's pre-publish self-check running the aggregator's actual validator (vendored or via the aggregator package) rather than a prose description of it. Contract changes require corpus + both sides in one PR.

Acceptance

The corpus includes tonight's object-provenance orchestration section as a regression case (fails before fix(aggregator/orchestrator): orchestration section rejected — provenance is an object, isOrchestrationSection requires a string #1110's fix, passes after, whichever side changes).
CI runs both sides' contract tests on pm-stack changes.
Refs: fix(aggregator/orchestrator): orchestration section rejected — provenance is an object, isOrchestrationSection requires a string #1110, impl(orchestrator): recurring orchestration job — queue triage, priority ladder, blocker awareness, goal measurement #899.

Acceptance criteria

A shared contract corpus exists in the repo: real published sections (orchestration, quota, dns, registry, projects) captured as golden fixtures.
Aggregator tests validate the corpus with its real validators; collector tests assert its output passes the same checks; the orchestrator pre-publish self-check runs the aggregator's actual validator.
The corpus includes the object-provenance orchestration section from fix(aggregator/orchestrator): orchestration section rejected — provenance is an object, isOrchestrationSection requires a string #1110 as a regression case; CI runs both sides' contract tests on pm-stack changes.

CODE-312

Intake review

Fleet monitor intake enrichment (protocol §5) — 2026-10-28T06:26Z. This issue was filed 2026-10-27 by Drew (dezren39) from the 2026-10-26 live pm-stack review and had no priority/* label and no standard ## Acceptance criteria section; both are now supplied (the body's own Acceptance text is restated under the standard heading, original body preserved verbatim above it).

Related: Refs in body: fix(aggregator/orchestrator): orchestration section rejected — provenance is an object, isOrchestrationSection requires a string #1110 (the failure class), impl(orchestrator): recurring orchestration job — queue triage, priority ladder, blocker awareness, goal measurement #899. No merged PR explicitly references or resolves this issue.
Labels normalized: one kind/* (kept existing), source/human, status/needs-triage, priority/high, effort/m, app/pm-stack (existing), meta/enriched.
Still live: verified open this run; no merged PR or commit found that implements it.
Risks: Vendoring the validator risks a second drifting copy — the body's own requirement (orchestrator runs the aggregator's actual validator) is the control. Fixtures must be captured from real published sections, not hand-written.
Suggested approach: Capture fixtures from tonight's real feeds first (including the fix(aggregator/orchestrator): orchestration section rejected — provenance is an object, isOrchestrationSection requires a string #1110 regression case), then wire the same validator into collector tests and the orchestrator pre-publish check in one PR, per the body's one-PR rule for contract changes.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane code-j
Session / ID: task 7580
Found via: queue claim (fleet-monitor PR-bound shepherd task)
Task: shepherding PR test(pm-stack): add shared feed contract corpus (#1176) #4810 for issue impl(pm-stack): contract test suite for publisher -> collector -> aggregator schemas (the #1110 failure class) #1176 to merge — no re-implementation. Verified PR test(pm-stack): add shared feed contract corpus (#1176) #4810 OPEN at head 4b3ca2c with two independent reads. Its CI failures (the dashboard: clean up the page list (12 registered pages, overlaps to resolve) #1497 manifest decision-table test and the derived-briefs test) were branch staleness, proven on the laptop: both tests pass on clean main (9 pass) and failed on the PR's old base (2 fail). Merged current main into the branch (clean, cd6e19f); one corpus expectation in the contract-collector gate test was aligned to main's current pool-id shape (cline-pass, commit b8c3c0d). Full aggregator suite on the branch after the merge: 1507 pass, 0 fail. No Codex findings on PR test(pm-stack): add shared feed contract corpus (#1176) #4810. Merging now; the known pre-existing main typecheck errors (GhKind / overview conflicts) are unrelated and already on main.
Expectation: PR test(pm-stack): add shared feed contract corpus (#1176) #4810 merged; issue impl(pm-stack): contract test suite for publisher -> collector -> aggregator schemas (the #1110 failure class) #1176 closed by the merge.
Links: PR test(pm-stack): add shared feed contract corpus (#1176) #4810; branch queue/6558-1176-contract-corpus

Merge pull request #4810 from developing-today/queue/6558-1176-contra…

🤖 Agent note · done

Agent: queue worker (repo-worker-code), lane code-j
Session / ID: task 7580
Found via: queue claim (fleet-monitor PR-bound shepherd task)
Task: PR test(pm-stack): add shared feed contract corpus (#1176) #4810 merged (merge commit 7dd1b54) after the branch was refreshed with current main and the full aggregator suite passed on the laptop (1507 pass, 0 fail). Closing issue impl(pm-stack): contract test suite for publisher -> collector -> aggregator schemas (the #1110 failure class) #1176 — the PR title referenced it without a closing keyword, so it did not auto-close.
Expectation: done; no follow-up owed.
Links: PR test(pm-stack): add shared feed contract corpus (#1176) #4810 (merged)

Navigation Menu

Repository navigation

impl(pm-stack): contract test suite for publisher -> collector -> aggregator schemas (the #1110 failure class) #1176

Finding

Proposal

Acceptance

Acceptance criteria

Intake review

39 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

impl(pm-stack): contract test suite for publisher -> collector -> aggregator schemas (the #1110 failure class) #1176

Description

Finding

Proposal

Acceptance

Acceptance criteria

Activity

developing-today commented on Oct 27, 2026

dezren39 commented on Oct 28, 2026

Intake review

39 remaining items

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions