Skip to content

Aggregator: fail loud instead of defaulting to fixtures outside dev #1195

Closed

Description

@dezren39

Part of epic #1184 (PM stack coherence review, 2026-10-26).

Default source is fixtures; 'live' is set in exactly one install script. Evidence: config.ts loadConfig defaults to fixtures unless PM_AGG_SOURCE==='live'; only aggregator/install.sh writes PM_AGG_SOURCE=live into the rendered .env. Any other launch path silently serves fixtures, so a mis-deployed dashboard looks alive while entirely canned.

Acceptance:

  • Server refuses to start (or serves a full-page fixture warning) when source is unset outside a dev flag.
  • Boot tests cover live/fixtures/unset.
  • install.sh behaviour unchanged.

Acceptance criteria

  • The aggregator server refuses to start (or serves a full-page fixture warning) when the source is unset outside a dev flag.
  • Boot tests cover the live, fixtures, and unset source cases.
  • aggregator/install.sh behaviour is unchanged (it still renders PM_AGG_SOURCE=live).

Activity

  1. added
    kind/bugSomething isn't working (prefixed form of the classic bug label)
    priority/highImportant and time-sensitive
    app/pm-stackpm-stack (Pad/Grist) in developing-today/code
    on Oct 27, 2026
  2. developing-today commented on Oct 27, 2026

    @developing-today
    Contributor
  3. added
    source/humanFiled directly by a human
    effort/sSmall: expected under 2 hours of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Oct 28, 2026
  4. dezren39 commented on Oct 28, 2026

    @dezren39
    MemberAuthor

    Intake review

    Related: Part of epic #1184. Sibling batch: #1198, #1197, #1196.

    Notes / risks: Fail-loud must not break the dev flow: the dev flag path needs to stay one obvious switch, and install.sh (the one correct launch path) must be untouched.

    Suggested approach: A full-page warning is acceptable per the body's own acceptance; refusing to start is stronger — pick one and cover it in boot tests.

    Live check: verified still open and unheld this run; a merged-PR search on this run (2026-10-28T10:35:00Z) returned no PR resolving this issue, so it remains live work. Acceptance criteria appended to the body (original text preserved verbatim above it) and labels normalized by the fleet monitor.

  5. dezren39 commented on Nov 2, 2026

    @dezren39
    MemberAuthor

    Agent note — pickup

    • Task: 2471 (repo-health-code-pilot)
    • Worker: repo-worker-code; lane: 335a5d1f-bfc1-4831-99ea-850c8939a727
    • State: claimed; revalidated open/unheld, no resolving PR found.
    • Next: enqueue scoped small_fix packet for the confirmed source-default issue.
  6. added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    and removed on Nov 2, 2026
  7. 39 remaining items

  8. added
    status/parkedDeliberately paused with a recorded resume condition
    work/assignedQueue worker lifecycle state
    on Nov 4, 2026
  9. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · parked

  10. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · picked up

  11. added
    queue/claimedQueue worker lifecycle state
    and removed
    status/parkedDeliberately paused with a recorded resume condition
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Nov 4, 2026
  12. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · done

  13. chatgpt-codex-connector commented on Nov 4, 2026

    @chatgpt-codex-connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/pm-stackpm-stack (Pad/Grist) in developing-today/codeeffort/sSmall: expected under 2 hours of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/highImportant and time-sensitivesource/humanFiled directly by a humantask/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions