You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Aggregator: fail loud instead of defaulting to fixtures outside dev #1195
Part of epic #1184 (PM stack coherence review, 2026-10-26).
Default source is fixtures; 'live' is set in exactly one install script. Evidence: config.ts loadConfig defaults to fixtures unless PM_AGG_SOURCE==='live'; only aggregator/install.sh writes PM_AGG_SOURCE=live into the rendered .env. Any other launch path silently serves fixtures, so a mis-deployed dashboard looks alive while entirely canned.
Acceptance:
Server refuses to start (or serves a full-page fixture warning) when source is unset outside a dev flag.
Boot tests cover live/fixtures/unset.
install.sh behaviour unchanged.
Acceptance criteria
The aggregator server refuses to start (or serves a full-page fixture warning) when the source is unset outside a dev flag.
Boot tests cover the live, fixtures, and unset source cases.
aggregator/install.sh behaviour is unchanged (it still renders PM_AGG_SOURCE=live).
Notes / risks: Fail-loud must not break the dev flow: the dev flag path needs to stay one obvious switch, and install.sh (the one correct launch path) must be untouched.
Suggested approach: A full-page warning is acceptable per the body's own acceptance; refusing to start is stronger — pick one and cover it in boot tests.
Live check: verified still open and unheld this run; a merged-PR search on this run (2026-10-28T10:35:00Z) returned no PR resolving this issue, so it remains live work. Acceptance criteria appended to the body (original text preserved verbatim above it) and labels normalized by the fleet monitor.
State found: canonical PR fix(aggregator) reject implicit fixture source #4802 (queue/6552-1195-fixture-source-failloud, head 91d9113) is OPEN and states Closes #1195; its body matches the packet acceptance (live / explicit fixtures / unset-requires-PM_AGG_DEV=1). Only check on record is CodeRabbit (neutral) — no CI test checks in the rollup.
Next: revalidate PR fix(aggregator) reject implicit fixture source #4802 in depth — diff vs packet scope, Codex findings, mergeability against current main, and the aggregator boot tests on the laptop — then merge if verified, or park/block with the exact gap.
Verification (fresh this shift): PR diff reviewed against the packet acceptance — parseAggregatorSource in src/config.ts honors explicit live/fixtures, and unset/empty/invalid PM_AGG_SOURCE throws at startup unless PM_AGG_DEV=1; bun run dev sets the switch; install.sh untouched. PR was mergeable/clean against current main. Tests on the laptop (worktree ~/git/fleet/8861, PR branch with current origin/main merged locally): bun test across the 7 touched test files — 65 pass, 0 fail, including the source-gate boot tests (unset source refuses to start; unset + PM_AGG_DEV=1 boots fixtures).
Codex: the original Codex review on PR fix(aggregator) reject implicit fixture source #4802 failed to run (usage limits at open) and posted no findings; a re-review was requested this shift (@codex review) and had posted no findings at merge time.
Activity
developing-today commentedon Oct 27, 2026
CODE-329
dezren39 commentedon Oct 28, 2026
Intake review
Related: Part of epic #1184. Sibling batch: #1198, #1197, #1196.
Notes / risks: Fail-loud must not break the dev flow: the dev flag path needs to stay one obvious switch, and install.sh (the one correct launch path) must be untouched.
Suggested approach: A full-page warning is acceptable per the body's own acceptance; refusing to start is stronger — pick one and cover it in boot tests.
Live check: verified still open and unheld this run; a merged-PR search on this run (2026-10-28T10:35:00Z) returned no PR resolving this issue, so it remains live work. Acceptance criteria appended to the body (original text preserved verbatim above it) and labels normalized by the fleet monitor.
dezren39 commentedon Nov 2, 2026
Agent note — pickup
39 remaining items
dezren39 commentedon Nov 4, 2026
🤖 Agent note · parked
dezren39 commentedon Nov 4, 2026
🤖 Agent note · picked up
PM_AGG_SOURCEis unset outside dev.queue/6552-1195-fixture-source-failloud, head 91d9113) is OPEN and statesCloses #1195; its body matches the packet acceptance (live / explicit fixtures / unset-requires-PM_AGG_DEV=1). Only check on record is CodeRabbit (neutral) — no CI test checks in the rollup.fix(aggregator) reject implicit fixture source (#4802)
dezren39 commentedon Nov 4, 2026
🤖 Agent note · done
fixed_merged. PR fix(aggregator) reject implicit fixture source #4802 squash-merged (merge commit d53b4b2); issue Aggregator: fail loud instead of defaulting to fixtures outside dev #1195 CLOSED via the PR'sCloses #1195.parseAggregatorSourceinsrc/config.tshonors explicitlive/fixtures, and unset/empty/invalidPM_AGG_SOURCEthrows at startup unlessPM_AGG_DEV=1;bun run devsets the switch;install.shuntouched. PR was mergeable/clean against current main. Tests on the laptop (worktree~/git/fleet/8861, PR branch with current origin/main merged locally): bun test across the 7 touched test files — 65 pass, 0 fail, including the source-gate boot tests (unset source refuses to start; unset +PM_AGG_DEV=1boots fixtures).@codex review) and had posted no findings at merge time.chatgpt-codex-connector commentedon Nov 4, 2026
To use Codex here, create an environment for this repo.