e2e: editor-features test defects — image locator strict-mode + save payloads missing doc_id (#229 follow-up)

Follow-up to #229, from queue task 1240's classification of the isolated Firefox dispatch run 40402931464 (PR #987 branch). Two failures in pkgs/id/e2e/tests/editor-features.spec.ts are proven test defects, not product bugs:

:1098 "image node renders in markdown editor" — the uploaded image DID render with the correct /blob/… src (see the job-log failure block), but page.locator("#editor .ProseMirror img") also matches ProseMirror's internal <img class="ProseMirror-separator">, so toBeVisible() fails with a strict-mode violation on both attempts. Fix: scope the locator to the real image (e.g. img.pm-image).
:1601 (Image Alt-Text) and :1665 (Image Resize) — both POST /api/save with { name, doc } and no doc_id. SaveRequest.doc_id is a required String (pkgs/id/src/web/routes.rs:1077), so the payload is rejected before the handler and expect(saveResp.ok()) fails deterministically (~2–5s, both attempts). Every passing save in the same spec sends doc_id: hash from its /api/new response. Fix: do the same in these two tests.

Verified non-causes: a standalone codec probe converts both exact image docs to markdown successfully on current main, so PM→MD conversion is not the failure.

Acceptance criteria

:1098 locator matches only the uploaded image and the test passes in an isolated Firefox run.
:1601 and :1665 send doc_id from their /api/new response and pass the save assertion in an isolated Firefox run.
No product code changed; no other assertions weakened.

Evidence pack: goal hidden_files/probe-2026-10-27-t1240/failures.txt (failure blocks editor-features 2/3/4), classification comment on #229 by queue task 1240.

CODE-362

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), Lane B shift
Session / ID: queue task 1249, 2026-10-27T04:06Z
Found via: queue claim
Task: Fix the two proven test defects: scope the :1098 image locator to img.pm-image, and add doc_id (from the /api/new response) to the :1601 and :1665 /api/save payloads. Tests only, no product code.
Expectation: s — done looks like a PR open with the three edits, verified by an isolated Firefox dispatch for editor-features.spec.ts, then merged.
Links: parent classification on Stabilize shared-state failures in Firefox E2E CI #229 (comment 6433471104)

🤖 Agent note · parked

Agent: queue worker (repo-worker-code), Lane B shift
Session / ID: queue task 1249, 2026-10-27T04:13Z
Found via: queue claim
Task: Fixes implemented in PR test(id-e2e): fix editor-features image test defects (#1228) #1238 @4c7ff8f9 (branch queue/1249-1228-editor-test-defects): :1098 locator scoped to img.pm-image; :1601/:1665 save payloads now send doc_id from /api/new. TS syntax verified (Bun transpiler). Parked on CI: PR checks pending + acceptance dispatch run 40448341046 (id e2e nightly on the branch) queued.
Expectation: resume when the dispatch completes — verify the three tests pass in its Firefox e2e and PR checks are green, then merge PR test(id-e2e): fix editor-features image test defects (#1228) #1238 (auto-closes this issue) and complete task 1249.
Links: PR test(id-e2e): fix editor-features image test defects (#1228) #1238 · run https://github.com/developing-today/code/actions/runs/40448341046

🤖 Check-in — fleet monitor

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: cron repo-fleet-monitor, run 2026-10-27 03:27 CDT
Found via: monitor reconciliation (in-progress tracker, protocol §6.3)
Task: Check-in on parked task 1249 for this issue: park note (04:13Z) says resume = PR test(id-e2e): fix editor-features image test defects (#1228) #1238 checks green, then merge and complete task 1249; PR test(id-e2e): fix editor-features image test defects (#1228) #1238 is still open at this check and the park is ~5h old against an s-class (2h) expectation.
Expectation: holder (queue worker) please checkpoint, resume, or hand off on the next shift; if the resume condition cannot fire, post a fresh park note naming the new condition.

🤖 Agent note · handed off

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: cron repo-fleet-monitor, run 2026-10-27 05:29 CDT
Found via: monitor reconciliation
Task: Escalation requeue — this item's fix PR has been open with no activity since ~04:20Z, its parked queue task sat ~7h past its s-class deadline, its named resume condition already fired (the clippy: panic! in #1043 MisplacedNode test (markdown.rs:1999) breaks clippy-lint on main for every PR #1245 clippy fix merged as PR fix(clippy): replace panic! in MisplacedNode test so clippy-lint passes (#1245) #1299 at 08:30Z), and the check-in posted at 09:20Z drew no response. The parked task was cancelled (reason: superseded) and the work requeued as a PR-shepherd task (see the new task in repo-health-code-pilot keyed to the PR). Labels reset to queue/queued + status/needs-triage. Next holder: read the PR's checks fresh, update the branch with main if CI needs it, merge if green, verify this issue auto-closes.
Expectation: effort/s; done = PR merged and issue verified closed.

🤖 Agent note · handed off

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: repo-fleet-monitor run 2026-10-27 12:23 CDT — Duty 1 safety-net reconciliation
Found via: monitor reconciliation
Task: safety-net reconciliation — this issue carries queue/queued but has NO live task in repo-health-code-pilot, and the monitor cannot re-enqueue it with a standard packet.
Expectation: operator repair (see below).
Links: fix task 1249 (cancelled 2026-10-27T10:58Z), shadow-queue task 1471, system limitation tracked in fleet(queue): repo-queue.py — add list/inspect, surface dedupe hits, document priority direction #1289

Why it is stuck: the prior monitor run's triage packet for this issue landed in repo-health-code-SHADOW as task 1471 (the enqueue omitted --queue repo-health-code-pilot, and the helper's default queue is the shadow queue) — the pilot worker never claims shadow tasks. Re-enqueueing to the pilot returns the existing dedupe row instead of creating a task, and the fix dedupe key returns cancelled task 1249. Until the queue gains a requeue/revive path (#1289), this item needs operator repair (move/revive task 1471 into the pilot queue, or free the dedupe key); it is flagged prominently in the monitor's run summary. The shadow task is being left in place — it holds the correct packet.

🤖 Agent note · bound

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: queue task 1368 · fleet-monitor run 2026-10-28 22:19 CDT
Found via: monitor reconciliation (Duty 1B PR↔queue)
Task: Binding — open PR test(id-e2e): fix editor-features image test defects (#1228) #1238 implements this issue (verified by the monitor: PR title/body/head branch read this run). Pickup route: queue-lane session (PR opened from branch queue/1249-1228-editor-test-defects by task 1249's session; queued task 1368 is the pr_shepherd for this PR). The pickup never landed a queue binding and never applied the §9 GitHub layer (no queue/claimed / work labels, no pickup agent note) — the queued task is therefore to be treated as PARKED on this PR: resume as the PR's shepherd — review CI, merge when green, do NOT re-implement. Queue-side claim/park by the monitor is pending the by-id claim/bind verb (Dispatcher v1 live: scheduled launches of OpenCode/OpenChamber sessions for queued issues #1337); until it lands, this note is the binding record a lane's revalidation will find.
Expectation: PR shepherded to merge; no duplicate implementation.
Links: PR test(id-e2e): fix editor-features image test defects (#1228) #1238 · queue task 1368

🤖 Agent note · bound

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: queue task 1368 · fleet-monitor run 2026-10-28 22:19 CDT
Found via: monitor reconciliation (Duty 1B PR↔queue)
Task: Binding — open PR test(id-e2e): fix editor-features image test defects (#1228) #1238 implements this issue (verified by the monitor: PR title/body/head branch read this run). Pickup route: queue-lane session (PR opened from branch queue/1249-1228-editor-test-defects by task 1249's session; queued task 1368 is the pr_shepherd for this PR). The pickup never landed a queue binding and never applied the §9 GitHub layer (no queue/claimed / work labels, no pickup agent note) — the queued task is therefore to be treated as PARKED on this PR: resume as the PR's shepherd — review CI, merge when green, do NOT re-implement. Queue-side claim/park by the monitor is pending the by-id claim/bind verb (Dispatcher v1 live: scheduled launches of OpenCode/OpenChamber sessions for queued issues #1337); until it lands, this note is the binding record a lane's revalidation will find.
Expectation: PR shepherded to merge; no duplicate implementation.
Links: PR test(id-e2e): fix editor-features image test defects (#1228) #1238 · queue task 1368

Navigation Menu

Repository navigation

e2e: editor-features test defects — image locator strict-mode + save payloads missing doc_id (#229 follow-up) #1228

Acceptance criteria

4 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

e2e: editor-features test defects — image locator strict-mode + save payloads missing doc_id (#229 follow-up) #1228

Description

Acceptance criteria

Activity

developing-today commented on Oct 27, 2026

dezren39 commented on Oct 27, 2026

4 remaining items

dezren39 commented on Oct 27, 2026

dezren39 commented on Oct 27, 2026

dezren39 commented on Oct 27, 2026

dezren39 commented on Oct 27, 2026

dezren39 commented on Oct 29, 2026

dezren39 commented on Oct 29, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions