Skip to content

Meta-reviewer: grade the reviewers, score model/effort choices, and evolve the reviewer guidelines #1340

Open

Description

@dezren39

Work (Drew, 2026-10-27)

A daily meta-reviewer job (pool-meta-reviewer) reviews the
reviewers — the quota steward, the lane shifts, the dispatcher, the
babysitter, the diff reviewers — and closes the learning loop:

  • Audit the steward's change ledger: every change has an event,
    every event has a measured outcome, predictions vs actuals scored.
    Changes that didn't do what they claimed get named, with the
    evidence.
  • Grade model/effort choices by outcome across the window: per pool
    and per effort level — completion rate, stall rate, rework
    (reopened issues, follow-up fixes), cost per merged PR, wall-clock
    per task. Answer, with data, the standing questions: when does
    model-up + effort-down beat model-down + effort-up? Where is max
    effort buying nothing (equal outcomes at high)? Where is a pool
    failing tasks a stronger pool would have finished?
  • Update the reviewer guidelines (living doc in the goal
    workspace files/) from the evidence: routing defaults, effort
    assignment heuristics, nudge/steward thresholds. Guideline changes
    are dated, evidence-linked, and themselves reviewed next cycle —
    the guidelines carry a changelog the meta-reviewer appends to.
  • Escalate to Drew only decisions that are genuinely his (new pool,
    new provider, spend-class change); everything inside the POOL MAP
    is the fleet's to tune and report.

Acceptance criteria

  • Job live; first daily review produced with per-pool/per-effort
    outcome tables from real fleet data.
  • Guidelines doc exists with its first evidence-based revision
    and changelog.
  • At least one standing question (max-effort waste, model-up/
    effort-down crossover) answered with fleet numbers, or an
    explicit "insufficient data, collecting via ".

Child of the pool & routing intelligence epic. Filed by Muse
(operator) 2026-10-27.

Activity

  1. developing-today commented on Oct 27, 2026

    @developing-today
    Contributor
  2. added
    priority/normalOrdinary priority (the default)
    queue/queuedHas a queued task in the Supabase agent queue
    area/infraInfrastructure, deployment, and operations
    effort/mMedium: expected under 1 day of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Oct 27, 2026
  3. added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Oct 28, 2026
  4. 3 remaining items

  5. added
    queue/queuedHas a queued task in the Supabase agent queue
    source/creatorFiled by the new-issue-creator job
    task/triageQueue packet kind: verify, reproduce, and route this item
    and removed
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    on Oct 28, 2026
  6. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  7. added
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 3, 2026
  8. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    state: picked_up
    Picked up queue task 7682 (triage #1340) on the OpenChamber scheduled lane (lane 7b47536b-c162-444c-be8a-3a9538cc4cb5, worker repo-worker-code).
    This is a re-triage, not a restart: the 2026-10-28 lane-A triage (task 1324) already declared the design live and routed the single remainder to code#1582. I am revalidating that verdict against current state rather than repeating the decomposition.
    Found via: queue claim (coverage pass 2026-11-03)

  9. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · triaged (re-triage; verdict: design live and iterating, one real criterion still unmet and already routed)

    Acceptance criteria, verified 2026-11-03T15:10Z

    • ✅ Job live, daily reviews produced. pool-meta-reviewer has completed eight daily runs; latest is hidden_files/meta-review/2026-11-03-report.md (+ -evidence.md) for the window 2026-11-02T13:12Z–2026-11-03T13:12Z. It is doing the charged work: steward ledger audit with named corrections, prediction scoring, per-pool walls/rotation analysis.
    • ✅ Guidelines doc with evidence-based revision + changelog. files/reviewer-guidelines.md (49 KB, last revised 2026-11-03T07:56 local) carries an append-only changelog; the 2026-11-03 run appended four dated, evidence-linked entries (telemetry graded by adoption share; disabled decision-maker graded on active span; expired closures; nudges graded on outcomes).
    • ⚠️ Criterion 3 is satisfied in its allowed "insufficient data, collecting via " form — with one correction to the prior triage. The standing questions (model-up+effort-down vs model-down+effort-up; where max effort buys nothing) remain no controlled data, eighth window running, and are stated as such with the named unblocker. Separately, a standing question was answered with fleet numbers for the first time: nudge accuracy (2 nudges, both to confirmed stalls, both resolved, 0 false alarms).
    • ❌ Criterion 1 is still genuinely unmet. Per-pool/per-effort outcome tables are not produced from real fleet data — the cells are labelled THIN.

    Where the remainder actually stands (this is what changed since 2026-10-28)

    The prior triage routed the telemetry remainder to #1582, expecting collection to start on landing. It landed — #1582 CLOSED COMPLETED 2026-11-02T22:18:19Z, and I verified the mechanism locally: repo-task/v1 now defines $defs.completion_telemetry (pool, model, effort, cost_usd, all optional/additive), and repo-queue.py carries TELEMETRY_FIELDS plus a --telemetry argument on complete.

    But collection did not start: 846 tasks completed after the landing and exactly 1 carries any telemetry key, null-valued. That gap is now filed as #4919 (created 2026-11-03T13:47Z, OPEN, already queue/queued — its own task exists). So the blocker for criterion 1 has moved from "mechanism missing" (#1582) to "adoption missing" (#4919). The 2026-10-28 prediction is superseded, not wrong: the mechanism exists, workers don't pass the fields.

    Blocker and ordering

    1. fleet telemetry adoption: workers complete tasks without pool/model/effort/cost fields (1 of 846 post-#1582 completions) #4919 — worker/lane completion discipline must make telemetry the default on complete (its queue task).
    2. A full daily window showing most fleet-session completions carrying non-null pool/model/effort.
    3. The next daily meta-reviewer run publishing at least one per-pool or per-effort cell with n≥3 from real rows — this is what flips Meta-reviewer: grade the reviewers, score model/effort choices, and evolve the reviewer guidelines #1340's criterion 1 and closes this tracker.

    No implementation work remains on #1340 itself. It stays open as the parent tracker for that one dependent step; closing it now would strand criterion 1 with no tracker. No Drew escalation: everything is inside the POOL MAP the fleet may tune, per the issue's own escalation rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/infraInfrastructure, deployment, and operationseffort/mMedium: expected under 1 day of workkind/featureNew feature or capability requestmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)source/creatorFiled by the new-issue-creator jobstatus/triagedTriaged and routed (see agent note)task/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions