id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022)

Finding

PR #1022 (merged, merge commit 76672b9) preserves spaced link/image destinations by swapping each one for a deterministic placeholder before rendering and restoring it afterwards with a global string replace over the whole rendered document:

pkgs/id/src/web/markdown.rs (current main):

:1100-1103 — placeholder is format!("idweb-spaced-destination-{}-placeholder", substitutions.len()), derived only from the substitution index; nothing checks whether that token already occurs in the document.
:1070-1072 — restoration is output = output.replace(&placeholder, &format!("<{raw}>")), which replaces EVERY occurrence in the rendered markdown, not just the destination the renderer emitted.

Why it matters

If the document's own text (or a code block, or another non-spaced destination) literally contains idweb-spaced-destination-0-placeholder and the document also has a spaced link/image destination, the save direction rewrites the document's own text into <the spaced destination> — silent content corruption on save, in the same codec family as the %20 mutation #1022 set out to fix. The token is fixed and guessable, so the collision does not require exotic input for anyone documenting this codec. The tests added by #1022 cover destinations, titles, and editor hrefs, but not a document that already contains the placeholder token. Verified still present on current main (2026-10-27).

Evidence

PR: fix(id-web): preserve spaced link/image destinations in angle form on save (#1019) #1022 — fix(id-web): preserve spaced link/image destinations in angle form on save (#1019)
pkgs/id/src/web/markdown.rs:1081 substitute_spaced_destinations — no scan of existing document text/URLs before choosing tokens
pkgs/id/src/web/markdown.rs:1070-1072 — global str::replace restoration
Dedup: id(web): link/image destinations with a space are silently rewritten to %20 on save — angle-bracket form lost, relative file links break #1019 (closed) was the %20 rewrite itself; no open or closed issue mentions the placeholder collision.

Acceptance criteria

Placeholder tokens are chosen so they cannot collide with content already in the document (e.g. scan the AST's text/literal/url content and keep extending/randomizing the token until it is absent), OR restoration is scoped to the rendered destination positions instead of a global replace.
Regression test: a document containing the literal current token text plus a spaced link destination round-trips with the literal text unchanged and the destination in <...> angle form.
Existing id(web): link/image destinations with a space are silently rewritten to %20 on save — angle-bracket form lost, relative file links break #1019 tests (spaced link, spaced image, title, editor href) still pass and round-trips remain fixpoints.

CODE-450

🤖 Agent note · filed

Agent: pr-diff-review job
Session / ID: pr-diff-review cron run 2026-10-27T07:28:52Z
Found via: filed this run
Task: Triage this PR-diff-review finding against current main (queued as a repo-task/v1 triage packet)
Expectation: effort class s — verify the finding against current main, then scope the fix
Links: source PR and evidence in the issue body

🤖 Agent note · handed off

Agent: OpenCode queue worker (repo-worker-code)
Session / ID: task 1330 · session ses_e5e61690526ffeSFvIpaO4hynT
Found via: queue claim · OpenCode claimant launch
Task: Work task 1330 for issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348: Triage id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348: spaced-destination placeholder collision rewrites document text on save (PR fix(id-web): preserve spaced link/image destinations in angle form on save (#1019) #1022)
Expectation: packet-defined; follow the packet acceptance criteria and repository runbook.
Links: id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348

fix(id-web): collision-proof spaced-destination placeholders on save (#…

🤖 Agent note · state: handed off

Agent: OpenCode queue worker launcher (repo-worker-code)
Session / ID: task 6722 · session ses_e5e60bd3d74ffewwDg1Qd0n2Qa
Found via: queue claim · OpenCode claimant launch
Task: Task 6722 for issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 was bound at launch to this session.
Expectation: packet-defined; follow the packet acceptance criteria and repository runbook. Delivery status: the session exists but has no user message after one same-session resend; prompt delivery failed. The claim remains bound and will not be relaunched before lease expiry.
Links: id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 · task 6722 (repo-health-code-pilot)

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-e
Session / ID: task 10682
Found via: queue claim
Task: Handed off task 10682 (pr_shepherd) for issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 to the opencode claimant — execution lane assigned opencode. Fresh check: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 OPEN, no hard-stop labels.
Expectation: claimant launches the bound opencode session and drives task 10682 to a terminal state
Links: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-e
Session / ID: task 10682
Found via: queue claim
Task: Handed off task 10682 (pr_shepherd) for issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 to the opencode claimant — execution lane assigned opencode. Fresh check: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 OPEN, no hard-stop labels.
Expectation: claimant launches the bound opencode session and drives task 10682 to a terminal state
Links: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-u
Session / ID: task 10682
Found via: queue claim
Task: handing off task 10682 (issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348) to the opencode claimant per execution-lane assignment
Expectation: claimant launches the bound opencode session and drives task 10682 to a terminal state
Links: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-e
Session / ID: task 10682
Found via: queue claim
Task: handing task 10682 for issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 to the opencode claimant (assigned_lane=opencode); claimant launches the bound opencode session
Expectation: claimant picks up task 10682; attempts 10/16
Links: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-k
Session / ID: task 10682
Found via: queue claim
Task: Shepherd PR fix(id-web): collision-proof spaced-destination placeholders on save (#1348) #4665 for issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 — execution lane assigned opencode; handing off to the opencode claimant. Fresh check: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348 OPEN (user/review, no hard-stop labels), PR fix(id-web): collision-proof spaced-destination placeholders on save (#1348) #4665 OPEN.
Expectation: claimant launches the bound opencode session; that session drives task 10682 to a terminal state.
Links: issue id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348, PR fix(id-web): collision-proof spaced-destination placeholders on save (#1348) #4665

Navigation Menu

Repository navigation

id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348

Finding

Why it matters

Evidence

Acceptance criteria

83 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

id(web): spaced-destination placeholder can collide with document text — global replace on save rewrites the document's own words (PR #1022) #1348

Description

Finding

Why it matters

Evidence

Acceptance criteria

Activity

developing-today commented on Oct 27, 2026

dezren39 commented on Oct 27, 2026

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 3, 2026

83 remaining items

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions