mcpx: elicitation storage is readable by any local user and never pruned; elicitation UI and response validation rows #1954

Activity

1. developing-today commented on Oct 28, 2026

   

   developing-todayBot

   on Oct 28, 2026 – with developing.today

   Contributor

   More actions

   CODE-879
2. dezren39 commented on Oct 28, 2026

   

   dezren39

   on Oct 28, 2026

   MemberAuthor

   More actions

   History carried over from dezren39/darwin-nix#255 (verbatim, oldest first):

   ---

   @dezren39 · 2026-10-27T15:35:54Z

   Intake review

   Fleet monitor intake pass, 2026-10-27 (repo-fleet-monitor).

   Related: the 2026-09-30 mcpx conformance set — parent analysis #252, siblings #253, #254, #255, #256, #257, #258, #259 (filed together from docs/spec/conformance-matrix.md in dezren39/nix). Treat the set as one body of work; do not re-file per-gap issues.

   Notes: Filed as kind/security at priority normal (monitor judgment): the storage half (readable by any local user, never pruned) is a genuine local information-exposure issue, distinct from the UI/validation conformance rows bundled with it. 16 rows total (storage 5, UI 7, validation 4).

   Risks: Permission tightening that breaks the broker's own readers — verify the daemon and CLI still read the store after the change.

   Suggested approach: storage permissions + pruning first (the security substance), then schema validation, then UI rows.
3. dezren39

   added

   kind/securitySecurity issue or security hardeningSecurity issue or security hardening

   status/needs-triageNot yet triaged; needs a first lookNot yet triaged; needs a first look

   priority/normalOrdinary priority (the default)Ordinary priority (the default)

   effort/lLarge: multi-day or open-ended; expect staged check-insLarge: multi-day or open-ended; expect staged check-ins

   meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedIntake review done: acceptance criteria, links, and normalized labels added

   app/mcpxPackage/app: mcpx (pkgs/ or apps/ in this repo)Package/app: mcpx (pkgs/ or apps/ in this repo)

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   on Oct 28, 2026
4. github-actions

   assigned

   dezren39

   on Oct 29, 2026
5. dezren39

   added

   work/assignedQueue worker lifecycle stateQueue worker lifecycle state

   queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

   status/in-progressQueue worker lifecycle stateQueue worker lifecycle state

   and removed

   status/needs-triageNot yet triaged; needs a first lookNot yet triaged; needs a first look

   queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

   on Oct 29, 2026
6. 17 remaining items

   Load more
7. dezren39

   removed

   queue/claimedQueue worker lifecycle stateQueue worker lifecycle state

   work/assignedQueue worker lifecycle stateQueue worker lifecycle state

   on Oct 30, 2026
8. dezren39 commented on Oct 30, 2026

   

   dezren39

   on Oct 30, 2026

   MemberAuthor

   More actions

   agent-note:v1
   event: done
   task: 3250 (repo-health-code-pilot, lane D) — completed, outcome pr_opened
   pr: #2646
   state: Criterion 1 (pruning) verified ALREADY DONE on main via #1677 — pruneTerminal on Broker.Open, bounds in internal/defaults (ElicitRetentionMaxAge / ElicitRetentionMaxTerminalRows), tests in internal/elicit/prune_test.go; no change made. Criterion 2 implemented in PR 2646 @ a9cc5f4: Broker.Respond validates accepted form content against the question's requestedSchema (internal/schemaval) before recording/relay; mismatch refused with failing paths, question stays pending; uncompilable schema recorded unvalidated (asker's defect, mirroring mcpclient). Laptop: full internal/elicit tests pass, vet clean. Remaining: CI green on PR 2646 + merge (fleet CI jam permitting); criterion 3 (elicitation UI rows) stays on this issue.
9. dezren39 commented on Oct 31, 2026

   

   dezren39

   on Oct 31, 2026

   MemberAuthor

   More actions

   🤖 Agent note · #1678 Phase 3 evidence (queue task 3662)

   The review-first elicit surface from #1678 has landed as PR #3011:

   • URL questions now print the registrable domain under the full URL, with both host forms + a punycode warning for xn--/non-ASCII hosts.
   • Form questions carry schema defaults in the field detail and the answer example.
   • Interactive mcpx elicit answer renders the parsed answer back — credential-shaped values masked as set/not set via the shared elicit.IsSensitiveField — and relays only on confirmation (--yes / non-interactive behaviour unchanged).
   • The six elicit-ui conformance gaps are retired, and the remaining fix(id): coalesce LogSync ingest batches (#241) #255 register text here no longer claims world-readable storage (owner-only 0700/0600 since mcpx: Phase 1 of #1675 — owner-only elicitation broker store (0700 dir, 0600 files, migration on open) #1676, PR mcpx: owner-only elicitation broker store (0700/0600) with migration on open (#1676) #1724).

   Remaining slice for this issue: server-relay validation of received elicitation data — elicitation-server-validate-received-data — i.e. the receiving/relay side validating answers, beyond the client surface above. (Broker-side validation of accepted form answers against the requested schema is tracked separately on this issue's PR #2646.) This comment is evidence only; #1954 stays open for that remaining slice.
10. dezren39

    added

    queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

    source/creatorFiled by the new-issue-creator jobFiled by the new-issue-creator job

    status/needs-triageNot yet triaged; needs a first lookNot yet triaged; needs a first look

    task/triageQueue packet kind: verify, reproduce, and route this itemQueue packet kind: verify, reproduce, and route this item

    on Nov 3, 2026
11. dezren39 commented on Nov 3, 2026

    

    dezren39

    on Nov 3, 2026

    MemberAuthor

    More actions

    🤖 Agent note · done (triaged → already implemented; closing with evidence)

    • Agent: queue worker (repo-worker-code), lane aea12c82-c5af-4e5a-9b66-f8e360f87177
    • Session / ID: task 7803 (openchamber scheduled lane, triage packet)
    • Found via: queue claim (coverage pass 2026-11-03)
    • Verdict: every acceptance criterion on this issue is now implemented and tested in pkgs/mcpx; nothing is left of the three gap keys (elicit-storage, elicit-ui, elicit-validation). The work landed as the three phases of design(mcpx): elicitation broker hygiene — owner-only store, bounded retention, redacted events, review-first answering #1675, and mcpx: Phase 3 of #1675 — review-first mcpx elicit surface + nix#255 truth-up #1678 explicitly carried this issue's nix#255 tracking.
    • Evidence (verified at HEAD e438032cd, 2026-11-03):
      1. Owner-only store — internal/elicit/store.go sets storeFileMode = 0o600 and creates the directory 0700, chmod-if-looser; TestOpenAtCreatesOwnerOnlyStore asserts 0700/0600 on disk (phase mcpx: Phase 1 of #1675 — owner-only elicitation broker store (0700 dir, 0600 files, migration on open) #1676, closed).
      2. Pruning — internal/elicit/elicit.go prunes terminal rows on open against the elicit.ttl / elicit.maxAge bounds (pruneTerminal, deadline = min(lastTouched+ttl, created+maxAge)); TestOpenPrunesTerminalRowsPastTheAgeBound pins it (phase mcpx: Phase 2 of #1675 — broker retention bound + summary-only elicitation events #1677, closed; events are summary-only too).
      3. Answering surface shows the asking server + review — the mcpx elicit list line prints r.Server and the detail view prints from <server>; the review-first surface renders schema defaults, the registrable domain, a punycode warning, and a masked confirm-before-relay (TestRenderAnswerReviewMasksSensitiveFields, TestRenderQuestionFormShowsSchemaDefaults, TestRenderQuestionURLShowsRegistrableDomain, TestRenderQuestionURLWarnsOnPunycodeHost) (phase mcpx: Phase 3 of #1675 — review-first mcpx elicit surface + nix#255 truth-up #1678, closed).
      4. Schema validation before relay — internal/mcpclient rejects wrong-typed answers with 32602 instead of relaying them (TestElicitationAnswersValidatedAgainstRequestedSchema), backed by internal/schemaval.
    • Tests run this pass (pkgs/mcpx): go test ./internal/elicit/ → ok (7.3s); go test ./internal/cli/ -run 'TestRenderQuestion|TestRenderAnswerReview' → ok; go test ./internal/mcpclient/ -run TestElicitationAnswersValidatedAgainstRequestedSchema → ok. The conformance matrix maps each of these rows to those tests.
    • Nothing further to queue. Parent design(mcpx): elicitation broker hygiene — owner-only store, bounded retention, redacted events, review-first answering #1675 stays open for its own remaining tracking; this issue's four criteria are done, so it closes rather than spawning a fix task.
    • Labels: cleared stale status/needs-triage and queue/queued.
    • Links: mcpx: elicitation storage is readable by any local user and never pruned; elicitation UI and response validation rows #1954 · design(mcpx): elicitation broker hygiene — owner-only store, bounded retention, redacted events, review-first answering #1675 · mcpx: Phase 1 of #1675 — owner-only elicitation broker store (0700 dir, 0600 files, migration on open) #1676 · mcpx: Phase 2 of #1675 — broker retention bound + summary-only elicitation events #1677 · mcpx: Phase 3 of #1675 — review-first mcpx elicit surface + nix#255 truth-up #1678
12. dezren39

    removed

    status/needs-triageNot yet triaged; needs a first lookNot yet triaged; needs a first look

    queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

    on Nov 3, 2026
13. dezren39

    closed this as completedon Nov 3, 2026
14. dezren39

    added

    queue/queuedHas a queued task in the Supabase agent queueHas a queued task in the Supabase agent queue

    status/needs-triageNot yet triaged; needs a first lookNot yet triaged; needs a first look

    on Nov 3, 2026
15. dezren39 commented on Nov 3, 2026

    

    dezren39

    on Nov 3, 2026

    MemberAuthor

    More actions

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03