mcpx: Phase 3 of #2386 — completion register truth-up (retire both #213 gap rows; security row to partial on #1968/#1972)

Phase 3 of design #2386 (mcpx completion, finished). Design doc: files/designs/code-mcpx-completion-rate-limit-ranking.md in the keep-the-four-repos-healthy goal workspace. GATED on Phases 1–2 of #2386 landing — do not start until both are closed.

Scope

Make the conformance register truthful about completion, in pkgs/mcpx:

internal/conformance/coverage_utilities.go: retire the completion-server-should gap to a covered row naming the Phase 1 limiter tests and Phase 2 ranking tests; move completion-security to partial — rate limiting landed (Phase 1), input validation already existed, and the access-control / information-disclosure clause is recorded as waiting on principals mcpx: a principal per surface and a permission per operation, declared permissively #1968 / permissive-auth mcpx: the permissive auth interface authorizes everyone — real validation for the conformance rows that require refusal #1972 (do NOT mark it fully covered).
Correct the stale gap wording this pass's audit found: local matching was prefix-only (hasPrefixFold), not "matched by substring" — the register text is fixed as part of the retirement, and the correction is noted on the design issue.
Update the completion-server-should and completion-security notes in docs/spec/requirements.md (lines ~442/444) and the corresponding rows in docs/spec/conformance-matrix.md.
Post the evidence comment on design issue design(mcpx): completion, finished — one rate limit at the /v1 choke point, relevance-ranked local answers #2386 summarising what landed per phase. (mcpx: completion/complete over MCP ignores ref and never asks the upstream dezren39/darwin-nix#213, the gaps' origin, is CLOSED in nix — no cross-repo comment is owed; the evidence lives on design(mcpx): completion, finished — one rate limit at the /v1 choke point, relevance-ranked local answers #2386 and in the register.)

Acceptance

Both gap entries in coverage_utilities.go updated as scoped above; conformance tests pass in CI
requirements.md + conformance-matrix.md notes match the code's actual state (limiter settings named; security row partial with the mcpx: a principal per surface and a permission per operation, declared permissively #1968/mcpx: the permissive auth interface authorizes everyone — real validation for the conformance rows that require refusal #1972 reason)
Evidence comment posted on design(mcpx): completion, finished — one rate limit at the /v1 choke point, relevance-ranked local answers #2386; this issue's closure leaves design(mcpx): completion, finished — one rate limit at the /v1 choke point, relevance-ranked local answers #2386 ready for its own truth-up

Out of scope: implementing any access-control behaviour; touching any other gap row.

CODE-1216

🤖 Agent note · filed by design architect

Agent: design architect (repo-design-architect-code), pass 15, 2026-10-29
Task: Phase 3 of design design(mcpx): completion, finished — one rate limit at the /v1 choke point, relevance-ranked local answers #2386 — completion register truth-up
Expectation: GATED on Phases 1–2 (mcpx: Phase 1 of #2386 — completion rate limit at the /v1 choke point (limiter + completion.* settings, before the pool) #2387, mcpx: Phase 2 of #2386 — relevance-ranked local completion (exact → prefix → substring tiers; upstream order untouched) #2388) landing — triage records the gate and does not enqueue implementation until both are closed. Note the honesty constraint from the design: completion-security moves to partial with the mcpx: a principal per surface and a permission per operation, declared permissively #1968/mcpx: the permissive auth interface authorizes everyone — real validation for the conformance rows that require refusal #1972 access-control dependency recorded, never to fully covered. This phase's triage packet is enqueued in repo-health-code-pilot by the architect with status/blocked on the issue.

Intake review

Related: #2386 (design), #2387 (Phase 1), #2388 (Phase 2), #1968 / #1972 (the principals/permissive-auth work the security row waits on)

Notes: Phase 3 of the #2386 mcpx completion design; explicitly GATED on Phases 1–2 (#2387/#2388) closing first, and already labelled status/blocked for that gate. The body carries a full ## Acceptance checklist, so this pass is labels-only. Register truth-up only — no behaviour change in scope.

Risks: Marking completion-security fully covered would be a false claim: the access-control clause stays partial on #1968/#1972 by design; the retirement wording must keep that visible.

Suggested approach: Wait for #2387 and #2388 to close, then update the two register rows + requirements.md + conformance-matrix.md in one pass and post the evidence comment on #2386.

🤖 Agent note · filed

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: repo-fleet-monitor run 2026-10-29T18:12Z (13:12 CDT)
Found via: monitor reconciliation
Task: Duty 2 intake enrichment — labels normalized and meta/enriched applied; acceptance criteria appended to the body only where no acceptance section existed (original body preserved verbatim above it). Still-live check this pass: no merged PR or fix commit explicitly resolving this issue was found in this pass's search.
Expectation: see the effort label; done = the acceptance criteria are met.
Links: this issue

agent-note:v1 — state: parked at=2026-11-02T02:57:03Z (OpenChamber scheduled lane)

Agent: repo-worker-code
Session / ID: OpenCode session ses_e5e65df34b9ffePSYAEU7SC3AX; queue task 5980
Finding: mcpx: Phase 3 of #2386 — completion register truth-up (retire both #213 gap rows; security row to partial on #1968/#1972) #2389 remains OPEN; PR docs(mcpx): truth up completion conformance register (#2389) #4087 remains OPEN and Drew-authored.
Disposition: parked for 30 minutes under the Drew-owned PR hard stop; no PR, branch, worktree, CI, or review changes.
Resume condition: PR docs(mcpx): truth up completion conformance register (#2389) #4087 closes, ownership changes, or explicit rerouting; revalidate before acting.
Link: docs(mcpx): truth up completion conformance register (#2389) #4087

Merge pull request #4087 from developing-today/queue/5980-2389-comple…

agent-note:v1
event: done
task: 5980
worker: repo-worker-code (lane A)
state: Completed via PR #4087, merged da39c0a. Register/docs truthed up; security row remains partial pending #1968/#1972.

Navigation Menu

Repository navigation

mcpx: Phase 3 of #2386 — completion register truth-up (retire both #213 gap rows; security row to partial on #1968/#1972) #2389

Scope

Acceptance

Intake review

91 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

mcpx: Phase 3 of #2386 — completion register truth-up (retire both #213 gap rows; security row to partial on #1968/#1972) #2389

Description

Scope

Acceptance

Activity

developing-today commented on Oct 29, 2026

dezren39 commented on Oct 29, 2026

dezren39 commented on Oct 29, 2026

Intake review

91 remaining items

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 2, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions