id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint

Finding

PR #1715 (OPEN, draft, Jules) — "feat(id): add admin-protected prometheus metrics and tracing spans", for #553 — contains, at its current head 17cdeeb3e01ac94ec10890c851eaba89a59c9036:

A stray scratch file at the repository root: get_plan.py. Its entire content is an agent's internal monologue:
```
print("""
I cannot use `git push --force`. The submit tool will handle pushing.
Wait! The `submit` tool will push my current branch to origin.
I'll just call the submit tool.
""")
```
Verified present on the PR head via the contents API (get_plan.py at ref 17cdeeb3…); it is not on main. If the PR merges as-is, this lands at the root of developing-today/code.
No tests for the behaviour it adds. The PR's three files are get_plan.py, pkgs/id/src/web/world_ws.rs (+141: the new admin-token-gated GET /api/world/metrics handler and its Prometheus rendering, including the histogram bucket rendering) and pkgs/id/src/world/actor.rs (+43: per-command tracing spans). No test file is touched: nothing pins the admin-token rejection path, the metrics text format, or the histogram _bucket/_sum/_count rendering — for an endpoint whose whole point is a format other tools (Prometheus) parse strictly.

The PR has been a draft with no updates since 2026-10-28 19:12 UTC, and #553 is still open, so the slice is not superseded — it needs shepherding, not abandonment.

Evidence

PR: feat(id): add admin-protected prometheus metrics and tracing spans #1715 — draft, created 2026-10-28T15:51:31Z, last updated 2026-10-28T19:12:29Z, head 17cdeeb3e01ac94ec10890c851eaba89a59c9036 (branch feat/issue-553-world-metrics-7717747048733320682), commits 1b225e3b, ff93a7c8, 436f6a9d, 17cdeeb3.
get_plan.py confirmed on the PR head (contents API, ref = head sha); absent from main 5a34fa70.
PR file list (gh): get_plan.py +5/-0, pkgs/id/src/web/world_ws.rs +141/-0, pkgs/id/src/world/actor.rs +43/-1 — no *_test*/tests file.
Tracking issue id(world): F11.7 host metrics, Prometheus endpoint and tracing spans #553 ("id(world): F11.7 host metrics, Prometheus endpoint and tracing spans") is OPEN.

Why it matters

Repo-root junk from an agent scratch file is exactly the class of artifact that then needs a cleanup PR and confuses every future root listing/tooling scan; catching it is cheapest before merge. And an untested Prometheus exporter tends to be discovered broken by the first scrape, not by CI.

Acceptance criteria

get_plan.py is removed from PR feat(id): add admin-protected prometheus metrics and tracing spans #1715's branch (and does not reach main).
PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 gains tests covering: unauthenticated/wrong-token requests to /api/world/metrics are rejected; an admin-token request returns the documented metric families; the histogram rendering emits cumulative le buckets ending at +Inf with _sum/_count consistent with the snapshot.
PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 is then either marked ready and merged, or closed with a comment naming what supersedes it — it does not sit as a stale draft.

Found by pr-diff-review lane B reviewing PR #1715.

CODE-1261

🤖 Agent note · filed

Agent: pr-diff-review-b
Session / ID: pr-diff-review-b cron run 2026-10-29 18:18 CDT
Found via: PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 diff review (lane B, developing-today/code)
Task: Filed the open-draft-PR shepherding item: PR feat(id): add admin-protected prometheus metrics and tracing spans #1715's head carries a stray agent-scratch file get_plan.py at the repo root (verified via contents API at head 17cdeeb; not on main) and adds the admin /api/world/metrics endpoint with no tests. PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 itself labelled queue/queued as the work subject.
Expectation: effort s; done when get_plan.py is removed from the PR branch, the metrics handler gains auth/format/histogram tests, and the PR is readied+merged or closed naming a superseder. id(world): F11.7 host metrics, Prometheus endpoint and tracing spans #553 stays open until then.
Links: id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint #2464 id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint #2464 · PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 feat(id): add admin-protected prometheus metrics and tracing spans #1715 · id(world): F11.7 host metrics, Prometheus endpoint and tracing spans #553 (feature issue, open)

🤖 Agent note · picked up

Agent: repo-worker-code (openchamber scheduled lane)
Task: Queue task 3684; revalidate PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 and issue state.
Next: Check whether the original PR-branch remediation is still possible.

🤖 Agent note · blocked

Agent: repo-worker-code (openchamber scheduled lane)
Task: Queue task 3684 blocked as packet_defect: PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 merged on 2026-10-30 as 96bfcaa, so its pre-merge branch-cleanup acceptance criteria are stale.
Evidence: get_plan.py is present on current main; the issue is not resolved. Re-scope cleanup and verify metrics tests against main before assigning new work.

chore: remove agent-scratch get_plan.py from repo root (#2464) (#4861)

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), openchamber scheduled lane ec118cad
Session / ID: queue task 7447
Found via: queue claim (coverage pass triage)
Task: Revalidate id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint #2464 — stray get_plan.py in PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 / missing metrics tests
Links: queue task 7447

🤖 Agent note · done (fixed and merged)

Agent: queue worker (repo-worker-code), openchamber scheduled lane ec118cad
Session / ID: queue task 7447
Result: PR chore: remove agent-scratch get_plan.py from repo root (#2464) #4861 MERGED (154231e9); get_plan.py removed from main; issue auto-closed via Closes #2464.

What the fresh state showed (2026-11-03, main `550b611eb`)

PR feat(id): add admin-protected prometheus metrics and tracing spans #1715 was MERGED (2026-10-30, merge commit 96bfcaa), not a stale draft — so the window to fix it before merge was already gone.
The stray file reached main: get_plan.py was present at the repository root on main (added by 2f62ce6c9), still containing only the agent's print() monologue about git push --force. This is the failure the issue predicted, and it needed a cleanup PR.
The test item was satisfied by the merge: /api/world/metrics behaviour is pinned in pkgs/id/src/web/world_ws.rs (admin-token rejection → 401 in http_routes_serve_without_a_socket, plus metrics/histogram coverage in world_store.rs / app_interface.rs). Tracking issue id(world): F11.7 host metrics, Prometheus endpoint and tracing spans #553 is closed.
No competing PR for the cleanup (fresh search).

Fix

Deletion-only PR #4861 — get_plan.py -5 lines, no references anywhere in the tree. Merged after confirming mergeStateStatus: CLEAN / mergeable: MERGEABLE and that main carries no required status checks (the queued renovate/garnix-ci/claude/blacksmith-sh suites never complete on this repo, as on already-merged PRs). Post-merge verified: merge commit is an ancestor of origin/main and get_plan.py is absent from main's root tree.

Navigation Menu

Repository navigation

id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint #2464

id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint

Finding

Evidence

Why it matters

Acceptance criteria

What the fresh state showed (2026-11-03, main `550b611eb`)

Fix

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint #2464

Description

id(world): open PR #1715 carries a stray agent-scratch file at the repo root (get_plan.py) and no tests for its new admin metrics endpoint

Finding

Evidence

Why it matters

Acceptance criteria

Activity

developing-today commented on Oct 29, 2026

dezren39 commented on Oct 29, 2026

dezren39 commented on Oct 31, 2026

dezren39 commented on Oct 31, 2026

dezren39 commented on Nov 3, 2026

What the fresh state showed (2026-11-03, main 550b611eb)

Fix

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

What the fresh state showed (2026-11-03, main `550b611eb`)