meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift

Problem

parseBillingBanner (pm-stack/meta-exporter/meta-quota-export.mjs:99-111) converts the billing banner's remaining_minor_units to USD with only a type/finiteness/sign check:

if (typeof minor !== "number" || !Number.isFinite(minor) || minor < 0) throw …
return minor / 100;

Minor units are integer cents by definition — a fractional value is shape drift, and this exporter's parsers are documented to fail closed on shape drift ("Throws on any shape drift — fail-closed, never partial zeros", parseSubscriptionQuota header). But a fractional or absurd value passes here and is exported in a status: "ok" document as freeCreditsUsd:

Verified against the real module (main 7d1b081, node probe):

remaining_minor_units: 1050.5 → freeCreditsUsd = 10.505 (a half-cent that cannot exist)
remaining_minor_units: 0.1 → 0.001
remaining_minor_units: 1e15 → 10000000000000 ($10 trillion of "free credits")
Controls behave: integer 14857 → 148.57; negative and string values throw as intended.

Why it matters

freeCreditsUsd lands in the export document the aggregator's quota plane reads as the Meta card's measured free-credit balance. A drifted banner payload (API change, partial response, wrong field) currently produces a precise-looking but impossible balance instead of the exporter's unparseable (exit 6) failure document — the failure mode every sibling parser in this file is built to produce.

Related, distinct: #2460 (subscription-quota timestamps) and #2461 (parsePaygBalance truncation) are different functions in this file; neither covers the banner parser. #1301 is the null-resets_at diagnosis in parseSubscriptionQuota.

Acceptance criteria

parseBillingBanner throws unparseable (exit 6) when remaining_minor_units is not an integer (Number.isInteger), and when it exceeds a stated plausible bound if triage chooses to add one.
Regression tests in meta-quota-export.test.mjs: fractional (1050.5, 0.1) throws; the existing integer/currency/missing cases still behave as today.

🤖 Agent note · state: filed

Agent: new-issue-creator job (new-issue-creator-code-b)
Session / ID: cron new-issue-creator-code-b run 2026-10-30T02:07Z
Found via: filed this run
Task: Triage parseBillingBanner's missing integer check on remaining_minor_units: fractional minor units export as fractional-cent free credits in a status:ok document instead of the exporter's unparseable failure.
Expectation: effort xs — pin the integer (and any bound) check, add regression tests, then route a small_fix packet.
Links: probe hidden_files/probe-2026-10-29-laneB-billingbanner/probe.mjs; issue body file hidden_files/issue-code-billingbanner-minor-body.md

🤖 Agent note · picked up

Agent: repo-worker-code (OpenChamber scheduled lane)
Session / ID: OpenCode session ses_e5e6495a63cffe4w3nYHDsSs84; queue task 5360
Found via: atomic claim from repo-health-code-pilot
Task: Resume meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510 billing-banner integer-minor-unit fix; prior checkpoint records canonical PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 and branch .
Fresh state: meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510 is OPEN and assigned to Drewry Pope (dezren39). PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 is OPEN and Drew-authored at 6b37745. No checks, reviews, diff, branch, or worktree inspected.
Next: Park on the Drew-ownership hard stop; resume only after explicit handoff/release or PR disposition, then revalidate.

🤖 Agent note · parked

Agent: repo-worker-code (OpenChamber scheduled lane)
Session / ID: OpenCode session ses_e5e6495a63cffe4w3nYHDsSs84; queue task 5360
Verified: meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510 remains OPEN and assigned to Drewry Pope (dezren39); PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 remains OPEN, Drew-authored, at 6b37745.
Disposition: Parked for 30 minutes due to the Drew-owned issue/PR hard stop. No checks, reviews, diff, branch, or worktree inspected; no source changes.
Resume: After explicit Drew handoff/release or PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 disposition, then revalidate issue and PR fresh. Queue not-before: 2026-11-02T09:15:03Z.
Links: meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510 · fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane D shift
Session / ID: task 5360
Found via: queue claim
Task: Resume task 5360 on canonical PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 for issue meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510: Codex is clean on head 6b37745; the pm-aggregator check fails on 2 aggregator render tests disjoint from this PR's meta-exporter-only diff. Verifying the PR's own targeted tests, then merging if sound.
Expectation: effort xs; done = PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 merged, issue meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510 closed, task 5360 completed fixed_merged — or parked naming the blocker.
Links: PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 (branch queue/5360-2510-billing-banner-integer — the canonical queue PR for task 5360; its author login is the shared fleet account)

fix(meta-exporter): reject fractional billing-banner minor units (#2510…

🤖 Agent note · done

Agent: queue worker (repo-worker-code), lane D shift
Session / ID: task 5360
Found via: queue claim
Task: Done — task 5360 completed fixed_merged. PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188 (the canonical queue PR for task 5360) merged as 0f98063; issue meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510 is closed. Verification: the PR's own targeted tests pass on the laptop at the merged head (node --test meta-quota-export.test.mjs, 21/21) and Codex review on that head is clean with no inline findings. The pm-aggregator CI check on the PR failed on two aggregator render tests, but the PR diff touches only pm-stack/meta-exporter files, and both failing tests pass on current main (slice3.test.ts 26/26, usage.test.ts 39/39) — stale-base artifacts, not this change.
Expectation: Complete; no follow-up.
Links: PR fix(meta-exporter): reject fractional billing-banner minor units (#2510) #4188

Navigation Menu

Repository navigation

meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510

Problem

Why it matters

Acceptance criteria

40 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

meta-exporter: parseBillingBanner accepts fractional minor units — 1050.5 exports as $10.505 of free credits instead of failing closed on shape drift #2510

Description

Problem

Why it matters

Acceptance criteria

Activity

dezren39 commented on Oct 30, 2026

40 remaining items

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 2, 2026

dezren39 commented on Nov 2, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions