aggregator: pages manifest broken on main — PageDef.group missing (3 typecheck errors, 7 test failures)

Found 2026-10-30 during the merge-everything pass, verified twice against a pristine checkout of main (git archive of origin/main), so this is pre-existing breakage on main, not fallout from any PR.

In pm-stack/aggregator:

bunx tsc --noEmit (or the repo's typecheck) reports 3 errors
the test suite reports 7 failures
all of them sit in the pages-manifest / overview area

Apparent root cause: PageDef in pm-stack/aggregator/src/pages.ts is missing the group field that the manifest/overview code and its tests expect. Either the field was dropped from the type without updating its consumers, or the consumers were written against a field that never landed.

Acceptance: typecheck clean and the aggregator suite green on main; if group is intentionally gone, remove its uses and the tests that assert it instead.

Acceptance criteria

bunx tsc --noEmit (the repo typecheck) is clean in pm-stack/aggregator on main
The aggregator test suite is green on main (the 7 pages-manifest/overview failures resolved)
Either PageDef.group is restored and consumed consistently, or every use of group and the tests asserting it are removed — no half-state
The fix is verified against a pristine checkout of main, matching how the breakage was found

Intake review

Still live: the filer verified the breakage twice against a pristine git archive of origin/main on 2026-10-30, and no merged PR since then touches PageDef — treat as live main breakage until a fresh typecheck on current main says otherwise.

Related: code #2590 and #2582 are defects in the same aggregator (pm-stack) but different mechanisms (attention classification, quota pctWindows) — not duplicates. Note the pages manifest is also what the fleet feed renders from, so this breakage can hide fleet state.

Notes / risks: 3 typecheck errors + 7 test failures all in the pages-manifest/overview area, centred on PageDef.group in pm-stack/aggregator/src/pages.ts. Two coherent resolutions exist (restore the field, or remove its uses + tests); the wrong pick loses either a real grouping feature or real test coverage, so the triage should first check git history for when group disappeared and whether the removal was deliberate.

Suggested approach: git log -p on pages.ts around the group field, decide restore-vs-remove from that evidence, then run typecheck + the aggregator suite on a pristine checkout.

Fixed in #2604

#2604

Direction chosen: restore group end-to-end. PageDef.group/PAGE_GROUPS/groupedPages() are the nav-section model from #1135 and the tests plus the nav consumers are right to require it. The breakage was a bad merge of #1134 into #1135 (6f3fda03): the pages.ts conflict was resolved by taking the #1135 side of the board entry and keeping the new #1134 overview entry verbatim, leaving two pages on / and an overview entry with no group (so groupedPages() dropped it from the nav).

What changed

src/pages.ts: overview keeps / and gains group: "overview"; board is back on /board — which is what server.ts already serves.
test/overview.test.ts: fixtures refreshed for fields added after impl(aggregator): make / the stack front door - overview of all projects, attention, health, quotas (board moves to /board) #1134 (HealthView.version/itemsCoverage, AttentionView.watchdog) — 2 of the 3 typecheck errors.
test/actions.test.ts: the applied-snooze fixture measured until from its fixed past NOW, so it had silently expired (render-time suppression uses the wall clock). The snooze is now live at render.
README.md: route table updated (/ = Overview, /board = board).

Evidence, verified in a fresh worktree of origin/main (f9268e24)

Before:

$ bunx tsc --noEmit
src/pages.ts(44,3): error TS2741: Property 'group' is missing ...
test/overview.test.ts(11,7): error TS2739: ... 'HealthView' ... version, itemsCoverage
test/overview.test.ts(29,3): error TS2741: ... 'watchdog' is missing ... 'AttentionView'

$ bun test
 498 pass
 7 fail

After:

$ bunx tsc --noEmit
(clean, no output)

$ bun test
 505 pass
 0 fail
 2614 expect() calls
Ran 505 tests across 41 files.

Codex review on the PR completed with no findings; the PR is mergeable with no blockers (one optional check still queued).

aggregator: persist before acknowledging repeat github results (#1686)

fix(aggregator): refuse empty/conflicting github-result reports; post…

🤖 Agent note · full-suite failure census at main (from queue task 4918 verification)

Agent: repo-worker-code (Lane F), 2026-10-31
While verifying PR feat(aggregator): /sessions recency window, search/filter, pagination (#1209) #3303 (sessions registry view), the full aggregator suite (bun test, 754 tests / 52 files) showed 747 pass / 7 fail — and the identical 7 failures reproduce on pre-merge main 72e347609, so PR feat(aggregator): /sessions recency window, search/filter, pagination (#1209) #3303 introduced none of them. They are all in the PAGES-manifest breakage class this issue tracks:
1. nav.test.ts — the manifest groups every page (fix(aggregator): navigation coherence - 10-item nav overflows on mobile, sub-pages undiscoverable #1135): every page names one of PAGE_GROUPS, and groups have no page-less id
2. nav.test.ts — the manifest groups every page (fix(aggregator): navigation coherence - 10-item nav overflows on mobile, sub-pages undiscoverable #1135): groupedPages covers each page exactly once
3. aa.test.ts — aa-explorer manifest + render: PAGES carries the aa-explorer page with unique routes
4. overview.test.ts — overview front door (impl(aggregator): make / the stack front door - overview of all projects, attention, health, quotas (board moves to /board) #1134): PAGES registers overview at / and board at /board, routes unique
5. overview.test.ts — overview front door (impl(aggregator): make / the stack front door - overview of all projects, attention, health, quotas (board moves to /board) #1134): rendered overview carries every section and links the board at /board
6. actions.test.ts — attention action controls (design+impl(aggregator): triage actions on /attention - acknowledge, snooze, escalate, answer - orchestrator-mediated #1152/impl(aggregator): session actions from /sessions and /attention - poke, answer, stop - keeper/orchestrator-mediated #1156): pending + applied states render as badges; applied snooze lands in the Snoozed strip
7. slice3.test.ts — pages manifest + slice-3 renders: manifest registers dns + sessions; routes unique
Post-merge main 0ea0a0fa6 shows the same 747/7 totals. Fixing the PAGES/PAGE_GROUPS manifest divergence should clear all seven.

🤖 Agent note · handed off

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: task 7342
Found via: monitor reconciliation
Task: claim-evaporated repair — the queue claim on task 7342 ended without complete/park/block, its lease expired, and the task returned to queued unclaimed while this issue still carried claimed labels. Labels reset to the truth: queue/queued + status/needs-triage. Checkpoint stage at evaporation: handed_off.
Expectation: the next lane to claim task 7342 posts a fresh pickup note.

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-i
Session / ID: task 7342
Found via: queue claim
Task: triage of issue aggregator: pages manifest broken on main — PageDef.group missing (3 typecheck errors, 7 test failures) #2580 handed off to the opencode execution lane; the laptop claimant launches the bound opencode session
Expectation: claimant session drives task 7342 to its terminal state
Links: issue aggregator: pages manifest broken on main — PageDef.group missing (3 typecheck errors, 7 test failures) #2580

agent-note:v1
task: 7342
lane: code-q (repo-queue-worker-shift-q)
state: handed_off (execution lane: opencode)
Re-verified fresh 2026-11-04T17:32Z: issue #2580 OPEN, no hard-stop labels, claimed labels already set. Handing task 7342 (triage, attempts 14/24) to the opencode claimant for fresh triage at current main.

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-z
Session / ID: task 7342
Found via: queue claim
Task: Triage issue aggregator: pages manifest broken on main — PageDef.group missing (3 typecheck errors, 7 test failures) #2580 at current main; handed off to opencode execution lane — claimant launches the bound opencode session
Expectation: effort s; done when issue aggregator: pages manifest broken on main — PageDef.group missing (3 typecheck errors, 7 test failures) #2580 is triaged at current main with blockers named, fix path enqueued, fix landed, or issue closed with evidence. Note: attempts 23/24 — at cap risk if lease expires unfinished.
Links: task 7342

🤖 Agent note · handed off

Agent: fleet monitor
Session / ID: task 7342 (repo-fleet-monitor run 2026-11-05T15:39:47Z)
Found via: monitor reconciliation (Duty 1 claim/label divergence repair)
Task: Claim evaporated: task 7342 is queued and unclaimed in repo-health-code-pilot, but this issue still carried claimed labels. Labels reset to the truth (queue/queued + status/needs-triage). Checkpoint stage at evaporation: handed_off.
Expectation: The next lane claim picks task 7342 up from the queued state and posts a fresh pickup note.

Navigation Menu

Repository navigation

aggregator: pages manifest broken on main — PageDef.group missing (3 typecheck errors, 7 test failures) #2580

Acceptance criteria

Intake review

Fixed in #2604

12 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

aggregator: pages manifest broken on main — PageDef.group missing (3 typecheck errors, 7 test failures) #2580

Description

Acceptance criteria

Activity

dezren39 commented on Oct 30, 2026

Intake review

dezren39 commented on Oct 30, 2026

Fixed in #2604

dezren39 commented on Nov 1, 2026

12 remaining items

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 5, 2026

dezren39 commented on Nov 5, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions