Skip to content

ci: no pull_request workflow covers pm-stack/** — projector/aggregator changes merge with zero PR CI #2936

Closed

Description

@dezren39

Gap

No GitHub Actions workflow runs on pull_request for pm-stack/**. Verified 2026-10-31 on PR #2930 (queue task 1822, projector change): the only check runs on the head commit were CodeRabbit (neutral) and the two jules-daily-* push workflows that fail on every push including main. .github/workflows/ has path-scoped PR CI for pkgs/id (id-check) and pkgs/mcpx (mcpx, mcpx-docs), but nothing matches pm-stack/** — pm-scheduled.yml is the scheduled-agents runner, not test CI.

Effect: pm-stack changes (projector, aggregator) merge with zero PR CI; verification is whatever the author ran locally. PR #2930 was merged on laptop verification (bun test in pm-stack/projector, 43/43) under the standing merge criteria, with this gap noted.

Suggested fix

Add a small workflow (or extend an existing one) triggered on pull_request with paths: ["pm-stack/**"] that installs bun deps and runs the pm-stack test suites (at minimum pm-stack/projector: bun test). Keep it path-scoped so unrelated PRs don't pay for it.

Found by: queue worker Lane A shift, 2026-10-31, while resuming task 1822.

Acceptance criteria

  • A pull_request workflow triggers on changes under pm-stack/** and is path-scoped so unrelated PRs do not run it.
  • The workflow installs bun dependencies and runs the pm-stack test suites (at minimum pm-stack/projector: bun test) and reports as a PR check.
  • Verified on a test PR touching pm-stack/** (check runs) and one that does not (check does not run).

Activity

  1. added
    app/pm-stackpm-stack (Pad/Grist) in developing-today/code
    kind/ciCI/CD pipelines, workflows, and build automation
    source/queue-workerFiled or worked by the queue/worker pilot
    priority/normalOrdinary priority (the default)
    effort/sSmall: expected under 2 hours of work
    area/ciCI/CD pipelines, workflows, and build automation (area)
    on Oct 31, 2026
  2. dezren39 commented on Oct 31, 2026

    @dezren39
    MemberAuthor

    Intake review

    Related: PR #2930 (merged on laptop verification with this gap noted); existing path-scoped PR CI for pkgs/id and pkgs/mcpx is the pattern to copy.

    Notes: verified live this run — no open PR or issue covers a pm-stack PR workflow (searched both). The gap is real: projector/aggregator changes currently merge with zero PR CI.

    Risks: low. Keep the workflow path-scoped and bun-cache-friendly so unrelated PRs don't pay for it; a failing-suite baseline on main would make the new check red for everyone — confirm the suites pass on main when wiring it up.

    Suggested approach: clone the pkgs/id path-scoped workflow shape, scope paths: ["pm-stack/**"], run bun install + bun test in pm-stack/projector (and the aggregator suite if it has one).

    🤖 Agent note · filed

  3. added
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Oct 31, 2026
  4. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 3, 2026
  5. developing-today commented on Nov 3, 2026

    @developing-today
    Contributor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  6. 14 remaining items

  7. added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    and removed
    work/assignedQueue worker lifecycle state
    task/triageQueue packet kind: verify, reproduce, and route this item
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 4, 2026
  8. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · picked up

    • Agent: queue worker (repo-worker-code), lane code-q
    • Session / ID: task 9274
    • Found via: queue claim
    • Task: Fix issue ci: no pull_request workflow covers pm-stack/** — projector/aggregator changes merge with zero PR CI #2936 — add projector test coverage to the pm-stack PR workflow. Verified fresh: .github/workflows/pm-aggregator-tests.yml (pull_request, pm-stack/** paths) runs only aggregator jobs; .github/workflows/pm-stack-tests.yml runs aggregator + projector but is push-to-main only. Adding a projector job to the PR workflow mirroring the main workflow's projector steps; aggregator coverage, path scoping, and the non-required-check policy are unchanged.
    • Expectation: effort s; done = PR opened from branch queue/9274-2936-projector-pr-ci with the projector job in the PR workflow.
    • Links: branch queue/9274-2936-projector-pr-ci (laptop worktree ~/git/fleet/9274)
  9. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    state: done (triage task completed)
    queue: repo-health-code-pilot
    task: 7996 completed as triaged; follow-up task 9274 is queued (worker repo-worker-code; lane ec118cad-0fd3-4652-91c4-27432f2f2efd)
    at: 2026-11-04T06:24:12.921Z
    result: the aggregator PR-CI path exists; projector PR changes still lack projector tests. The narrowed fix was queued as task 9274. Issue #2936 remains OPEN; queue/queued, status/needs-triage, and task/small-fix now reflect the follow-up. No code changes or local tests this triage. Sandbox bookkeeping deferred to fleet reconciliation.

  10. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · done

  11. added a commit that references this issue on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/pm-stackpm-stack (Pad/Grist) in developing-today/codearea/ciCI/CD pipelines, workflows, and build automation (area)effort/sSmall: expected under 2 hours of workkind/ciCI/CD pipelines, workflows, and build automationmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)source/queue-workerFiled or worked by the queue/worker pilottask/small-fixQueue packet kind: bounded fix with reproduction and targeted tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions