Repository navigation
fix(ci): auto-format nightly sweep aborts when the last changed path was deleted (PR #2148) #3117
Description
Finding
PR #2148's auto-format workflow nightly sweep builds its file list with a while loop whose body is [[ -n "$f" && -f "$f" ]] && printf …. If the lexicographically last path in the day's history has since been deleted, the condition is false on the final iteration, the loop/pipeline returns 1, and set -euo pipefail aborts the step — no surviving files are formatted that night. Codex flagged this P2 on the PR (comment 4409644277); it merged unchanged and is still on main.
Evidence
- PR: ci: name the PR tier basic, state the merge requirement, replace Auto Assign with the repo sweeper (#1781) #2148 (merged bc1d23f..4dc6cb0)
- Current main:
.github/workflows/auto-format.yml:59—[[ -n "$f" && -f "$f" ]] && printf '%s\n' "$f"inside the schedule branch, underset -euo pipefail.
Why it matters
The nightly sweep is the backstop that keeps formatting drift from accumulating; a deleted file late in the alphabet silently disables it for that night with a red run nobody will connect to a deletion.
Acceptance criteria
- The filter uses an
if(or otherwise always succeeds when excluding a path), so a deleted last path cannot fail the step. - Surviving changed files are still formatted on the same run.
Activity
dezren39 commentedon Oct 31, 2026
agent-note:v1 — Agent: pr-diff-review-b; state: filed. Filed from PR diff review lane B (late-arriving Codex P2 evidence on the source PR, verified against current main ada2d88; see the issue body for PR, comment, and file:line evidence). Enqueued as a repo-task/v1 triage packet on repo-health-code-pilot.
dezren39 commentedon Oct 31, 2026
agent-note:v1 — Agent: repo-worker-code; state: claimed. Claimed task 4537 on queue repo-health-code-pilot. Investigating auto-format.yml nightly filter logic.
1 remaining item
dezren39 commentedon Oct 31, 2026
agent-note:v1 — Agent: repo-worker-code; state: handed off. Triage task 4537 completed; queued small-fix follow-up task 4569 for the verified nightly filter failure and a regression test.
dezren39 commentedon Oct 31, 2026
agent-note:v1 — Agent: repo-worker-code; state: claimed. Picked up small_fix task 4569 from repo-health-code-pilot queue (OpenChamber scheduled lane). Implementing auto-format nightly filter fix and regression test.
dezren39 commentedon Oct 31, 2026
agent-note:v1 — Agent: repo-worker-code; state: done. Task 4569 completed with fix and targeted regression test in PR #3166. Targeted test passed; CI pending. Sandbox bookkeeping deferred to fleet reconciliation.