Repository navigation
id(web): search-panel test expects aria-label 'Replace all' but implementation renders 'Replace all matches' — full web suite red on main #3243
Description
Problem
pkgs/id/web full unit suite on current main has one failing test, unrelated to any open PR touching it:
src/search-panel.test.ts:269— "panel has role=search and aria-label for accessibility" expects the#replace-allbutton'saria-labelto be"Replace all".src/search-panel.ts:136(main) renders that button witharia-label="Replace all matches"(andtitle="Replace all").
Test and implementation disagree; one of them is wrong. The implementation's longer label looks deliberate (it matches the button's action), so the likely fix is updating the test expectation — but whoever picks this up should confirm which string the accessibility pass intended before changing either side.
Evidence
Found 2026-10-31 by repo-queue-worker lane E while verifying PR #3197 (task 1364, image-node-view — disjoint files). Full suite on the laptop at PR head 20496ae44: Test Files 1 failed | 21 passed (22); Tests 1 failed | 492 passed | 9 skipped. The only failure is this test. Verified pre-existing on main via gh api contents of both files at ref=main (implementation aria-label="Replace all matches" at search-panel.ts:136; expectation "Replace all" at search-panel.test.ts:269). PR #3197 touches only image-node-view.ts / image-node-view.test.ts.
Acceptance
- Decide the intended aria-label for the replace-all button and make implementation + test agree
-
cd pkgs/id/web && bunx vitest runis fully green
Filed by repo-queue-worker lane E, 2026-10-31.
Activity
dezren39 commentedon Nov 1, 2026
Intake review
Related: Surfaced while verifying PR #3197 (disjoint files); sibling main-red gate issue #3249 (tsc red on main, same app, filed the same day).
Notes: Verified at filing against main via
gh apifile contents on both sides: implementation rendersaria-label="Replace all matches"(search-panel.ts:136), the test expects"Replace all"(search-panel.test.ts:269); full suite 492 passed / this 1 failed. The body already carries acceptance criteria, so no body change was made. No merged PR fixes this (checked at intake).Risks: A red full suite on main trains shepherds to ignore failures — real regressions in id(web) can slip in behind this known one.
Suggested approach: Confirm which string the accessibility pass intended (the implementation's longer label matches the button's action and its
title="Replace all"), then align the other side; do not change both blindly.— fleet monitor intake, 2026-10-31 fleet-monitor run (19:12 CDT)
dezren39 commentedon Nov 3, 2026
agent-note:v1
task: 6651
lane: code-l
transition: packet_defect finding (queue block did not apply — claim lost)
state: Task 6651 (verify-and-close follow-up for the id-serve idle WebSocket leak) cannot be executed as written; its central premise fails fresh verification:
Procedural note: lane code-l claimed task 6651 on 2026-11-03, but every subsequent queue verb (heartbeat/checkpoint/block) returned "task 6651 is not claimed by repo-worker-code"; the claim lease has expired and the task returns to the queue, so no queue-side block was recorded. The packet_defect finding stands on the evidence above: whoever re-claims task 6651 should block it as packet_defect rather than execute it. Issue id(web): search-panel test expects aria-label 'Replace all' but implementation renders 'Replace all matches' — full web suite red on main #3243 stays OPEN; whether the idle-wait worker leak persists in the refactored world_session code needs a fresh triage against current main.
8 remaining items
dezren39 commentedon Nov 3, 2026
🤖 Agent note · done
dezren39 commentedon Nov 3, 2026
🤖 Agent note · picked up
dezren39 commentedon Nov 3, 2026
🤖 Agent note · done
bunx vitest run src/search-panel.test.ts— 25/25 pass. No Codex review exists on PR 🎨 Palette: align replace-all aria-label test with accessible label #4144 (no findings to disposition). The PR's nix-flake-check failures are the repo-wide red main state, not this one-line test change.