Skip to content

mcpx: internal/conformance test backends do not compile against current mcpserver.Backend Complete signature #3519

Closed

Description

@dezren39

Finding (queue worker lane C, task 4217 / PR #3516 CI, 2026-11-01)

pkgs/mcpx/internal/conformance test code does not compile on current main: the test backends' Complete method returns []string, but mcpserver.Backend now requires Complete(context.Context, json.RawMessage) (mcpserver.Completion, error).

CI evidence on PR #3516 (diff touches only internal/logstore):

  • basic: lint (go vet): internal/conformance/features_test.go:308:24: cannot use failingReads{…} as mcpserver.Backend: failingReads does not implement mcpserver.Backend (wrong type for method Complete) — have Complete(context.Context, "encoding/json".RawMessage) ([]string, error), want … (mcpserver.Completion, error)
  • stress: PR changed tests: darwin test-compile gate FAILED for internal/conformance with the same error at features_test.go:308/389, harness_test.go:358, transport_test.go:510, utilities_test.go:177.

Distinct from #2716 (runtime TestAuthSplit/TestMatrix failures in the same package): this is a compile-time break, so the package's tests cannot run at all, and every unrelated mcpx PR's lint/stress jobs go red until it is fixed.

Acceptance

  • go vet ./internal/conformance/ and the darwin test-compile gate pass on main.
  • The test backends (failingReads, backend, relayBackend) implement the current Complete signature.
  • Name the merge that changed the Backend.Complete signature (bisect or blame) in the closing comment.

Activity

  1. added
    priority/normalOrdinary priority (the default)
    app/mcpxPackage/app: mcpx (pkgs/ or apps/ in this repo)
    on Nov 1, 2026
  2. developing-today commented on Nov 1, 2026

    @developing-today
    Contributor
  3. added
    queue/queuedHas a queued task in the Supabase agent queue
    source/creatorFiled by the new-issue-creator job
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 3, 2026
  4. developing-today commented on Nov 3, 2026

    @developing-today
    Contributor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  5. added
    work/assignedQueue worker lifecycle state
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    status/parkedDeliberately paused with a recorded resume condition
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 3, 2026
  6. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    Agent note — parked (OpenChamber scheduled lane)

  7. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    state: picked_up (triage)
    Agent: queue worker repo-worker-code
    Lane: 262eb403-3347-4a7c-ba6b-e7bc263ca853
    Queue task: 8268
    The issue is still open and no open PR directly matching #3519 or another claimed queue task for #3519 was found. Earlier queue progress mentioned an OpenCode handoff; the timed handoff is now due and this lane is checking current main before deciding whether to implement or close with evidence.
    Next: verify the conformance backend signatures and identify the main-branch change that introduced the required Complete signature.

  8. added
    queue/claimedQueue worker lifecycle state
    and removed
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    status/parkedDeliberately paused with a recorded resume condition
    on Nov 3, 2026
  9. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    state: closed (already handled)
    Queue task: 8268 (triage) — repo-worker-code, lane 262eb403-3347-4a7c-ba6b-e7bc263ca853
    Triage at current main: the reported compile break is resolved. On the checked tree, Complete in mcpserver.Backend returns mcpserver.Completion, and the old ([]string, error) test stub no longer exists. go test ./internal/conformance -run '^$' and go vet ./internal/conformance/ passed; bash scripts/darwin-compile-check.sh passed (darwin/arm64, 0 exceptions). The tested base was 3943ac6; current main advanced to 7657b97 with no pkgs/mcpx/ changes in between.
    Signature history: PR #3505 (merge 17b3874) changed Backend.Complete to return Completion; PR #3699 (merge 687ac07) updated the conformance backend stub. Both are merged. No follow-up task is needed.
    Closing as already handled at current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/mcpxPackage/app: mcpx (pkgs/ or apps/ in this repo)priority/normalOrdinary priority (the default)source/creatorFiled by the new-issue-creator jobtask/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions