Skip to content

fix(aggregator): wrap /attention card header row and contain wide /item element at 390px (follow-up to #1180) #3949

Open

Description

@dezren39

Finding

From the #1180 390x844 audit (task 4896, PR #3948): page-level horizontal scroll is zero on every page, but two element-level overshoots remain inside clipped cards, so content can be visually truncated at 390px:

  • /attention: a card header row (title link + badge + <time> + refs span, e.g. the degraded-mode banner card) extends to right=444px (refs span w=166) inside its card instead of wrapping.
  • /item/<id>: one 166px-wide div extends to right=555px inside a clipped container.

Acceptance

  • Identify both elements, make the /attention card header row wrap at 390px, and contain the /item element within its card (scroll wrapper or wrap), verified by the same CDP measurement used in task 4896: no element with right > 391px outside a deliberate scroll wrapper on either page at 390x844.

Acceptance criteria

Activity

  1. added
    kind/bugSomething isn't working (prefixed form of the classic bug label)
    priority/normalOrdinary priority (the default)
    app/pm-stackpm-stack (Pad/Grist) in developing-today/code
    source/queue-workerFiled or worked by the queue/worker pilot
    effort/sSmall: expected under 2 hours of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 1, 2026
  2. dezren39 commented on Nov 1, 2026

    @dezren39
    MemberAuthor

    Intake review

    Fleet monitor intake enrichment (protocol §5), 2026-11-01.

    Still live: checked merged PRs and recent work in this area — no merged PR explicitly resolves this issue, and the filing evidence is from current main today. Not closing.

    Related: Related: follow-up to issue #1180 (390px audit, task 4896, PR #3948 — merged; its binding task 4896 is parked/done and this issue carries its acceptance measurement verbatim). No open PR implements this follow-up yet.

    Risks / notes: Element-level overshoot inside clipped cards only — page-level scroll is already zero, so a global CSS change is the wrong tool; keep the change scoped to the two named elements.

    Suggested approach: Reproduce with the task 4896 CDP measurement at 390x844, identify the two elements, then wrap the /attention header row (flex-wrap) and contain the /item element; re-run the same measurement as the acceptance check.

    Labels normalized (kind/source/status/priority/effort/app as applicable) and meta/enriched applied; an ## Acceptance criteria section was appended to the issue body (original body preserved verbatim above it).

  3. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 3, 2026
  4. developing-today commented on Nov 3, 2026

    @developing-today
    Contributor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  5. 41 remaining items

  6. added
    status/parkedDeliberately paused with a recorded resume condition
    and removed
    queue/claimedQueue worker lifecycle state
    on Nov 4, 2026
  7. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    event: picked_up -> parked
    task: 8714 (small_fix, repo-health-code-pilot; worker repo-worker-code; lane 7b47536b-c162-444c-be8a-3a9538cc4cb5, execution lane opencode)
    by: openchamber-scheduled-lane
    at: 2026-11-04T06:36:39.580Z

    Fresh state before park: issue #3949 OPEN; PR #5227 OPEN at d6bf168; required PR check rollup SUCCESS 1/1. The PR is 109 commits behind main, but main has no changes to the two touched files since the PR base. Full aggregator tests pass (1463/1463 after frozen install); targeted tests pass (47/47). The aggregator PR CI workflows are push-main/workflow_dispatch only, so no aggregator-specific CI check ran on this PR. Typecheck errors are in untouched files; the clean-main check at 6ed2ae7 reproduced the src/item-history.ts GhKind error.

    CDP at 390x844 on fixture-rendered renderAttention output and renderItem output with a deliberately long session metadata row: 0 offending elements beyond right=391 outside scroll wrappers on both; document/body/client width 390; horizontal scroll attempt left scrollX=0. This was renderer-output HTML opened as file URLs, not the live endpoint; port 4870 serves primary main without the PR selector, and I did not start a second dev server.

    labels: work/assigned retained; queue/parked and status/parked set; queue/claimed and status/in-progress removed; status/triaged preserved.
    resume: after 2026-11-04T06:55:55Z, freshly revalidate issue/PR/head/checks and compare current main; verify actual routes if safely possible without replacing the primary server, otherwise document the renderer-output measurement limitation on PR #5227 and merge through the queue only if the evidence and current state still satisfy acceptance. Do not reimplement the existing PR.

  8. added
    queue/claimedQueue worker lifecycle state
    and removed
    status/parkedDeliberately paused with a recorded resume condition
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Nov 4, 2026
  9. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

  10. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    event: picked_up (resume)
    task: 8714 (small_fix, repo-health-code-pilot; worker repo-worker-code; lane 02cafe76-eafd-4d0b-aaa6-2b7a737d68dc)
    by: openchamber-scheduled-lane
    at: 2026-11-04T08:03:00Z

    Fresh revalidation: issue #3949 is OPEN. PR #5227 is OPEN at d6bf168; checks are SUCCESS (1/1), no required checks pending or failures, and no unresolved feedback. No hard-stop labels are present. Queue labels are synchronized as work/assigned, queue/claimed, status/in-progress. Prior checkpoint records renderer-output CDP results of 0 elements beyond 391px for both paths, but not live-route verification; the PR also records that aggregator-specific CI does not run on pull_request.

    resume: continue only PR #5227 and existing task worktree; compare the prior geometry method with task 4896 acceptance and verify whether the evidence is sufficient. Do not duplicate implementation.

  11. added a commit that references this issue on Nov 4, 2026
  12. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    event: done
    task: 8714 (small_fix, repo-health-code-pilot; worker repo-worker-code; lane 02cafe76-eafd-4d0b-aaa6-2b7a737d68dc)
    by: openchamber-scheduled-lane
    at: 2026-11-04T08:10:00Z

    PR #5227 merged at 78e2a8a. The scoped /attention header wrapping and /item session-record containment fix is in main. Focused rerun on the PR head: 47 tests passed, 0 failed (213 assertions); prior full aggregator suite: 1463 passed, 0 failed. GitHub's required PR check rollup was SUCCESS 1/1. Aggregator-specific workflows are main-tier only and do not trigger on pull_request; this coverage gap was disclosed on PR #5227. The 390x844 CDP evidence measured fixture-rendered renderer output (0 elements beyond right=391 outside deliberate wrappers), not the live routes; that limitation is documented on the PR.

    Fresh post-merge state: PR #5227 MERGED; issue #3949 remains OPEN. Removed queue/claimed, status/in-progress and work/assigned so the issue no longer appears in-flight; prior status/triaged is retained. Queue result: fixed_merged; sandbox backlog/sweep bookkeeping deferred to fleet reconciliation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/pm-stackpm-stack (Pad/Grist) in developing-today/codeeffort/sSmall: expected under 2 hours of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/normalOrdinary priority (the default)source/queue-workerFiled or worked by the queue/worker pilotstatus/triagedTriaged and routed (see agent note)task/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions