Skip to content

build(id): lib test E0063 — ChainExt literal in idset.rs tests missing the #3814 note field (blocks #3720 fold) #4047

Closed

Description

@dezren39

Fourth distinct id breakage today, found while landing #4015 (2026-11-01): at current main, cargo test -p id --lib does not compile.

error[E0063]: missing field `note` in initializer of `chain::ChainExt`
  --> src/idset.rs:755

ChainExt gained note: Option<NoteOp> in the #3814 note work (see src/chain.rs: pub note). 8a5ccbfe added the field to ChainExt literals in the integration tests, but the lib test initializer in src/idset.rs (a writer-kind sample-set event) was missed.

Fix: note: None at that one literal — the event is not a note operation, matching its other empty fields. Verified by a full lib-suite compile scan: this is the only E0063 in the lib test target; production constructors and integration-test literals already carry the field.

Sequence for the record: #3787 → #3951 → #4015 → this issue. Each fix reveals the next failure because the suite could not run to completion. This is the last known gate for the #3720 fold switch; the fix rides the #4015 branch (PR #4027).

Acceptance criteria

Activity

  1. dezren39 commented on Nov 1, 2026

    @dezren39
    MemberAuthor

    Fixed in PR #4027 (note: None at the one literal). Verified: the lib suite compiles and runs at the merged tip (1527 tests); the only failure in that run was the unrelated load-sensitive log_sync test filed as #4057.

  2. added
    kind/bugSomething isn't working (prefixed form of the classic bug label)
    effort/xsTrivial: expected under 30 minutes of work
    app/idPackage/app: id (pkgs/ or apps/ in this repo)
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 2, 2026
  3. dezren39 commented on Nov 2, 2026

    @dezren39
    MemberAuthor

    Intake review

  4. dezren39 commented on Nov 2, 2026

    @dezren39
    MemberAuthor

    Fixed in PR #4027, merge commit ee75087 — verified as a git object, ancestor of origin/main, with the note: None literal grepped in origin/main's tree. The #3720 fold's id gate is green: nix build .#id-web EXIT=0 on the PR tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    app/idPackage/app: id (pkgs/ or apps/ in this repo)effort/xsTrivial: expected under 30 minutes of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/lowNice to have; do when convenientstatus/needs-triageNot yet triaged; needs a first look

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions