Skip to content

proxy-port.test: parse-site count drifted from the tree — expects 8 sites, six proxies now have 7 #4846

New issue
New issue
Closed
#5010
Closed
proxy-port.test: parse-site count drifted from the tree — expects 8 sites, six proxies now have 7#4846
#5010
Assignees
dezren39
Labels
app/pm-stackpm-stack (Pad/Grist) in developing-today/codeeffort/xsTrivial: expected under 30 minutes of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/lowNice to have; do when convenientsource/creatorFiled by the new-issue-creator jobtask/triageQueue packet kind: verify, reproduce, and route this item

Description

@dezren39
dezren39
opened on Nov 3, 2026

Summary

bin/proxy-port.test.mjs test "all eight parse sites in the six proxies use the shared helper" fails on clean main: it expects 8 parseProxyPort('<NAME>_PROXY_PORT', <port>) call sites across codex/clef/agy/antigravity-ls/design-code/muse proxies, but the six files now contain 7.

Evidence (2026-11-03, found by queue task 4719, lane code-g)

  • Reproduced identically in two places: the task 4719 worktree (branch off main 1e3763faf) and the untouched laptop primary clone at the same main — node --test bin/proxy-port.test.mjs → AssertionError: 7 !== 8 at bin/proxy-port.test.mjs:332.
  • Current sites in the six files (grep on main): codex-proxy 1, clef-proxy 1, agy-proxy 1, antigravity-ls-proxy 1, design-code-proxy 3 (DESIGN_CODE_PROXY_PORT, ANTIGRAVITY_DIRECT_PORT, CODEX_PROXY_PORT — the antigravity-direct rework folded extra ports into this file), muse-proxy 1 — that sums to 8 only if one of the counted files still has the shape the test expects; the test's per-file regex/count drifted from the tree during the proxy reworks (design-code-proxy now carries the antigravity-direct port parses).
  • The failure is pre-existing and unrelated to task 4719 / PR feat(proxies): socket-activate clef-proxy and codex-proxy (#1821) #4845 (socket activation), which does not touch any parseProxyPort site; it is filed here so the drift is tracked instead of rediscovered per shift.

Acceptance criteria

  • The count test matches the actual intended inventory: either restore the missing parse site if a proxy regressed to a bare parse, or update the test's inventory/expectation to the post-rework layout (naming the sites it counts).
  • node --test bin/proxy-port.test.mjs passes on main.

Activity

  1. dezren39
    added
    kind/bugSomething isn't working (prefixed form of the classic bug label)
    app/pm-stackpm-stack (Pad/Grist) in developing-today/code
    effort/xsTrivial: expected under 30 minutes of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    priority/lowNice to have; do when convenient
    status/needs-triageNot yet triaged; needs a first look
    on Nov 3, 2026

  2. dezren39 commented on Nov 3, 2026

    @dezren39
    dezren39
    on Nov 3, 2026
    MemberAuthor

    Intake review

    Related: see the issue body and its linked references; no merged PR was found that resolves this issue at intake time (checked at fleet-monitor run 2026-11-03 04:12 CST).

    Notes: Side finding filed from lane work on task 4719 (PR #4845). The drift is pre-existing on main, so this is not a regression from that PR. Suggested approach: recount parse sites in the tree, decide whether expectation or counter is wrong, and fix exactly that one.

    Risks / suggested approach: as noted above; acceptance criteria have been appended to the issue body and labels normalized by the fleet monitor.

    🤖 Agent note · filed

    • Agent: fleet monitor (repo-fleet-monitor)
    • Session / ID: repo-fleet-monitor run 2026-11-03 04:12 CST
    • Found via: monitor reconciliation (intake enrichment, protocol §5)
    • Task: Intake enrichment — acceptance criteria, labels, related context.
  3. github-actions
    assigned
    dezren39
    on Nov 3, 2026
  4. dezren39
    added
    queue/queuedHas a queued task in the Supabase agent queue
    source/creatorFiled by the new-issue-creator job
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 3, 2026

  5. dezren39 commented on Nov 3, 2026

    @dezren39
    dezren39
    on Nov 3, 2026
    MemberAuthor

    agent-note:v1
    state: triaged (coverage pass)
    Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 30 (priority/low). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
    Found via: coverage pass 2026-11-03

  6. dezren39
    added a commit that references this issue on Nov 3, 2026

    test(proxy-port): inventory parse sites per proxy instead of a bare t…

    830ac0a

  7. dezren39 commented on Nov 3, 2026

    @dezren39
    dezren39
    on Nov 3, 2026
    MemberAuthor

    🤖 Agent note · done (PR opened)

    • Agent: openchamber scheduled lane (1a180ae5), worker repo-worker-code
    • Session / ID: task 8456 (triage)
    • Found via: queue claim
    • Task: reproduced the drift at current main, fixed the test's stale inventory, PR opened.
    • Expectation: merge once checks are green; no held/Drew-owned restriction on the issue.

    Reproduced on the laptop primary clone at main: node --test bin/proxy-port.test.mjs → AssertionError: 7 !== 8 at bin/proxy-port.test.mjs:332 — exactly as filed.

    Root cause: the test counted parseProxyPort('<NAME>_PROXY_PORT', <port>) sites and expected 8, but design-code-proxy.mjs also parses ANTIGRAVITY_DIRECT_PORT (folded in by the antigravity-direct rework). That name does not match the _PROXY_PORT suffix, so a correct tree counted 7. The tree was right; the test's inventory had drifted.

    Fix: bin/proxy-port.test.mjs now asserts a named per-file inventory — codex 1, clef 1, agy 1, antigravity-ls 1, design-code 3 (DESIGN_CODE_PROXY_PORT, ANTIGRAVITY_DIRECT_PORT, CODEX_PROXY_PORT), muse 1 — and the bare-parse guard covers any *PORT env var instead of only *_PROXY_PORT. Moving a port between proxies now updates the list deliberately instead of drifting a total.

    Verification: node --test bin/proxy-port.test.mjs → 14/14 pass (was 13/14).

    PR: #5010 — #5010 (merge commit; no held/Drew-owned labels involved).

    Labels synced: queue/claimed and work/assigned cleared; the PR carries the in-flight state.

  8. dezren39
    removed
    status/needs-triageNot yet triaged; needs a first look
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 3, 2026
  9. dezren39
    added a commit that references this issue on Nov 3, 2026

    Merge pull request #5010 from developing-today/queue/8456-4846-proxy-…

    710652d
  10. dezren39
    closed this as completedin #5010on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/pm-stackpm-stack (Pad/Grist) in developing-today/codeeffort/xsTrivial: expected under 30 minutes of workkind/bugSomething isn't working (prefixed form of the classic bug label)meta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/lowNice to have; do when convenientsource/creatorFiled by the new-issue-creator jobtask/triageQueue packet kind: verify, reproduce, and route this item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions