aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1)

Disposition 1 of design #3702 Phase 3 (audit task 5613, 2026-11-03). mergeQuiet now rejects out-of-range clock times (#3686), so no new bad row can be stored, but rows written before that fix are still read raw:

inQuietHours (pm-stack/aggregator/src/alerts.ts:168) converts quiet.start/quiet.end with toMin() without validating them, so a stored 99:99 becomes minute 6039 and 24:60 becomes 1500 — the window silently becomes a different one (often suppressing almost the whole day).
The /alerts prefs form renders the stored string straight back (pm-stack/aggregator/src/render.ts formQuietStart/formQuietEnd).

Design decision 3 says stored rows are not silently rewritten, so the fix is a read-side sanitize (pass stored values through mergeQuiet before use, or clamp per field to the default) and/or a one-off data fix with the row ids recorded. Either way the audit wants the old rows' fate to be explicit rather than a silent reinterpretation.

Also covers the stored-invalid-tz half of disposition 3: an unknown stored zone makes inQuietHours fail open (return false, no suppression) — deliberate for delivery, but the read path should probably fall back to the default zone instead of disabling quiet hours.

Acceptance: a test that a stored 99:99/24:60/bad-tz row produces the default window (or a documented fail-open), and a note on #3702 saying whether production rows were found and fixed.

Filed from #3702 Phase 3 audit; no behaviour change landed there by design.

agent-note:v1

transition: handed_off
task: 8593
worker: repo-worker-code (lane code-d)
execution_lane: opencode
note: Task 8593 re-claimed by lane code-d after a prior lease cycle; lane assignment is opencode and the lane ledger already carries bound claimant session ses_e5e5cad3cadffemQ5io2NYBnVf. Handed off to that session — PR fix(aggregator): sanitize stored quiet prefs on read #5169 is canonical for issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978. No duplicate session should be launched.

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-e
Session / ID: task 8593
Found via: queue claim
Task: task 8593 for issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978 (small_fix) — execution lane assigned opencode
Expectation: the laptop claimant launches the bound opencode session, which drives task 8593 to its terminal state
Links: issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-g
Session / ID: task 8593
Found via: queue claim
Task: task 8593 (small_fix, issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978) revalidated fresh: issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978 OPEN, no hard-stop labels; canonical PR fix(aggregator): sanitize stored quiet prefs on read #5169 OPEN (not draft). Execution lane opencode with a bound session already launched — handing off to the laptop claimant.
Expectation: the bound session drives task 8593 to a terminal state via PR fix(aggregator): sanitize stored quiet prefs on read #5169.
Links: issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978 · PR fix(aggregator): sanitize stored quiet prefs on read #5169

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-b
Session / ID: task 8593
Found via: queue claim
Task: task 8593 for issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978 (small_fix) — execution lane assigned opencode
Expectation: the laptop claimant launches the bound opencode session, which drives task 8593 to its terminal state
Links: issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978

agent-note:v1
task 8593 picked up by lane code-g; execution lane opencode with a bound claimant session already recorded (ses_e5e5cad3cadffemQ5io2NYBnVf) — handed off; the bound session drives task 8593 to its terminal state. Issue #4978 OPEN, PR #5169 OPEN (canonical), no hard-stop labels.

🤖 Agent note · bound

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: task 8593
Found via: monitor reconciliation (Duty 1B PR↔queue join)
Task: verified binding — open PR fix(aggregator): sanitize stored quiet prefs on read #5169 (fix(aggregator): sanitize stored quiet prefs on read; branch queue/8593-4978-…, pm-stack/aggregator alerts.ts + test) implements this issue. Task 8593 was queued/dead at digest time (cap repaired this run: 16→32) and has since been re-claimed by a lane (issue labels now queue/claimed + work/assigned). Shepherd PR fix(aggregator): sanitize stored quiet prefs on read #5169 — review CI, merge when green — do NOT re-implement. Formal monitor claim→park binding remains blocked by code queue: repo-fleet-monitor is not a registered worker — Duty 1B PR bindings cannot claim (tasks_worker_id_fkey 409) #5293; this note records the join for the current holder.
Expectation: PR fix(aggregator): sanitize stored quiet prefs on read #5169 merged or handed off with a checkpoint note.

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-h
Session / ID: task 8593
Found via: queue claim
Task: Execution-lane assignment for task 8593 is opencode; handed off to the laptop opencode claimant, which launches the bound session that drives task 8593 to its terminal state.
Expectation: claimant launches the bound opencode session for issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978; this lane does no direct work on task 8593.
Links: issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-j
Session / ID: task 8593
Found via: queue claim
Task: Task 8593 for issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978 is assigned to the opencode execution lane; handed off to the opencode claimant, which launches the bound session. Prior progress names PR fix(aggregator): sanitize stored quiet prefs on read #5169 as canonical — the bound session should resume from it, not start competing work.
Expectation: claimant launches the bound opencode session for task 8593; this lane does not work it directly.
Links: task 8593; issue aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978

No description provided.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane code-a
Session / ID: task 8593
Found via: queue claim
Task: small_fix for aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978 — claimed by lane code-a; execution-lane assignment: opencode
Expectation: handed to the opencode claimant, which launches the bound session
Links: queue task 8593

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-a
Session / ID: task 8593
Found via: queue claim
Task: execution lane is opencode — handed to the opencode claimant, which launches a session bound to task 8593
Expectation: claimant session drives task 8593 to its terminal state
Links: queue task 8593

🤖 Agent note · handed off

Agent: opencode claimant (opencode-claimant)
Session / ID: queue task 8593; bound session ses_e5e59053e56ffewpbGrfQr5kp5
Found via: queue task handoff on the opencode execution lane
Task: Fix aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978: sanitize stored out-of-range quiet prefs at read time in aggregator alerts
Expectation: the bound worker session works task 8593 to a terminal queue state and must not claim another task. It revalidates the issue/PR before acting.
Links: aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978

Navigation Menu

aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978

40 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

aggregator(alerts): sanitize stored out-of-range quiet prefs at read time (#3702 disposition 1) #4978

Description

Activity

40 remaining items

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions