Repository navigation
pm-stack(aggregator): typecheck red on main — test/overview.test.ts HealthView fixture missing the new required conflicts field (from #1282 / PR #5032) #5043
Description
pm-stack(aggregator): typecheck red on main — test/overview.test.ts HealthView fixture missing the new required conflicts field (from #1282 / PR #5032)
Evidence
Verified this run at origin/main 4ab80c458 in a clean laptop worktree (deps installed with bun install --frozen-lockfile):
cd pm-stack/aggregator && bunx tsc --noEmitexits 2 with exactly one error:
test/overview.test.ts(12,7): error TS2741: Property 'conflicts' is missing in type '{ status: "ok"; mode: "fixtures"; ... }' but required in type 'HealthView'.pm-stack/aggregator/src/health.ts:209—HealthViewnow requiresconflicts: ConflictsHealth | null;(added by commit2f2404a76, "feat(aggregator): read-only source-conflict inbox + API + health count (feat(aggregator): source-conflict inbox — one resolvable queue for Project-vs-derived and Kaneo-vs-GitHub disagreements, with per-class trust rulings #1282)", merged via PR feat(aggregator): read-only source-conflict inbox + API + health count (#1282) #5032).buildHealthpopulates it atsrc/health.ts:501-506from the optional input at:333.pm-stack/aggregator/test/overview.test.ts:12— the hand-builtconst health: HealthView = { ... }fixture was not updated in that commit and has noconflictskey.- The runtime suite is unaffected:
bun testpasses 1376/1376 at the same SHA — this is a type-level break only, which is exactly why it slipped through. - CI runs this check:
.github/workflows/pm-aggregator-tests.yml:38runsbunx tsc --noEmit, so the pm-aggregator tests workflow goes red on main until this is fixed. This is the same class as main CI failure: pm-aggregator Typecheck step — 27 pre-existing type errors unmasked after #4827 fix #4848 ("clear the last Typecheck errors on main"), regressed by the newest merge.
Why it matters
A red typecheck on main trains everyone to ignore the gate that catches real type drift between the health view's producers and consumers, and it blocks any PR whose CI inherits the failure. The fix is one fixture field, but it should land before the next aggregator change stacks on top of a red main.
Acceptance criteria
-
test/overview.test.ts'sHealthViewfixture carries a validconflictsvalue (e.g.conflicts: null, matching the fixtures mode of the rest of the fixture). -
bunx tsc --noEmitinpm-stack/aggregatorexits 0 at main. -
bun testinpm-stack/aggregatorstill passes (1376 tests at time of filing). - The pm-aggregator tests workflow is green on main again.
Activity
dezren39 commentedon Nov 3, 2026
🤖 Agent note · state: filed
bunx tsc --noEmitin a clean laptop worktree at origin/main 4ab80c4 (single TS2741 error), withbun testgreen 1376/1376 at the same SHA.conflictsfixture field; done when tsc exits 0 and the pm-aggregator tests workflow is green on main.dezren39 commentedon Nov 3, 2026
Cross-reference (new-issue-creator-code-a): related to #4023 ("tsc --noEmit red on main — 12-error baseline", filed 2026-11-01 at eb226be). Not a duplicate: none of #4023's 12 baseline errors is this one — the TS2741 in test/overview.test.ts could not exist before PR #5032 merged today and added the required
conflictsfield. My verification at 4ab80c4 found exactly one tsc error (this one), so #4023's baseline appears cleared (see #4848) and this issue tracks the sole remaining, newly introduced error.fix(aggregator): disposition Codex findings on the answer-dedupe PR (#…
fix(aggregator): prevent duplicate answers by question (#1476) (#4024)
dezren39 commentedon Nov 3, 2026
main-ci watch — new main failure for this workflow (fresh round)
Reusing this open issue #5043, which already tracks this exact failure: the run's Typecheck step (
bunx tsc --noEmit) fails withtest/overview.test.ts(12,7): error TS2741: Property 'conflicts' is missing in type ... but required in type 'HealthView'— the same error, file, and root cause documented on this issue (HealthView fixture missing the new requiredconflictsfield from #1282 / PR #5032). No duplicate issue filed, per the trigger dedupe rule.Fresh round note: the previous main-ci track for this workflow, issue #4995, was verified CLOSED at 2026-11-03T18:01:32Z, and run 41694364141 was created 2026-11-03T18:29:52Z (after that closure) — so this is a fresh round, tracked here on #5043 instead of a new duplicate.
Filed by main-ci-failure-fix-trigger (fleet). One fix track per failing workflow; duplicates are suppressed until this issue closes.
🤖 Agent note · filed
conflicts) — run https://github.com/developing-today/code/actions/runs/41694364141dezren39 commentedon Nov 4, 2026
🤖 Agent note · picked up
conflictsfield to the HealthView fixture in pm-stack/aggregator/test/overview.test.ts sobunx tsc --noEmitpasses on main again (regression from PR feat(aggregator): read-only source-conflict inbox + API + health count (#1282) #5032). Branch queue/8672-5043-healthview-fixture, worktree on the laptop under ~/git/fleet/8672.Merge pull request #5248 from developing-today/queue/8672-5043-health…
dezren39 commentedon Nov 4, 2026
🤖 Agent note · done
conflicts: null(the value buildHealth produces with no conflicts input). Verified on the laptop at origin/main 6a1a351: TS2741 reproduced before, gone after; bun test 1515 pass / 0 fail; Codex review clean. One pre-existing tsc error remains on main —src/item-history.tsusesGhKindwithout importing it — filed as pm-stack(aggregator): typecheck red on main — src/item-history.ts uses GhKind without importing it from model.ts #5247; the typecheck gate goes fully green when that lands.