Skip to content

id(tag_claims): 4 property tests red since #4765 — generated clears name a claim twice and the store now refuses them #5132

Closed

Description

@dezren39

Symptom

With the #4522 compile fix applied (PR #5117), the pkgs/id integration target tests/tag_claims.rs runs again and 4 property tests fail:

  • test_the_regression_histories_reach_the_oracle_through_every_path
  • test_each_event_names_every_event_its_author_had_seen
  • test_the_compacted_fold_agrees_with_the_causal_walk
  • test_the_live_set_is_the_oracle_under_any_delivery_order

All four panic at the same place:

thread panicked at tests/tag_claims.rs:82:69:
called Result::unwrap() on an Err value: Extension("a clear names a claim twice")

Root cause (evidence-linked, not yet fixed)

The #4522 fix itself only adds checkpoint: None to the fixtures — the panic is in the clear-path validation and is unrelated to that field.

Fix direction (owner to choose)

Either the generator must dedupe the claims in a generated clear (a clear naming a claim twice is now invalid input, so generating it is a generator bug), or the helper should model the refusal explicitly. The store validation from #4765 looks intentional and should stay.

Why it matters

.#id-web runs the suite in its Nix check phase (doCheck=true), so this also blocks the laptop fleet switch; it joins the other runtime-red pkgs/id tests tracked in #5020, #5021 and #5128. #4522/PR #5117 restores compilation only.

Acceptance

  • cargo test --test tag_claims in pkgs/id is green on main.

Activity

  1. added a commit that references this issue on Nov 3, 2026
  2. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    Fixed in PR #5162 (merged). The generator in tests/tag_claims.rs (history()) sampled a clear's targets with replacement; it now picks without replacement, with a comment naming #4765. The store validation is untouched. Verified on the laptop: cargo test -p id --test tag_claims — 12 passed / 0 failed (was 8/4, all four panicking at tag_claims.rs:82 a clear names a claim twice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions