You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
id(tag_claims): 4 property tests red since #4765 — generated clears name a claim twice and the store now refuses them #5132
The tag_claims property tests generate clear events from a small claim pool, so generated histories can name a claim twice; the test helper apply_clear_at unwraps the ingest result, so the new refusal fails the test.
The #4522 fix itself only adds checkpoint: None to the fixtures — the panic is in the clear-path validation and is unrelated to that field.
Fix direction (owner to choose)
Either the generator must dedupe the claims in a generated clear (a clear naming a claim twice is now invalid input, so generating it is a generator bug), or the helper should model the refusal explicitly. The store validation from #4765 looks intentional and should stay.
Why it matters
.#id-web runs the suite in its Nix check phase (doCheck=true), so this also blocks the laptop fleet switch; it joins the other runtime-red pkgs/id tests tracked in #5020, #5021 and #5128. #4522/PR #5117 restores compilation only.
Acceptance
cargo test --test tag_claims in pkgs/id is green on main.
Fixed in PR #5162 (merged). The generator in tests/tag_claims.rs (history()) sampled a clear's targets with replacement; it now picks without replacement, with a comment naming #4765. The store validation is untouched. Verified on the laptop: cargo test -p id --test tag_claims — 12 passed / 0 failed (was 8/4, all four panicking at tag_claims.rs:82 a clear names a claim twice).
Activity
Merge pull request #5162 from developing-today/fix/5132-tag-claims-cl…
dezren39 commentedon Nov 3, 2026
Fixed in PR #5162 (merged). The generator in
tests/tag_claims.rs(history()) sampled a clear's targets with replacement; it now picks without replacement, with a comment naming #4765. The store validation is untouched. Verified on the laptop:cargo test -p id --test tag_claims— 12 passed / 0 failed (was 8/4, all four panicking at tag_claims.rs:82a clear names a claim twice).