pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord

Problem

isSaasService in pm-stack/aggregator/src/feed.ts:697 (the element gate behind sanitizeSaasServices, applied at the loadFeed boundary) accepts any string as a SaaS service's measuredAt:

(typeof v.measuredAt === "string" || v.measuredAt === null) &&

That is weaker than every sibling measuredAt gate in the same file:

isQuotaFreshness — feed.ts:548: isIsoDate(v.measuredAt)
isPaygLine — feed.ts:969: (v.measuredAt === null || isIsoDate(v.measuredAt))

isIsoDate (validate.ts:116) requires a real ISO calendar date. The SaaS gate does not, so impossible and non-ISO stamps survive sanitization verbatim.

Verified (laptop bun probe at origin/main `12fcad9`, probe in `~/git/fleet/probe-2026-11-03-laneA4-scan`, removed after the run)

A minimal otherwise-valid service was passed through sanitizeSaasServices, then recordsFromSaasServices + isSnapshotRecord:

measuredAt	kept by sanitizeSaasServices	derived record ts	isSnapshotRecord
`2026-02-30`	yes (dropped=0)	`2026-02-30T12:00:00Z`	false
`2026-04-31`	yes (dropped=0)	`2026-04-31T12:00:00Z`	false
`March 2, 2026`	yes (dropped=0)	`March 2, 2026`	false
`not-a-date`	yes (dropped=0)	`not-a-dateT12:00:00Z`	false
`2026-03-01` (control)	yes	`2026-03-01T12:00:00Z`	true

Why it matters

recordsFromSaasServices (snapshot-records.ts:85, via tsFor at :32) derives one snapshot record per measured metric at the service's measuredAt. With a bad stamp every derived record fails isSnapshotRecord, so the service's snapshot history is silently dropped at append — the same failure shape as pm-stack(aggregator): recordsFromProviderUsage accepts impossible/non-ISO generated_at — Date.parse-only gate yields records isSnapshotRecord refuses, so the append CLI silently drops the whole provider-usage snapshot #5140, through a different gate.
conflicts.ts:133-134 feeds svc.measuredAt to ageDaysFrom, which uses raw Date.parse: 2026-02-30 rolls to Mar 2 and reports a concrete conflict age instead of null (unknown).
render.ts freshnessStamp prints measuredAt.slice(0, 10) verbatim, so 2026-02-30 / March 2, 2 render as the measured date on the service card (freshness itself is strict since pm-stack(aggregator): freshness() ages impossible and non-ISO measuredAt stamps as fresh — Date.parse rolls 2026-02-30 to Mar 2 and accepts 'March 2, 2026' #5102, so the stamp also reads stale with a nonsense date attached).

Distinct from: #5188 (same sanitizer — PAYG/metric range gates, now fixed; it left measuredAt type-only), #5018 (the saas-extract export-overlay documents, a different input path), and #5102 (freshness() consumer).

Acceptance criteria

isSaasService requires measuredAt to be null or isIsoDate(...), matching isPaygLine in the same file; a service with an impossible or non-ISO measuredAt is dropped by sanitizeSaasServices and counted in dropped.
Regression tests cover at least 2026-02-30, 2026-04-31, and a non-ISO string (March 2, 2026) being dropped, with a valid ISO date and a null stamp kept as controls.
Aggregator test suite and typecheck stay green.

🤖 Agent note · filed

Agent: new-issue-creator job (new-issue-creator-code-a)
Session / ID: cron new-issue-creator-code-a run 2026-11-03 22:05 CST
Found via: filed this run
Task: Gate isSaasService's measuredAt with isIsoDate (null stays allowed), matching isPaygLine/isQuotaFreshness in feed.ts; regression tests for impossible/non-ISO stamps.
Expectation: effort s — done when a service with an impossible/non-ISO measuredAt drops in sanitizeSaasServices (counted), valid/null stamps keep passing, and the aggregator suite + typecheck stay green.
Links: evidence + probe results in the issue body; queue packet enqueued this run (repo-health-code-pilot).

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane code-k
Session / ID: task 9179
Found via: queue claim
Task: task 9179 (small_fix for issue pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281): gate SaaS measuredAt with isIsoDate in isSaasService (feed.ts), with sanitizeSaasServices tests. Direct execution lane — working this myself. Issue pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281 verified open, no hard-stop labels, no existing PR for issue pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281.
Expectation: effort s; done = fix + tests on a queue branch, PR opened and merged when verified.
Links: issue pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281

🤖 Agent note · parked

Agent: queue worker (repo-worker-code), lane code-k
Session / ID: task 9179
Found via: queue claim
Task: task 9179 parked awaiting CI on PR fix(pm-stack): gate SaaS measuredAt with isIsoDate in isSaasService (#5281) #5282 (fix for issue pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281). Implementation complete and pushed (commit 3886970); targeted tests pass on the laptop; Codex review completed with no findings. PR checks stayed QUEUED past the 5-minute poll window (Actions backlog).
Expectation: on resume, read PR fix(pm-stack): gate SaaS measuredAt with isIsoDate in isSaasService (#5281) #5282 checks fresh; merge when green and close out task 9179.
Links: PR fix(pm-stack): gate SaaS measuredAt with isIsoDate in isSaasService (#5281) #5282, issue pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281

🤖 Agent note · parked

Agent: fleet monitor
Session / ID: repo-fleet-monitor run 2026-11-03 22:12 CST (safety-net reconciliation)
Found via: monitor reconciliation
Task: Label sync only: this issue carried queue/queued + queue/claimed at once while its live fix task (task 9179) is parked. Labels reset to the truth: queue/parked + status/parked, work/assigned kept. No task state changed.
Expectation: task 9179's holder resumes from its park as scheduled.

🤖 Agent note · parked

Agent: queue worker (repo-worker-code), lane L shift (code-l)
Session / ID: task 9179
Found via: queue claim (resume — PR fix(pm-stack): gate SaaS measuredAt with isIsoDate in isSaasService (#5281) #5282 was opened by the earlier claim and parked on CI)
Task: Resumed task 9179: read PR fix(pm-stack): gate SaaS measuredAt with isIsoDate in isSaasService (#5281) #5282 fresh — OPEN, MERGEABLE, Codex findings none (0 inline comments, 0 reviews, 0 bot comments at 2026-11-04T05:24Z). Polled CI ~5 minutes: "aggregator tests and typecheck" and "contract corpus" still pending (run 41773719305). Parked task 9179 for 20 minutes per the park-don't-wait rule.
Expectation: on resume, read PR fix(pm-stack): gate SaaS measuredAt with isIsoDate in isSaasService (#5281) #5282 checks + Codex findings fresh; merge when green and findings dispositioned, then complete task 9179 as fixed_merged.
Links: task 9179 (parked until 2026-11-04T05:48:44Z), PR fix(pm-stack): gate SaaS measuredAt with isIsoDate in isSaasService (#5281) #5282

Navigation Menu

Repository navigation

pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281

Problem

Verified (laptop bun probe at origin/main `12fcad9`, probe in `~/git/fleet/probe-2026-11-03-laneA4-scan`, removed after the run)

Why it matters

Acceptance criteria

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

pm-stack(aggregator): isSaasService accepts impossible/non-ISO measuredAt — derived snapshot records fail isSnapshotRecord #5281

Description

Problem

Verified (laptop bun probe at origin/main 12fcad9, probe in ~/git/fleet/probe-2026-11-03-laneA4-scan, removed after the run)

Why it matters

Acceptance criteria

Activity

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

dezren39 commented on Nov 4, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Verified (laptop bun probe at origin/main `12fcad9`, probe in `~/git/fleet/probe-2026-11-03-laneA4-scan`, removed after the run)