python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests)

Two Python suites carry `unittest.main()` mid-file — direct-script runs silently skip every test class defined after it

Verified on main af0847d00a2231c71f6ebb59eba4cc7db197599e (2026-11-04, gh api raw reads + executed copies of the committed files).

Evidence

1. `pkgs/cold-store-reaper/tests/test_cold_store.py`

Lines 3223–3224: if __name__ == "__main__": unittest.main(verbosity=2) — mid-file.
Line 3227: class TestResumableUploadStalls(ColdStoreTestBase) is defined after that guard, with 3 tests (lines 3252, 3261, 3270). They are the regression tests for closed cold-store-reaper: resumable upload loops forever on a 308 whose Range stops advancing — no progress check or retry cap, and a Range-less 308 counts unacknowledged bytes as sent #2797: a resumable-upload 308 whose Range stops advancing must raise instead of looping forever, and a Range-less 308 must not count unacknowledged bytes as sent.
The file's own header (lines 4–5) documents two run modes: python3 -m unittest discover -s pkgs/cold-store-reaper/tests -v or python3 pkgs/cold-store-reaper/tests/test_cold_store.py.
Executed this run from a verbatim copy of the committed files (+ cold_store.py, schema.sql):
- Direct: python3 tests/test_cold_store.py → Ran 109 tests; zero TestResumableUploadStalls tests appear.
- Discover: python3 -m unittest discover -s tests -v → Ran 112 tests; all 3 stall tests run and pass.
- (13 failures in both modes in the verification copy are an artifact of the partial copy — missing scripts/drill_compare.py / export-turso fixtures — identical in both modes and unrelated.)
CI (.github/workflows/cold-store-reaper.yml) uses discover, so CI is not affected; the documented direct-script mode silently is.

2. `scripts/tests/test_update_nixpkgs_inputs.py`

Lines 377–378: if __name__ == "__main__": unittest.main() — mid-file, followed by a fresh import block (line ~380) and the entire fix(scripts): gate nixpkgs-unstable input updates on the Hydra channel (cached) revision #4553 section.
Defined after the guard: TestHydraGateParsing (line 473, 2 tests), TestGatedPinEndToEnd (line 611, 2 tests), TestHttpsContext (line 671, 1 test) — 5 tests pinning the fix(scripts): gate nixpkgs-unstable input updates on the Hydra channel (cached) revision #4553 Hydra cache-gate contract and the HTTPS-verification-stays-on contract for both copies of update-nixpkgs-inputs.
Executed this run from a verbatim copy (with both script copies in place):
- Direct: python3 scripts/tests/test_update_nixpkgs_inputs.py → Ran 9 tests.
- Discover: python3 -m unittest discover -s scripts/tests -p 'test_update_nixpkgs_inputs.py' → Ran 14 tests; the 5 after-guard tests run and pass.
- (1 identical error in both modes is the verification copy's missing repo-root flake.lock — unrelated.)
CI (.github/workflows/scripts-test.yml line 31) uses discover, so CI is not affected; a direct run silently is.

Why it matters

unittest.main() raises SystemExit when the module is executed as a script, so any class defined below the guard is never even defined in that process — the suite reports a smaller, green-looking run with no warning. In both files the stranded tests are safety contracts (#2797 upload-stall protection; #4553 pin gating). Anyone verifying a change with the documented/quick direct invocation — exactly what the cold-store header offers — gets illusory coverage. Sibling instance, filed separately because its mechanism differs (dead defs are outside any class, so they never run in any mode): #5710.

A repo-wide scan this run (all 41 Python test files) found exactly these two remaining mid-file-guard instances besides #5710's file.

Acceptance criteria

In both files, the if __name__ == "__main__": unittest.main() block is the last executable statement in the file (nothing defined after it).
python3 pkgs/cold-store-reaper/tests/test_cold_store.py reports 112 tests (was 109), including the 3 TestResumableUploadStalls tests.
python3 scripts/tests/test_update_nixpkgs_inputs.py reports 14 tests (was 9), including TestHydraGateParsing, TestGatedPinEndToEnd, and TestHttpsContext.
Discover invocations report the same counts as before the change (112 / 14) and no test outcome changes; no production code is modified.

🤖 Agent note · filed

Agent: new-issue-creator-code-b (Lane B, developing-today/code)
Session / ID: cron job new-issue-creator-code-b, run 2026-11-04T23:59Z
Found via: filed this run
Task: Filed issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712 — two Python suites carry unittest.main() mid-file: in pkgs/cold-store-reaper/tests/test_cold_store.py (guard at 3223–3224, TestResumableUploadStalls at 3227) and scripts/tests/test_update_nixpkgs_inputs.py (guard at 377–378, three fix(scripts): gate nixpkgs-unstable input updates on the Hydra channel (cached) revision #4553/HTTPS classes after it). Verified by executing verbatim copies both ways: cold-store direct run reports 109 tests vs 112 under discover; nixpkgs-inputs direct reports 9 vs 14 under discover. The after-guard tests all pass under discover, and CI uses discover for both files — this is illusory coverage on the direct-script path (documented in the cold-store file header), not a CI gap. Sibling of cargo-target-janitor: owner_changed tests never run — defined after unittest.main(), outside the test class #5710 (different mechanism: those defs are outside any class and never run in any mode).
Expectation: effort xs — move each __main__ guard to end-of-file; direct runs then report 112 / 14 tests, discover counts unchanged, no production code touched.
Links: body file hidden_files/issue-python-midfile-unittest-main.md; queue packet hidden_files/packet-5712-fix.json

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane code-v
Session / ID: task 9761
Found via: queue claim
Task: Triage issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712 — verify the mid-file unittest.main() guards at current main and route the fix.
Expectation: effort class xs for triage; done = findings posted with fresh evidence and a follow-up fix task enqueued.
Links: issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712

🤖 Agent note · done

Agent: queue worker (repo-worker-code), lane code-v
Session / ID: task 9761
Found via: queue claim
Task: Triage issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712 — confirmed at current main, routed to a fix task.
Expectation: done = findings below + follow-up task 9769 enqueued.
Links: issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712; follow-up task 9769

Triage findings (task 9761, verified 2026-11-05)

Confirmed — still present at current main. Fresh gh api contents reads this run:

pkgs/cold-store-reaper/tests/test_cold_store.py — blob b4a5ef254951e12e20f9deb6f6778d58b371ed88, 3289 lines; if __name__ == "__main__": unittest.main(verbosity=2) at lines 3223–3224, with TestResumableUploadStalls (the cold-store-reaper: resumable upload loops forever on a 308 whose Range stops advancing — no progress check or retry cap, and a Range-less 308 counts unacknowledged bytes as sent #2797 stall tests) defined after it.
scripts/tests/test_update_nixpkgs_inputs.py — blob cd190b259cfa39eb8dbbab43b1bae142f1c5a4ea, 680 lines; if __name__ == "__main__": unittest.main() at lines 377–378, with the fix(scripts): gate nixpkgs-unstable input updates on the Hydra channel (cached) revision #4553 section and 5 tests defined after it.

Issue #5712 is OPEN with no hard-stop labels (held, user/owned, do-not-merge, do-not-auto-edit all absent) and no matching PR. The issue's own executed evidence (direct runs 109 vs 112 and 9 vs 14 tests; discover/CI unaffected) stands — nothing on current main has moved either guard.

Routing: the fix is exactly the issue's acceptance criteria — move each guard block to be the last executable statement in its file, no test content or production code changes. Enqueued as task 9769 (small_fix, repo-health-code-pilot). Issue #5712 stays open for task 9769.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane code-k
Session / ID: task 9769
Found via: queue claim
Task: task 9769 (small_fix, direct lane) for issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712: move the mid-file unittest.main() guards to end of file in both test suites so direct-script runs execute all tests.
Expectation: effort s; done = PR opened with both guards as last statement, direct runs report 112 / 14 tests.
Links: issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712

Merge pull request #5726 from developing-today/queue/9769-5712-unitte…

🤖 Agent note · done

Agent: queue worker (repo-worker-code), lane code-k
Session / ID: task 9769
Found via: queue claim
Task: task 9769 for issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712 done: both unittest.main() guards moved to end of file via PR test: move unittest.main() guards to end of file in both suites (#5712) #5726, merged as b342c19; issue python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712 auto-closed by the merge.
Expectation: met — direct runs on the laptop reported 112 tests (OK, skipped=1) for test_cold_store.py and 14 tests for test_update_nixpkgs_inputs.py; discover counts/outcomes unchanged; Codex review completed with no findings. The 2 nixpkgs-inputs failures (TestDiscoverInputs flake_lock) are pre-existing on clean main and filed as issue test_update_nixpkgs_inputs: TestDiscoverInputs flake_lock test fails on main (root + pkgs/id copies) #5725.
Links: PR test: move unittest.main() guards to end of file in both suites (#5712) #5726 · branch queue/9769-5712-unittest-main-guard-end · issue test_update_nixpkgs_inputs: TestDiscoverInputs flake_lock test fails on main (root + pkgs/id copies) #5725

Navigation Menu

Repository navigation

python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712

Two Python suites carry `unittest.main()` mid-file — direct-script runs silently skip every test class defined after it

Evidence

1. `pkgs/cold-store-reaper/tests/test_cold_store.py`

2. `scripts/tests/test_update_nixpkgs_inputs.py`

Why it matters

Acceptance criteria

Triage findings (task 9761, verified 2026-11-05)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

python tests: unittest.main() mid-file in two suites — direct-script runs silently skip the classes after it (cold-store #2797 stall tests, nixpkgs-inputs #4553 gate tests) #5712

Description

Two Python suites carry unittest.main() mid-file — direct-script runs silently skip every test class defined after it

Evidence

1. pkgs/cold-store-reaper/tests/test_cold_store.py

2. scripts/tests/test_update_nixpkgs_inputs.py

Why it matters

Acceptance criteria

Activity

dezren39 commented on Nov 5, 2026

dezren39 commented on Nov 5, 2026

dezren39 commented on Nov 5, 2026

Triage findings (task 9761, verified 2026-11-05)

dezren39 commented on Nov 5, 2026

dezren39 commented on Nov 5, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Two Python suites carry `unittest.main()` mid-file — direct-script runs silently skip every test class defined after it

1. `pkgs/cold-store-reaper/tests/test_cold_store.py`

2. `scripts/tests/test_update_nixpkgs_inputs.py`