ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests

Finding

infra/cargo-target-janitor/tests/test_cargo_target_janitor.py (13 tests) is run by no workflow, justfile recipe, or flake check — the same gap class as #5942/#5945/#5946/#5951, for a destructive tool.

The suite pins the janitor's deletion-safety rules: claimed-task targets are protected (:37), open-PR targets are protected (:52), recent/unmapped targets are never candidates (:66), adhoc targets are protected during any fleet build (:100), hardlinked artifacts are counted once (:159), and the default mode logs a plan without deleting (:183). The janitor itself runs hourly in production via infra/cargo-target-janitor/systemd/cargo-target-janitor.timer → cargo-target-janitor.service (ExecStart=... cargo-target-janitor --apply) — the timer runs the deleter, never its tests.

Evidence (verified this run, laptop primary @ `d82a48a`)

grep -rn "cargo-target-janitor|cargo_target_janitor" .github/workflows/ .github/scripts/ justfile scripts/ infra/ (excluding the package's own directory) → zero references.
README:69 documents only a manual run: python3 ~/git/code/infra/cargo-target-janitor/tests/test_cargo_target_janitor.py.
The suite passes today, run by hand on the laptop: python3 -m unittest discover -s infra/cargo-target-janitor/tests → Ran 13 tests, OK (0.015s, offline).
Distinct from closed cargo-target-janitor: owner_changed tests never run — defined after unittest.main(), outside the test class #5710: that issue fixed two owner_changed tests defined after unittest.main() so they never ran at all (now :191/:205, inside JanitorTests); this issue is that the now-complete suite is wired into no CI, so a future regression in the protection rules surfaces as wrongly deleted build targets.

Why it matters

The janitor deletes cargo target directories with --apply on an hourly timer. Its protection rules are the only thing standing between a fleet build in progress and the deletion of its target dir (or a claimed task's / open PR's build cache). Those rules currently have zero automated regression signal.

Acceptance criteria

A CI step (a new small workflow or an existing infra-tests workflow, following .github/ci-policy.md) runs infra/cargo-target-janitor/tests/test_cargo_target_janitor.py and fails when a test fails (no continue-on-error).
The wiring names the test file/discovery directory explicitly so a green run cannot be a silently skipped suite.
The full suite (13 tests) passes under the new wiring on a Linux runner.
No behaviour change to bin/cargo_target_janitor.py.

CODE-1619

🤖 Agent note · filed

Agent: new-issue-creator job (new-issue-creator-code-a, Lane A)
Session / ID: new-issue-creator-code-a run 2026-11-04 22:35 CST
Found via: filed this run
Task: Filed this CI-coverage finding: infra/cargo-target-janitor's 13-test suite (deletion-safety rules for the hourly --apply janitor) is run by no workflow — verified passing by hand on the laptop primary @ d82a48a, zero references in workflows/scripts/justfile. Distinct from closed cargo-target-janitor: owner_changed tests never run — defined after unittest.main(), outside the test class #5710 (dead tests inside the file, now fixed).
Expectation: effort s — a queue triage packet is enqueued; done looks like a CI step running the suite with failure propagation.
Links: packet hidden_files/packet-5952-triage.json (goal workspace)

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-e
Session / ID: task 9857
Found via: queue claim
Task: Triage ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952 — execution-lane assignment returned opencode; handing to the opencode claimant, which launches the bound session. This lane did no verification work on the task.
Expectation: the claimant's bound session triages ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952 (verify the cargo-target-janitor suite is run by no workflow and passes, then route the wiring fix).
Links: task 9857 (queue repo-health-code-pilot)

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-y
Session / ID: task 9868
Found via: queue claim
Task: task 9868 handed off to the opencode claimant (assigned_lane=opencode, instruction §1b) and parked 1200s pending claimant launch. Issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952 remains OPEN.
Expectation: claimant launches the bound opencode session for task 9868; if the lease/park expires first, task 9868 returns to the queue.
Links: issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-k
Session / ID: task 9868
Found via: queue claim
Task: CI deletion-safety suite for issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952 — execution lane assigned opencode; handing off to the opencode claimant. Fresh check: issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952 OPEN, no hard-stop labels.
Expectation: claimant launches the bound opencode session; that session drives task 9868 to a terminal state.
Links: issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952

🤖 Agent note · handed off

Agent: fleet monitor (repo-fleet-monitor)
Session / ID: task 9868; monitor run 2026-11-07 04:12 CST
Found via: monitor reconciliation (claim/label divergence)
Task: Claim evaporated — task 9868 is queued and unclaimed in repo-health-code-pilot (no live lease) while this issue still carried claimed/assigned labels. Labels reset to the truth: queue/queued + status/needs-triage. Last checkpoint stage on the task: handed_off.
Expectation: the next queue claimant picks up task 9868 from its checkpoint; no work was lost.

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-t
Session / ID: task 9868
Found via: queue claim
Task: fix issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952 (cargo-target-janitor deletion-safety suite in CI) — execution-lane assignment is opencode; handing off to the opencode claimant per the queue protocol, not working it in this lane
Expectation: the bound opencode session drives task 9868 to a terminal state; if the claimant has not launched by lease expiry the task returns to the queue
Links: task 9868 (queue repo-health-code-pilot), issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952

🤖 Agent note · handed off

Agent: queue worker (repo-worker-code), lane code-c
Session / ID: task 9868
Found via: queue claim
Task: CI wiring for issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952 (run the cargo-target-janitor deletion-safety suite in CI) handed to the opencode execution lane (assigned_lane=opencode for task 9868); the bound opencode claimant session drives it to its terminal state
Expectation: claimant launches the bound opencode session; if the claim lease expires unbound, task 9868 returns to the queue
Links: issue ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952

Navigation Menu

Repository navigation

ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952

Finding

Evidence (verified this run, laptop primary @ `d82a48a`)

Why it matters

Acceptance criteria

236 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

ci(cargo-target-janitor): test_cargo_target_janitor.py (13 tests, deletion-safety rules) run by no workflow — hourly timer runs the deleter, never its tests #5952

Description

Finding

Evidence (verified this run, laptop primary @ d82a48a)

Why it matters

Acceptance criteria

Activity

developing-today commented on Nov 5, 2026

dezren39 commented on Nov 5, 2026

dezren39 commented on Nov 5, 2026

236 remaining items

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 7, 2026

dezren39 commented on Nov 8, 2026

developing-today commented on Nov 8, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Evidence (verified this run, laptop primary @ `d82a48a`)