Skip to content

fleet brokers: review-finding hardening for dual-bind transports (from PR #6514) #6515

Open

Description

@dezren39

Follow-up from PR #6514 (implements #6216, dual-bind Unix-socket listeners for queue-broker + secrets-broker), filed by queue worker task 11120 so the review findings are tracked, not lost at merge.

CodeRabbit posted 11 actionable comments on PR #6514 (2026-11-06T12:54Z), after the PR was verified (fleet-queue 39 tests pass, fleet-config 16 pass, live TCP+UDS smoke on both brokers). None were dispositioned in that PR; they are recorded here instead of blocking the verified dual-bind change (standing merge rule: merge when verified, fix forward).

Findings to disposition (fix, or reply on the PR #6514 thread why not):

Acceptance:

Acceptance criteria

  • Every CodeRabbit thread on PR feat(fleet-queue): dual-bind Unix-socket listeners for queue-broker + secrets-broker (#6216) #6514 is dispositioned: fixed in a follow-up PR, or answered on the thread with a reason.
  • Both broker transports (queue-broker and secrets-broker, TCP and UDS) reject unauthorized POSTs before reading the request body, and enforce a body-size cap and a read timeout — or carry an explicit documented decision against, recorded on this issue.
  • Regression tests cover the unauthenticated large/unfinished body case on the TCP path (oracle: the request is refused before the body is consumed).

Activity

  1. added
    app/fleetpkgs/fleet multicall binary + platform crates
    on Nov 6, 2026
  2. developing-today commented on Nov 6, 2026

    @developing-today
    Contributor
  3. added
    kind/securitySecurity issue or security hardening
    source/queue-workerFiled or worked by the queue/worker pilot
    priority/highImportant and time-sensitive
    effort/mMedium: expected under 1 day of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 6, 2026
  4. dezren39 commented on Nov 6, 2026

    @dezren39
    MemberAuthor

    Intake review

    🤖 Fleet monitor intake (repo-fleet-monitor), 2026-11-06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    app/fleetpkgs/fleet multicall binary + platform crateseffort/mMedium: expected under 1 day of workkind/securitySecurity issue or security hardeningmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/highImportant and time-sensitivesource/queue-workerFiled or worked by the queue/worker pilotstatus/needs-triageNot yet triaged; needs a first look

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions