atlas-search: no command-level test covers the get-chunk --neighbors cap (PR #6322)

Finding (unaddressed PR review comment)

PR #6322 — "fix(atlas-search): cap get-chunk --neighbors at 100" — is still open, and a CodeRabbit review finding on it was never fixed or responded to. The 24-hour grace period for open PRs has passed (review 2026-11-05T17:18:47Z; rechecked 2026-11-06T18:08Z).

Reviewer: coderabbitai[bot], review 5789043954, 2026-11-05T17:18:47Z
Review: fix(atlas-search): cap get-chunk --neighbors at 100 #6322 (review)
File: pkgs/atlas-search/crates/atlas-search/src/main.rs:782-785 (test module) / cap call at main.rs:668

Essence of the comment ("Add a command-level test for get-chunk --neighbors above the cap"): the cap in cmd_get_chunk (main.rs:668) is covered only by tests that call count directly with Some(100). The command-level tests in tests/cli_parity.rs pass --neighbors only with 0 and 1. Removing the cap from the cmd_get_chunk call would not fail any test. The suggested test invokes get-chunk 2 --neighbors 101 --backend local via run_bin, asserting exit code 2 and the bound message on stderr.

No-response evidence

PR fix(atlas-search): cap get-chunk --neighbors at 100 #6322's only review is 5789043954; there are no inline comments and no replies to the review (verified by fresh gh api pulls/6322/comments and pulls/6322/reviews reads on 2026-11-06).
PR head 34687774a198bb023399c83ef3a51b4f2295378e is unchanged since the review and PR updatedAt is 2026-11-05T17:18:50Z — no fix commit followed the comment.

Still-live evidence

Read on the PR head (34687774, 2026-11-06):

src/main.rs:668: let neighbors = count("--neighbors", args.neighbors, 0, Some(100))?; — the command-path cap.
src/main.rs:781-793: the only above-cap tests call count("--neighbors", 101, 0, Some(100)) directly (unit level).
tests/cli_parity.rs: --neighbors appears only in the get_chunk_neighbors case with value "1" (lines 150-161, 195-216) — no command-level invocation above the cap exists, so deleting the Some(100) at the cmd_get_chunk call site would fail no test.

Dedupe: searched open/closed issues for "6322", "get-chunk neighbors command-level test", "neighbors cap cli_parity" on 2026-11-06 — no issue covers this test gap. Issue #5600 is the underlying cap defect PR #6322 fixes; it does not cover command-level test coverage of the cap.

Acceptance criteria

Fix the defect: add a command-level regression test (e.g. in tests/cli_parity.rs, alongside the existing CLI tests) that runs get-chunk with --neighbors 101 through the binary and asserts exit code 2 plus the --neighbors must be between 0 and 100 message on stderr; OR resolve this issue with a documented decision explaining why unit-level count coverage is sufficient.
Do not reply to or resolve the source PR review thread from the fix work (per the pr-comment-review job rules); the test lands with PR fix(atlas-search): cap get-chunk --neighbors at 100 #6322 or a follow-up, or the decision is recorded here.

CODE-2009

🤖 Agent note · state: filed

Agent: pr-comment-review job
Session / ID: pr-comment-review cron run 2026-11-06 11:54 CST
Found via: unaddressed PR comment — PR fix(atlas-search): cap get-chunk --neighbors at 100 #6322, CodeRabbit review fix(atlas-search): cap get-chunk --neighbors at 100 #6322 (review)
Task: Filed from an unaddressed, validated PR review finding; queued for triage (verify against current code, then fix or record a documented decision).
Expectation: effort s; done = a command-level test covers get-chunk --neighbors above the cap, or a documented decision is recorded on this issue.
Links: PR fix(atlas-search): cap get-chunk --neighbors at 100 #6322; source review above.

Picked up by repo-worker-code-p (lane code-p, repo-queue worker shift, FALLBACK MODE — queue backend down: fleet queue health/claim failing HTTP 503 PGRST002, code#6619). Working issue #6594 under the worker runbook §0a fallback protocol.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), lane code-p
Session / ID: repo-queue-worker-shift-p cron run 2026-11-06 20:17 CST — FALLBACK MODE (queue backend down, HTTP 503 PGRST002; fallback claim marker is the claim of record for issue atlas-search: no command-level test covers the get-chunk --neighbors cap (PR #6322) #6594, no broker task id exists this shift)
Found via: queue fallback scan (queue/queued label, scan order)
Task: triage issue atlas-search: no command-level test covers the get-chunk --neighbors cap (PR #6322) #6594 — the unaddressed CodeRabbit finding on open PR fix(atlas-search): cap get-chunk --neighbors at 100 #6322 (no command-level test covers the get-chunk --neighbors cap). Review the PR myself: verify the gap on the PR head; if valid, add the command-level regression test on the PR branch, reply to the review, and evaluate the PR for merge
Expectation: effort s–m; done = finding dispositioned with evidence (test added + PR evaluated, or refuted with reasons), labels in sync, fallback release posted
Links: claim marker comment above

Heartbeat: verified — PR #6322 OPEN, head 3468777 unchanged since the CodeRabbit review, no hard-stop labels. Acceptance note for issue #6594: the test lands with PR #6322 and the source review thread is NOT replied to (pr-comment-review job rule recorded on the issue). Next: add the command-level test on the PR branch (get-chunk --neighbors 101 via run_bin, exit 2 + bound message), run the cli_parity suite on the laptop, push, evaluate merge.

test(atlas-search): command-level coverage for the get-chunk --neighb…

Released by repo-worker-code-p (fallback mode): issue #6594 complete — the missing command-level test was added to PR #6322 in 0ccd562 (cli_get_chunk_neighbors_above_cap_exits_2 in tests/cli_parity.rs: binary invoked with --neighbors 101 asserts exit 2 and the bound message on stderr), verified on the laptop (atlas-search suite 26 unit + 5 cli_parity pass; the new test fails when the call-site cap is removed, proving it guards main.rs:668), Codex re-review of the new commit completed with no findings, and PR #6322 merged (90a5463; underlying issue #5600 closed by the merge). Per this issue's recorded rule, the source CodeRabbit review thread was not replied to. Closing this issue as done.

🤖 Agent note · done

Agent: queue worker (repo-worker-code), lane code-p
Session / ID: repo-queue-worker-shift-p cron run 2026-11-06 20:17 CST — FALLBACK MODE (queue backend down, code#6619; fallback markers are the claim of record, no broker task id this shift)
Found via: queue fallback scan (queue/queued label, scan order)
Task: issue atlas-search: no command-level test covers the get-chunk --neighbors cap (PR #6322) #6594 complete — command-level neighbors-cap test landed on PR fix(atlas-search): cap get-chunk --neighbors at 100 #6322 (0ccd562), failing-first verified, PR merged (90a5463), issue atlas-search: CLI get-chunk --neighbors has no upper bound — standalone returns the whole message, bypassing the service's 100-neighbor cap #5600 closed by the merge
Expectation: issue atlas-search: no command-level test covers the get-chunk --neighbors cap (PR #6322) #6594 closes as done
Links: PR fix(atlas-search): cap get-chunk --neighbors at 100 #6322

Navigation Menu

Repository navigation

atlas-search: no command-level test covers the get-chunk --neighbors cap (PR #6322) #6594

Finding (unaddressed PR review comment)

No-response evidence

Still-live evidence

Acceptance criteria

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

atlas-search: no command-level test covers the get-chunk --neighbors cap (PR #6322) #6594

Description

Finding (unaddressed PR review comment)

No-response evidence

Still-live evidence

Acceptance criteria

Activity

developing-today commented on Nov 6, 2026

dezren39 commented on Nov 6, 2026

dezren39 commented on Nov 7, 2026

dezren39 commented on Nov 7, 2026

dezren39 commented on Nov 7, 2026

dezren39 commented on Nov 7, 2026

dezren39 commented on Nov 7, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions