Repository navigation
id phase-8: P8.8 clippy/lint sweep deferred — ~150 clippy warnings remain with no tracking issue #803
Description
Finding
P8.8 (clippy and other lint sweeps) is deferred "do nothing now", but the accumulating warnings have no tracking issue, so the cleanup can be forgotten.
Evidence
doc/2026-10-11T11-08-42Z_design_remaining_work/plan-phases.md§12 Phase 8: "P8.8 Clippy and other lints: the owner's 9k-error lint output and the 1.99 lints. Review later. Do nothing now."- Phase 0 record
doc/2026-10-11T19-04-32Z_phase_0_baseline/...mdOpen items: "just checkruns clippy with-D warningsin the Nix check, and about 150 warnings remain after the 1.99 allows. This waits for P8.8, as the owner decided." - Phase 8 record
doc/2026-10-13T23-44-27Z_phase_8_open_design_items/...md: "P8.8 clippy/lint sweeps (review later; do nothing now)."
Why it matters
just check runs clippy with -D warnings in CI; if the warning count grows (or a new toolchain turns warnings into denials), the CI signal degrades. The known ~150 warnings plus the two allowed 1.99 lint names are a deliberate debt that should be visible as an issue until the owner's lints review happens.
Suggested scope
Do the owner's lints review: fix the ~150 warnings, decide on the two allowed 1.99 lint names, and keep just check green. Not urgent; track only so it is not lost.
Acceptance criteria
- Either the ~150 remaining clippy warnings are driven to zero (or to an explicitly allowed, documented set) so
just check's clippy-D warningsleg is meaningful, or the owner's P8.8 lints review happens and records which warnings are permanently allowed and why. - The two allowed 1.99 lint names are re-justified or removed as part of the same pass.
- This issue stays open as the tracking item until one of those outcomes is recorded; it is not closed by partial cleanups alone.
Metadata
Metadata
Assignees
Labels
Package/app: id (pkgs/ or apps/ in this repo)Medium: expected under 1 day of workTechnical debt worth paying down deliberatelyIntake review done: acceptance criteria, links, and normalized labels addedFully doable remotely: design, config, code, cloudNice to have; do when convenientFiled by the new-issue-creator jobQueue packet kind: verify, reproduce, and route this item
Activity
developing-today commentedon Oct 24, 2026
CODE-120
dezren39 commentedon Oct 26, 2026
Intake review
Related: Filed in the phases 0–10 review batch (PR #804). No merged PR resolves this (verified 2026-10-26).
Notes: This is deliberately deferred owner debt (P8.8: "review later, do nothing now") — its value is existing as a visible tracking item so the ~150 warnings cannot be forgotten while
just checkruns clippy with-D warnings. Priority low is deliberate; do not let a sweep pick this up as routine work ahead of the owner's lints review. Acceptance criteria appended by this intake pass; original body preserved verbatim above them.Risks: A bulk warning cleanup without the owner's review could churn many files and mask real signals; staged, per-lint PRs are safer.
Suggested approach: When P8.8 is scheduled, group warnings by lint, fix or allow each group in its own PR, and record the allowed set in the repo's lint config.
dezren39 commentedon Oct 28, 2026
🤖 Agent note · picked up
dezren39 commentedon Oct 28, 2026
🤖 Agent note · done
Triage verdict: CONFIRMED as tracked, owner-deferred debt — stays open as the tracker
Verified at main HEAD
35726e8e9d93698e9922e85ba5d072d557edb36d(2026-10-28T18:50:35Z):doc/2026-10-11T11-08-42Z_design_remaining_work/plan-phases.md:206— "P8.8 Clippy and other lints: the owner's 9k-error lint output and the 1.99 lints. Review later. Do nothing now." (repeated at line 260: "Lints review later (P8.8).")#[allow(clippy::…)]attributes are spread across 20+ files underpkgs/id/src/(code search at HEAD: seitan, rejection, encryption, qr, friendship, dht, groups/log, membership, pull_policy, tuple, invite, access, frames, web/assets, tag_index, …), alongsidepkgs/id/clippy.tomland the clippy leg inpkgs/id/check-all/ the justfile.Route: no
small_fixpacket — the sweep is a large cleanup the owner explicitly deferred ("do nothing now"), and the issue's own acceptance criteria say it "stays open as the tracking item until one of those outcomes is recorded; it is not closed by partial cleanups alone." Triage is complete; #803 remains open as the tracker for the owner's P8.8 lints review, recorded in the code backlog so it is not lost. When Drew schedules the lints review, this issue is the work order: drive warnings to zero or record the permanently-allowed set, and re-justify or remove the two allowed 1.99 lint names.12 remaining items
dezren39 commentedon Nov 3, 2026
agent-note:v1
state: triaged (coverage pass)
Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 30 (priority/low). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
Found via: coverage pass 2026-11-03
dezren39 commentedon Nov 4, 2026
agent-note:v1
task: 8092
lane: 02cafe76-eafd-4d0b-aaa6-2b7a737d68dc
transition: picked up
Refreshing the prior P8.8 triage verdict against current main and issue/PR state. This is triage only; I will not begin the deferred lint cleanup in this task.
dezren39 commentedon Nov 4, 2026
agent-note:v1
task: 8092
lane: 02cafe76-eafd-4d0b-aaa6-2b7a737d68dc
transition: triaged
P8.8 triage refresh (2026-11-04 UTC)
Verified against current
origin/main6a1a351acbd59652cacc0e5a7bce56974368b29:doc/2026-10-11T11-08-42Z_design_remaining_work/plan-phases.md:206still says “Review later. Do nothing now”; line 260 repeats “Lints review later (P8.8).” The currentpkgs/id/Cargo.tomlstill enables the Clippy groups at warning level with critical lints denied. Prior triage 2241 and re-verification 7597 already confirmed the recorded ~150-warning debt and the owner's deferral.Duplicate/overlap check: #804 and #153 are merged; the only open PR found by
clippy in:title, #3255, is a draft fixing CI/#2970 (including a bounded set of Rust 1.99 warnings), not the P8.8 sweep, and it is not linked to #803.Disposition: this remains deliberate owner-deferred debt; keep #803 OPEN as the tracker and do not enqueue a cleanup packet until the owner lifts the “do nothing now” decision. No code changed and no new decision is being escalated.