Repository navigation
(index): tighten the #733 continuation test and cover the post-header stat check (follow-up #878) #879
Description
Follow-up of #878 (#874), review minors.
- Misleading assertion message.
test/continuation-refresh-718.test.js~157: the grow case defers only because OTHER comes first infilesand spends the shared budget. Withnew Set([OLD, OTHER])the case fails, because OLD is scanned and published. Reword the message ("OTHER has spent the shared budget") and assert that precondition. - Field list too short.
test/continuation-refresh-718.test.js~160 leaves outaiTitle,slugand the other display fields, so a title-overwrite mutation survives these tests. AddaiTitleandslug, and comparecustomTitle || ''. - Unguarded check, predates (index): fix the #733 continuation test's expectation after fileSize (#874) #878. No test kills the removal of the post-header stat check in
session-cache.js~573-577; the final check at ~706-715 masks it. Add a dedicated race test, or remove the check as redundant.
Activity
devsuitup commentedon Oct 29, 2026
Another continuation test flake, on #883 (which touches no cache code),
test (20, ubuntu-latest)run 40941072321:test/continuation-refresh-writer-718.test.js:71'D2 shipped readonly worker awaits cold preparation and progress, zero marker=true' timed out after 9000 ms (testTimeoutFailure). An ENOENT continuation read on the fixture's transcript was logged just before it. Check whether that test's 9 s budget is enough on a loaded runner, or whether the ENOENT path can leave the readonly worker waiting.(index): make the continuation tests deterministic and drop a redunda…