Skip to content

(ci): declare js-yaml as a devDependency, state the asset count of a release without macOS #931

Open

Description

@devsuitup

Follow-up of #930 (#899) review.

  • test/build-workflow.test.js requires js-yaml, which is not in package.json: it is hoisted from electron-updater, app-builder-lib and @eslint/eslintrc. A dependency update that stops hoisting it breaks the test with MODULE_NOT_FOUND. Add js-yaml to devDependencies (lock regenerated session-side with npx npm@10 --package-lock-only).
  • docs/releasing.md step 5 counts 19 assets for a full build only. A release drafted by hand without macOS has fewer (derived, not measured: 10 — minus the 4 dmg/zip, 4 blockmaps and latest-mac.yml). Measure on the next mac-less draft and state the count.

no-changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions