Use AWS ECR login method with a custom domain

[pawelmitka]

Behaviour

Currently the ECR login method depends on isEcr which verifies an address. However, we would like to use a custom domain with ECR to simplify our Dockerfiles.

Steps to reproduce this issue

1. Create an action in workflow with a custom domain for ECR private registry
2. Run workflow

Expected behaviour

Action correctly logins to ECR despite custom address using loginECR

Actual behaviour

login-action does not login to ECR using loginECR

Configuration

• Repository URL (if public):
• Build URL (if public):

     - name: Login to ECR
        uses: docker/login-action@v1
        with:
          registry: custom.io
          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

Solution

I think, it would be the best to add an optional flag isECR to the configuration to allow use of ECR login despite custom domain usage.

[pawelmitka]

@crazy-max could you advise what you think about a proposed solution?

[crazy-max]

@pawelmitka Can you try with?:

     - name: Login to ECR
        uses: crazy-max/docker-login-action@ecr-input
        with:
          registry: custom.io
          username: ${{ secrets.AWS_ACCESS_KEY_ID }}
          password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
          ecr: true