allow for use of loginStandard functionality with docker login - #50
Closed
dbeal-wiser wants to merge 6 commits into
Closed
allow for use of loginStandard functionality with docker login#50dbeal-wiser wants to merge 6 commits into
dbeal-wiser wants to merge 6 commits into
Conversation
Author
|
are the test failures because my PR is running from another repo? |
crazy-max
requested changes
Dec 16, 2021
crazy-max
left a comment
crazy-max
left a comment
Member
There was a problem hiding this comment.
Logs for failing tests are not available anymore. Can you rebase to trigger the CI again? Thx.
| registry: | ||
| description: 'Server address of Docker registry. If not set then will default to Docker Hub' | ||
| required: false | ||
| isECR: |
Member
There was a problem hiding this comment.
I think naming it ecr is enough
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our pipelines actually supply the exact username and password without AWS credentials. I recognize this is unusual, but it should be possible to override the automatic detection functionality. This PR adds an option,
isECR, which allows for theloginStandardfunctionality to be used even if ECR is detected.Original behavior should not be altered unless user specifies
isECRoption.suggest
Squash and Mergefor this PR.