Skip to content

Support language features in metadata / decompiled source files #5787

Closed
dotnet/roslyn
#74488

Description

@dibarbet

Currently it looks like all metadata as source files are going into the LSP misc workspace. This appears to be because TryAddDocumentToWorkspace never gets called. In VS this is called when the file is opened (the misc files workspace sees it and puts the document in the workspace). Since a solution is never created in the metadata workspace because the file is never added, the metadata workspace is also not registered.

Activity

  1. added this to the Backlog milestone on Jun 13, 2023
  2. modified the milestones: Backlog, Post GA on Jun 16, 2023
  3. modified the milestones: Post GA, Next on Aug 2, 2023
  4. changed the title [-]MetadataAsSource files not added to MetadataAsSource workspace (and workspace is not registered[/-] [+]Support language features in metadata / decompiled source files[/+] on Sep 13, 2023
  5. dibarbet commented on Sep 13, 2023

    @dibarbet
    MemberAuthor

    Scenarios here

    1. Go to definition from metadata references
    2. Document outline - Provide outline and breadcrumbs for read-only (generated, decompiled) sources #6341
  6. daniel-tonic commented on Feb 26, 2024

    @daniel-tonic

    Is there any update on this? This seems like a pretty big miss from a feature-parity perspective and it's been several months since this ticket was updated.

  7. hsm207 commented on Mar 31, 2024

    @hsm207

    Just encountered #6021 but only for some projects in a solution.

    I'm on version 2.22.5 and everytime I reload the window, the C# output pane shows this:

    Using dotnet configured on PATH
    Dotnet path: /usr/share/dotnet/dotnet
    Activating C# + C# Dev Kit...
    waiting for named pipe information from server...
    [stdout] {"pipeName":"/tmp/c8da874b.sock"}
    received named pipe information from server
    attempting to connect client to server...
    client has connected to server
    [Info  - 3:42:10 AM] [Program] Language server initialized
    [Error - 3:42:11 AM] Request textDocument/semanticTokens/range failed.
      Message: Unsupported extension '' and LSP language id ''
      Code: -32000 
    [object Object]
    [Error - 3:42:11 AM] Request textDocument/semanticTokens/range failed.
      Message: Unsupported extension '' and LSP language id ''
      Code: -32000 
    [object Object]
    
  8. whitecostume commented on May 22, 2024

    @whitecostume

    Still not solved?

  9. dibarbet commented on Jul 26, 2024

    @dibarbet
    MemberAuthor

    This should be available in the next prerelease update to the extension. Will update here once it is published.

  10. dibarbet commented on Jul 31, 2024

    @dibarbet
    MemberAuthor

    This should now be available in v2.41.26 (pre-release).

  11. SherbetHead commented on Sep 10, 2024

    @SherbetHead

    @dibarbet, thank you for fixing this. it was working great for a while, but unfortunately I'm having this issue again with the latest pre-release version and the latest release version of c# extension. Your fix was working when vs code was opening source files as "decompiled metadata as source" but it seems that the most recent versions of the c# extension are opening the same source files in a SymbolCache directory.

  12. dibarbet commented on Sep 10, 2024

    @dibarbet
    MemberAuthor

    @SherbetHead yeah there is an issue with sourcelink in the latest version. We're working on a fix and should have it out this week.

  13. HunterZ commented on Oct 8, 2024

    @HunterZ

    What's the status on this? It's frustrating only being able to navigate one level deep into decompiled code.

  14. dibarbet commented on Oct 8, 2024

    @dibarbet
    MemberAuthor

    @HunterZ this should be available in the latest versions of the extension (either release or prerelease). If you're having problems on the latest version, would you mind filing a new issue? Would be helpful to include the C# logs - https://github.com/dotnet/vscode-csharp/blob/main/SUPPORT.md#collecting-general-logs as well as any information on where the symbols you're navigating to are coming from.

  15. HunterZ commented on Oct 18, 2024

    @HunterZ

    After having never worked, this suddenly seems to have started working a few days ago. I guess it just took 2-3 months to get into a release version.

  16. modified the milestones: Next, July2024 on Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions