Skip to content

Hardening suggestions for appscan-sdk / pixeebot/drip-2024-08-27-appscan-java/improper-hostname-validation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 1 commit into
base: pixeebot/drip-2024-08-27-appscan-java/improper-hostname-validation
Choose a base branch
from
Open

Hardening suggestions for appscan-sdk / pixeebot/drip-2024-08-27-appscan-java/improper-hostname-validation #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@
<artifactId>wink-json4j</artifactId>
<version>1.4</version>
</dependency>
</dependencies>
<dependency>
<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
</dependency>
</dependencies>

<profiles>
<profile>
Expand Down Expand Up @@ -139,4 +143,16 @@
<tag>HEAD</tag>
</scm>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.github.pixee</groupId>
<artifactId>java-security-toolkit</artifactId>
<version>${versions.java-security-toolkit}</version>
</dependency>
</dependencies>
</dependencyManagement>
<properties>
<versions.java-security-toolkit>1.2.0</versions.java-security-toolkit>
</properties>
</project>
4 changes: 3 additions & 1 deletion src/main/java/com/hcl/appscan/sdk/http/HttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
*/

package com.hcl.appscan.sdk.http;
import io.github.pixee.security.HostValidator;
import io.github.pixee.security.Urls;
import org.apache.wink.json4j.JSONException;
import org.apache.wink.json4j.JSONObject;
import java.io.DataOutputStream;
Expand Down Expand Up @@ -330,7 +332,7 @@ private HttpResponse makeRequest(Method method, String url,

private HttpURLConnection makeConnection(String url, Method method,
Map<String, String> headerProperties) throws IOException {
URL requestURL = new URL(url);
URL requestURL = Urls.create(url, Urls.HTTP_PROTOCOLS, HostValidator.DENY_COMMON_INFRASTRUCTURE_TARGETS);
HttpURLConnection conn = null;
conn = (HttpURLConnection) requestURL.openConnection(m_proxy);
conn.setRequestMethod(method.name());
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/com/hcl/appscan/sdk/http/HttpsClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

package com.hcl.appscan.sdk.http;

import io.github.pixee.security.HostValidator;
import io.github.pixee.security.Urls;
import java.io.DataOutputStream;
import java.io.IOException;
//import java.net.HttpsURLConnection;
Expand Down Expand Up @@ -268,7 +270,7 @@ private HttpResponse makeRequest(Method method, String url,

private HttpsURLConnection makeConnection(String url, Method method,
Map<String, String> headerProperties) throws IOException {
URL requestURL = new URL(url);
URL requestURL = Urls.create(url, Urls.HTTP_PROTOCOLS, HostValidator.DENY_COMMON_INFRASTRUCTURE_TARGETS);

try {
SSLContext sc = SSLContext.getInstance("TLS");
Expand Down