This repository was archived by the owner on Aug 11, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 11, 2025. It is now read-only.
Improve collapse all icon #114
Description
The most "disruptive" icon in the toolbar (in the dark theme) is currently the collapse all icon. Compare is with the min-max icons which look IMHO really good in the screenshot.
@Michael5601 @BeckerWdf if you agree, could you improve this icon? This would be a very fast quick win,
Activity
vogella commentedon Nov 28, 2024
#108
BeckerWdf commentedon Nov 28, 2024
So what you say is that it's to bright?
So then also the filter icon is quite bright.
Michael5601 commentedon Nov 28, 2024
I also can't see what you mean with disruptive. Can you elaborate?
It is also hard to compare the collapse icon with the right icons as they look like they are from a different "theme". I know they are not but they look better to you in dark mode as they are designed like modern icons. In a modern icon pack every icon would be tested to function in a dark theme.
HeikoKlare commentedon Nov 28, 2024
Note that the min/max icons are no classic icons at all. These icons are programatically rendered via an ImageDataProvider.
vogella commentedon Nov 28, 2024
It is too bright and has a blue gradient. I think removing the gradient and making its background a bit transparent would hugely improve the icon.
vogella commentedon Nov 28, 2024
Current icons:
vogella commentedon Nov 28, 2024
Suggested new:
vogella commentedon Nov 28, 2024
Or
or
BeckerWdf commentedon Nov 29, 2024
I will try to improve the icon.
BeckerWdf commentedon Nov 29, 2024
"Package Explorer" has the current Icon "Project Explorer" has my changed icon:
I have the impression the stroke color is to pale. The hard thing here is that this should look good on light and dark theme.
If I make the stroke color darker then the contrast ist good on the light background but worse on dark background.
vogella commentedon Nov 29, 2024
New icon looks already way better than the old one.
BeckerWdf commentedon Nov 29, 2024
I don't agree. The missing color makes it look like it's disabled - especially in the dark theme.
BeckerWdf commentedon Nov 29, 2024
It's not possible to judge in Inkscape if this looks good or not. One has to see it on the correct background and inside the workbench to see how it really looks like.
BeckerWdf commentedon Nov 29, 2024
Some as above:
It's not possible to judge in Inkscape if this looks good or not. One has to see it on the correct background and inside the workbench to see how it really looks like.
merks commentedon Nov 29, 2024
FYI, for some reason your images don't show up:
BeckerWdf commentedon Nov 29, 2024
This is a quote from Lars' images. Do they show up?
merks commentedon Nov 29, 2024
I see it's an issue with quoted images!
My image shows up in Firefox but not in a browser where I've not logged in to GitHub...
BeckerWdf commentedon Nov 29, 2024
Yet another idea. Now with some blue color (no gradient) so that it does not look disabled in the dark theme:
vogella commentedon Nov 29, 2024
I dislike the stronger usage of blue in the new proposal make the icon look wither more like it's for Windows95
merks commentedon Nov 29, 2024
This is just an observation. I'll bet a lot of downstream projects have copies of the expand-all / collapse-all icons so we're bound do have variations of these in the future within the same IDE, e.g.,
This is not an argument against change, just an observation
(that this is what happens when icons are not API and cannot be reused).BeckerWdf commentedon Dec 17, 2024
I don't find a solution that is betten compared to what we have today.
HeikoKlare commentedon Aug 10, 2025
This sounds like there is no progress to make here and the issue seems to be rather stalled in general.
@BeckerWdf @vogella Since this repository is about to be archived, can we close this issue or is there a need for having a follow-up somewhere else?
BeckerWdf commentedon Aug 11, 2025
We can close this.