GC#drawIcon draws *.ico(for some icons) with black background on Windows 10

Describe the bug
Please run the attached snippet on Windows 10 (default Windows mode: Dark, default app mode: light). It will get the icons for certain file types and render them. For some reason, the background of the images is rendered in black.
ProgramImageTest.java.txt

To Reproduce
See above.

Expected behavior
The background should be transparent.

Screenshots

Environment:
Windows 10, Version 21H1 (OS Build 19043.1706)

@tmssngr

@tmssngr :

which Eclipse / SWT version is this?
is this a regression? If yes, which version was OK?

This is reproducible with the latest SWT built from source (v4952r11). With bisecting I've found out that commit 22797d3 Revert "Revert "Bug 493455 - [win32] remove alpha and alphaData from Image"" introduced this bug.

This is reproducible with the latest SWT built from source (v4952r11). With bisecting I've found out that commit 22797d3 Revert "Revert "Bug 493455 - [win32] remove alpha and alphaData from Image"" introduced this bug.

@jonathan.meier@outlook.com
Please have a look.

@SyntevoAlex

I don't see this problem happening in Eclipse.

@SyntevoAlex @Phillipus
Do you see this problem in any of you Eclipse based applications ?
We are just trying to understand how severe is this problem.

@tmssngr

I don't have those program icons on my system, so when I run the snippet the program icons I have render OK. @tmssngr Can we get an actual icon to test with? Also, is this Hi DPI?

@tmssngr

I don't have those program icons on my system, so when I run the snippet the program icons I have render OK. @tmssngr Can we get an actual icon to test with? Also, is this Hi DPI?

Please share a screen grab on how the icon looks for you.

Please share a screen grab on how the icon looks for you.

Found it.

I had to set Windows custom scaling to 200 or run the snippet with the argument -Dswt.autoScale=200

Eclipse at HiDPI is working fine for External Program Icons:

So problem seems specific to this test-snippet only.

It seems to be only some Program icons that have this problem.

Try running this modified snippet:

Modified Snippet

import java.util.List;
import java.util.*;

import org.eclipse.swt.*;
import org.eclipse.swt.graphics.*;
import org.eclipse.swt.program.*;
import org.eclipse.swt.widgets.*;

public class ProgramImageTest {

    public static void main(String[] args) {
        final Display display = new Display();

        final List<Image> images = createImages(display);

        final Shell shell = new Shell(display);

        shell.addListener(SWT.Paint, event -> {
            int x = 0;
            int y = 0;
            for(Image image : images) {
                event.gc.drawImage(image, x, y);
                x += image.getImageData().width;
                x += 10;
                if(x > 400) {
                    x = 0;
                    y += 24;
                }
            }
        });

        shell.setSize(400, 300);
        shell.open();

        while(!shell.isDisposed()) {
            if(!display.readAndDispatch()) {
                display.sleep();
            }
        }

        for(Image image : images) {
            image.dispose();
        }

        display.dispose();
    }

    private static List<Image> createImages(Display display) {
        final List<Image> images = new ArrayList<>();

        for(Program p : Program.getPrograms()) {
            final ImageData data = p.getImageData();
            if(data == null) {
                continue;
            }

            images.add(new Image(display, data));
        }

        return images;
    }
}

Strange, now I am able to reproduce this with scaling at 100%:

Interestingly problem is seen only with second run onward irrespective of zoom.
Even got it working with 200% as well:

Revised steps to reproduce the issue with test-snippet:

Switch the Windows Display zoom 100% to 200%(or visa versa)
Run the test-snippet, it will works on either zoom.
Close it and relaunch, problem is seen.

@jonathan-meier

I will provide a PR with a fix for this issue as soon as possible. Thanks everyone for providing insights helping debug this issue

@jonathan-meier Hi, did you find some time to implement a PR? Happy to test it if required. 👍

@jonathan-meier

@jonathan-meier Unfortunately, your maskColor method doesn't resolve the problem for me (Windows 10).

@tmssngr

This is reproducible with the latest SWT built from source (v4952r11). With bisecting I've found out that commit 22797d3 Revert "Revert "Bug 493455 - [win32] remove alpha and alphaData from Image"" introduced this bug.

@tmssngr Do you think if we reverted this, it would solve the regression?

I've tried reverting e891658, 819a24e, def5c63 and 22797d3, but then it did not compile any more because of a missing hDC in Image. Because I'm not an expert in the internals, I've aborted my tests.

I really would appreciate it if this obvious regression could be fixed soon.

@jonathan-meier

I really would appreciate it if this obvious regression could be fixed soon.

@jonathan-meier Hi Jonathan, do you think it is possible to fix this regression?

The problem is here

eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java

Lines 1800 to 1803 in 6f2f07c

case 32:

newDepth = 24;

newPalette = new PaletteData(0xFF, 0xFF00, 0xFF0000);

break;

In commit 22797d3 I changed this from
case 32:
	if (!(redMask == 0xFF00 && greenMask == 0xFF0000 && blueMask == 0xFF000000)) {
		newPalette = new PaletteData(0xFF00, 0xFF0000, 0xFF000000);
	}
	break;

Based on above input, I have a working fix for this issue:

Will share a PR for testing shortly.

GC#drawIcon draws *.ico(for some icons) with black background on

@niraj-modi

@niraj-modi Hi Niraj, thanks for taking a look at this. I tested your patch with the example case in #185 (comment) and I can confirm it seems to fix the problem.

GC#drawIcon draws *.ico(for some icons) with black background on

Thanks for the fix.

Navigation Menu

Repository navigation

GC#drawIcon draws *.ico(for some icons) with black background on Windows 10 #185

14 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	case 32:
	newDepth = 24;
	newPalette = new PaletteData(0xFF, 0xFF00, 0xFF0000);
	break;

GC#drawIcon draws *.ico(for some icons) with black background on Windows 10 #185

Description

Activity

iloveeclipse commented on Jun 1, 2022

tmssngr commented on Jun 1, 2022

niraj-modi commented on Jun 1, 2022

niraj-modi commented on Jun 1, 2022

Phillipus commented on Jun 1, 2022

niraj-modi commented on Jun 1, 2022

Phillipus commented on Jun 1, 2022

Phillipus commented on Jun 1, 2022

niraj-modi commented on Jun 1, 2022

Phillipus commented on Jun 1, 2022

Phillipus commented on Jun 1, 2022

niraj-modi commented on Jun 1, 2022

14 remaining items

Phillipus commented on Jun 16, 2022

tmssngr commented on Jul 1, 2022

Phillipus commented on Jul 5, 2022

tmssngr commented on Jul 5, 2022

tmssngr commented on Jul 7, 2022

Phillipus commented on Jul 7, 2022

niraj-modi commented on Jul 7, 2022

Phillipus commented on Jul 7, 2022

tmssngr commented on Jul 11, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions