Skip to content

[regression in 4.24..4.25] DND of trim bar elements (perspective switch, launch group...) don't work properly on Wayland #589

Open

Description

@mickaelistria

Using I20230313-0110 on latest Fedora , I cannot drag and drop the trim bar elements to move them in other parts of the IDE.
I tried to 2022-12 and I cannot do it as well.

I'm pretty sure that was possible not that long ago. I'll try older releases of Eclipse SDK, but I also suspect it can be an issue in OS events supports changed and the dragndrop not properly received by the trimbar.
cc @mbooth101

Activity

  1. iloveeclipse commented on Mar 15, 2023

    @iloveeclipse
    Member

    @mickaelistria : I assume you are using Wayland. On RHEL 7.9 / X11 everything works fine for me, with latest master and with 4.27 release too.

  2. iloveeclipse commented on Mar 15, 2023

    @iloveeclipse
    Member

    Note: there was recently #576 that was supposed to fix some DnD issues on Wayland, may be that caused regression here. @SyntevoAlex : FYI.

  3. mickaelistria commented on Mar 15, 2023

    @mickaelistria
    ContributorAuthor

    Thanks @iloveeclipse ; I ran the same IDE in Xephyr (so using x11 instead of Wayland) and I could drag and drop trimbars; so definitely a Wayland issue.

  4. changed the title [-]drag and drop of trim bar elements (perspective switch, launch group...) don't work any more[/-] [+]drag and drop of trim bar elements (perspective switch, launch group...) don't work on Wayland[/+] on Mar 15, 2023
  5. mbooth101 commented on Mar 15, 2023

    @mbooth101
    Member

    Note: there was recently #576 that was supposed to fix some DnD issues on Wayland, may be that caused regression here. @SyntevoAlex : FYI.

    As @mickaelistria says, it is a problem also in 2022-12, so it seems unlikely that PR #576 caused the problem :-)

    It's well known that Wayland doesn't let applications set the position of their top-level windows. Are these little draggable guys top-level windows?

    trim-drag.webm

    If they are top-level windows, this probably never worked at all on Wayland.

  6. SyntevoAlex commented on Mar 15, 2023

    @SyntevoAlex
    Member

    Works for me in 2022-06 and doesn't work in 2022-12. So my recent commit is not guilty.

  7. mickaelistria commented on Mar 16, 2023

    @mickaelistria
    ContributorAuthor

    I confirm what @SyntevoAlex mentions, this feature is working fine, even on Wayland, in Eclipse 4.24 and was lost in 4.25. Some regression took place.

  8. changed the title [-]drag and drop of trim bar elements (perspective switch, launch group...) don't work on Wayland[/-] [+][regression between 4.24 and 4.25] DND of trim bar elements (perspective switch, launch group...) don't work on Wayland[/+] on Mar 16, 2023
  9. akurtakov commented on Mar 16, 2023

    @akurtakov
    Member

    @mickaelistria I use DnD on Wayland and it works but there is a small "catch" - make sure that your drag operation is starts with small mouse move up otherwise it doesn't get detected on my machine.

  10. mickaelistria commented on Mar 16, 2023

    @mickaelistria
    ContributorAuthor

    @akurtakov I couldn't make it work. Note that I don't have issue with DND in general, it's really just the trimbar stuff that seems stuck.

  11. changed the title [-][regression between 4.24 and 4.25] DND of trim bar elements (perspective switch, launch group...) don't work on Wayland[/-] [+][regression in 4.24..4.25] DND of trim bar elements (perspective switch, launch group...) don't work properly on Wayland[/+] on Mar 16, 2023
  12. mickaelistria commented on Mar 16, 2023

    @mickaelistria
    ContributorAuthor

    @akurtakov I succeeded (after many attemps) to do something with the trick you recommend and confirm it can do the job; but the overall issue is still here

  13. mickaelistria commented on May 9, 2023

    @mickaelistria
    ContributorAuthor

    I'm wondering whether this one could be related to #177 and overall issue about some GTK3 method returning incorrect coordinates with Wayland.

  14. manoda0 commented on May 22, 2024

    @manoda0

    Works for me in 2022-06 and doesn't work in 2022-12. So my recent commit is not guilty.

    I confirm what @SyntevoAlex mentions, this feature is working fine, even on Wayland, in Eclipse 4.24 and was lost in 4.25. Some regression took place.

    I tested in 2022-06, 2022-09 and 2024-03. Eclipse version 2022-06 works with Wayland. Versions 2022-09 and 2024-03 do not.

  15. acarstoiu commented on Jul 4, 2024

    @acarstoiu

    In case anyone needed a confirmation, it still reproduces in Eclipse 4.32 (java.vendor.version=Temurin-21.0.3+9) running on GTK+ 3.24.41 and Wayland 1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Linux/GTKHappens on LinuxWaylandbugSomething isn't workingregressionSomething that used to work

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions