Repository navigation
Dark theme: code completion selection does not have enough contrast -> align with other popular dark themes #1688
Description
Yesterday, I had an interesting call with a user of our source based editor. The user uses Eclipse on a large monitor with the Eclipse dark theme. He showed me that the contrast of the code completion is not high enough for him. Therefore, he always:
a) Opens the code completion
b) Uses tab to highlight the selection. With the highlight the contrast is much better
Here the comparison between:
Selected via tab:
Without tab selection:
Now, imagine the first selection on a large monitor with a high resolution. The contrast is simply not enough.
Here some examples how other IDEs render the selection without the need to press tab.
Intellij:
VS Code:
Both use a light blue which provides more contrast.
I would propose that the dark theme in Eclipse gets adjusted, too. Having to use tab feels like a hack/workaround. What do you think? @BeckerWdf
- [X ] I verified latest Integration Build of Eclipse SDK doesn't provide the feature.
Activity
[-]Light theme: code completion selection does not have enough contrast -> align with other popular dark themes[/-][+]Dark theme: code completion selection does not have enough contrast -> align with other popular dark themes[/+]HeikoKlare commentedon Feb 26, 2024
I agree that having better highlighting would be great. Note that on Windows the issue is even worse, as highlighting in dark theme is always hardly visible: eclipse-platform/eclipse.platform.swt#811
Also note that the GTK implementation already does what you expect. Highlighting of the selected element is always done in a well visible way (no matter whether using tab to have focus or not):
I would really appreciate an improvement here (in particualar if it also applies to Windows), I am only a little concerned that this might be something that the native widgets do not allow to style (at least on Windows).
Edit: Just saw that it actually seems to be possible to modify: #1690
Christopher-Hermann commentedon Apr 23, 2024
With some tweaking of #1690 I successfully activated the new selection highlight coloring feature for code completion. This would resolve the corresponding issue across all platforms.
Another fix (at least for MacOS) would be to set the focus to the code completion every time it is opened. This would eliminate the extraneous step of having to manually select the focus with the tab key.
I hope I found some time the next days/weeks to look into this issue and also finish the work on the mentioned PR #1690.
Always use focus selection color for code completion proposals
Christopher-Hermann commentedon Apr 23, 2024
Fixed with the latest commit in the PR. Code completion proposal selection is now always drawn in the selection color.
Always use focus selection color for code completion proposals
Always use focus selection color for code completion proposals
Always use focus selection color for code completion proposals
Always use focus selection color for code completion proposals
Always use focus selection color for code completion proposals
Highlighting problem when using the dark theme on Windows eclipse-pla…
Highlighting problem when using the dark theme on Windows eclipse-pla…
Highlighting problem when using the dark theme on Windows eclipse-pla…
Highlighting problem when using the dark theme on Windows eclipse-pla…
6 remaining items
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused
Draw completion proposals always as focused