Repository navigation
Align Text related icons according to UI guidelines #2582
Description
After @BeckerWdf and @Michael5601 fixed the misaligned icons at the beginning of the main toolbar, the text icons starts to stand out as misaligned.
Would be great if these could also be aligned according to the current UI standard.
Activity
vogella commentedon Dec 6, 2024
@BeckerWdf can you help here?
BeckerWdf commentedon Dec 6, 2024
Yes I can. I just need to find some time for it.
Fix Objects inside Icons
Fix Objects inside Icons (#119)
BeckerWdf commentedon Dec 17, 2024
@vogella: Is this issue now fixed?
vogella commentedon Dec 17, 2024
Thanks @BeckerWdf, it looks much better for me:
If my sense of order is not mistaken, the last icon looks still looks not centered to me (it is a bit to low AFAICS).
Michael5601 commentedon Dec 17, 2024
This is really a great improvement. I agree the last icon is still not right but the rest is fine.
BeckerWdf commentedon Dec 17, 2024
if you give me the name / location of the icon I can have a look at it.
Michael5601 commentedon Dec 17, 2024
The icon is
pin_editorinorg.eclipse.platform.doc.user\imagesandorg.eclipse.ui\icons\full\etool16.It also has duplicates in:
org.eclipse.search\icons\full\elcl16\pin_view.svgorg.eclipse.jdt.ui\icons\full\elcl16\pin_view.svgeclipse.platform.common\bundles\org.eclipse.jdt.doc.user\images\org.eclipse.jdt.ui\elcl16\pin_view.svgand maybe also
org.eclipse.ui\icons\full\elcl16\pin_view.svgbecause it looks like a half version of the original icon. I don't know if this is wanted.BeckerWdf commentedon Dec 17, 2024
See #2637
Before on top / After below:
I also made some changes to the icon:
Before:
After:
What do you think?
Fix Placement of "Pin Editor" Icon
BeckerWdf commentedon Dec 17, 2024
I could not find a usage of this. Has anybody seen this icon
somewhere in the UI?
It's defined at
eclipse.platform.ui/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/IWorkbenchGraphicConstants.java
Line 50 in 0344b2b
This is in an internal package that is visible to these bundles:
org.eclipse.ui.internal;ui.workbench=split;mandatory:="ui.workbench";
x-friends:="org.eclipse.ui,
org.eclipse.ui.intro,
org.eclipse.ui.ide,
org.eclipse.ui.ide.application,
org.eclipse.ui.views,
org.eclipse.ui.navigator.resources,
org.eclipse.ui.tests.browser,
org.eclipse.debug.ui"
None of these uses the icon. Should we delete it?
vogella commentedon Dec 17, 2024
Yes.
Fix Placement of "Pin Editor" Icon
6 remaining items
Michael5601 commentedon Dec 18, 2024
It's not the one for the search for sure. I don't know about the history.
BeckerWdf commentedon Dec 18, 2024
The history view has it's on version. That is slightly different:
If I change this to the new improved version this looks like this:
New is on top / old is below:
What do you think?
vogella commentedon Dec 18, 2024
New looks better
Fix Placement of "Pin Editor" Icon
Fix Placement of "Pin Editor" Icon
Fix Placement of "Pin Editor" Icon
Fix Placement of "Pin Editor" Icon (#121)
BeckerWdf commentedon Dec 18, 2024
Pls. close when you think this is fixed.
vogella commentedon Dec 18, 2024
I suggest to wait for the your last PRs to be merged, if that is fine for you.
BeckerWdf commentedon Dec 18, 2024
I only see one open PR: eclipse-jdt/eclipse.jdt.ui#1862
Fix Placement of "Pin Editor" Icon
Fix Placement of "Pin Editor" Icon