Repository navigation
unlimited searchs can accidently hang/crash the system #872
Description
When using the ctrl-h search functionality, in some cases if you accidentally put something that matches a lot of files everywhere... the search effectively hangs the IDE for a long time (or indefinitely).
Today's example for me was when I was searching my code base because some one had put "******" some where in our code base so I searched everything for that string so I could remove it... not paying attention to the fact the * will match anything... it hung after about 590,000 matches and was still trying to find more...
If there was a "reasonable limit" - like who really thinks their search was narrow enough if it exceeds 10,000 results.... then it would keep the system responsive and let the user would realise their search criteria probably needs to be better and they can try again.
Activity
Bananeweizen commentedon Feb 25, 2023
I've had the same thought many times. A simple additional preference to stop the search after some amount of results seems reasonable, the quick search also has it.
jukzi commentedon Apr 18, 2023
I ran into that problem sometimes too. @r6squeegee mind to contribute a fix? Should be a configurable limit like the console output buffer.
r6squeegee commentedon Apr 19, 2023
I guess I could have a look. I've never looked at the eclipse source before so no guarantees.
r6squeegee commentedon Apr 27, 2023
eclipse-platform/eclipse.platform.text#184
iloveeclipse commentedon Apr 27, 2023
Note, that we have a regression in this area: eclipse-platform/eclipse.platform.text#187.