[pull] main from github:main - #109
Merged
Merged
Conversation
Closes #1390 Enrich `.github/copilot-instructions.md` with Java details that were present in the standalone copilot-sdk-java repo but missing from the monorepo variant: - **Developer workflows**: add single-test and format-check commands - **Testing & E2E tips**: add snapshot naming convention (snake_case) - **Conventions & patterns**: add code style bullet (Spotless, fluent setters, Javadoc) and porting guidance (CompletableFuture, Jackson) - **Integration & environment**: add pre-commit hook instructions - **Boundaries section** (new): document generated files that must not be hand-edited (`java/src/generated/java/`, `nodejs/src/generated/`, `test/snapshots/`)
…olCall` hook, fix `PingResponse` timestamp type (#1389) ## XL — Regenerated RPC types from `@github/copilot schema` update (288 files) Upgrading the reference implementation version from `^1.0.49-1` to `^1.0.52-1` required updating the `@github/copilot` npm package in `scripts/codegen/`, which brought in schema changes. The Java code generator (`java.ts`) was updated to handle these schema changes, and all generated types were regenerated. - 222 new generated RPC types under `src/generated/java/` (new API surfaces: `SessionEventLogApi`, `SessionMetadataApi`, `SessionQueueApi`, `SessionTasksApi`, `SessionUiApi`, `SessionOptionsApi`, `SessionLspApi`, `SessionMcpApi`, `SessionScheduleApi`, permission `location/path/URL` config types, and more) - 66 modified generated files (field type changes, new fields, new enum values) - Updated `scripts/codegen/java.ts` to handle new schema patterns - Updated `scripts/codegen/package.json` and `package-lock.json` These are all machine-generated. Human review should focus on the `java.ts` codegen script changes; the generated output can be spot-checked. ## M — Port `preMcpToolCall` hook (6 files) New hook that fires before an MCP tool call is dispatched to an MCP server, giving SDK consumers the ability to inspect or modify the call. - New: `PreMcpToolCallHandler.java` (functional interface) - New: `PreMcpToolCallHookInput.java` (input DTO with server name, tool name, arguments) - New: `PreMcpToolCallHookOutput.java` (output DTO with allow/deny/modify) - Modified: `SessionHooks.java` (added onPreMcpToolCall field, getter, setter, hasHooks check) - Modified: `CopilotSession.java` (dispatch "preMcpToolCall" hook name to handler) - New test: `PreMcpToolCallHookTest.java` (unit tests for the new hook) ## S — Fix `PingResponse` timestamp type (2 files) The CLI server changed the ping response timestamp from a numeric epoch (long) to an ISO 8601 string. Updated `PingResponse` record field from `long timestamp` to `String timestamp`, and updated `CopilotClientTest` accordingly. ## S — `SessionLogParams` constructor change (1 file) `SessionLogParams` gained new nullable fields in the schema. Updated the call site in `CopilotSession.log()` to pass the additional null parameters. ## S — Test maintenance (4 files) - `McpAndAgentsTest`: new E2E test for MCP and agents scenario - `PermissionsTest`: minor test adjustment - `SessionEventDeserializationTest`: updated assertions to match new generated types - `GeneratedRpcRecordsCoverageTest`: updated coverage list for new generated types ## S — Infra / metadata (3 files) - `.lastmerge`: updated to `f4d22d70016c377881d86e4c77f8a3f93746ffae` - `pom.xml`: ref-impl version property updated to `^1.0.52-1` - `.github/workflows/copilot-setup-steps.yml`: bump gh-aw setup-cli to `v0.74.8`
* Update @github/copilot to 1.0.52-4 - Updated nodejs and test harness dependencies - Re-ran code generators - Formatted generated code * Fix Rust generation for map RPC results Emit Rust type aliases for top-level map-shaped schemas so generated RPC methods can return opaque object payloads like session.mcp.apps.callTool. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )